You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/06 12:56:03 UTC

[GitHub] [incubator-doris] husterdjx opened a new pull request, #9975: Remove the redundant ”this.”

husterdjx opened a new pull request, #9975:
URL: https://github.com/apache/incubator-doris/pull/9975

   # Proposed changes
   
   Issue Number: no relative issue
   
   ## Problem Summary:
   In Java, we can use `this.` to access class member variables.
   However, In most scenario, `this.` is redundant, just use in constructor functions.We can remove it from non-constructor functions.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: No
   2. Has unit tests been added: No
   3. Has document been added or modified: No
   4. Does it need to update dependencies: No
   5. Are there any changes that cannot be rolled back: No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9975: Remove the redundant ”this.”

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9975:
URL: https://github.com/apache/incubator-doris/pull/9975#issuecomment-1147472174

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] jackwener closed pull request #9975: Remove the redundant ”this.”

Posted by GitBox <gi...@apache.org>.
jackwener closed pull request #9975: Remove the redundant ”this.”
URL: https://github.com/apache/doris/pull/9975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] husterdjx closed pull request #9975: Remove the redundant ”this.”

Posted by GitBox <gi...@apache.org>.
husterdjx closed pull request #9975: Remove the redundant ”this.”
URL: https://github.com/apache/incubator-doris/pull/9975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] husterdjx commented on pull request #9975: Remove the redundant ”this.”

Posted by GitBox <gi...@apache.org>.
husterdjx commented on PR #9975:
URL: https://github.com/apache/incubator-doris/pull/9975#issuecomment-1147468503

   @jackwener I'm not sure about these `this.` in line 102, 111 because there are Local variables with the same name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] jackwener commented on pull request #9975: Remove the redundant ”this.”

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9975:
URL: https://github.com/apache/incubator-doris/pull/9975#issuecomment-1147471419

   > @jackwener I'm not sure about these `this.` in line 102, 111 because there are Local variables with the same name.
   
   It's ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org