You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/02/28 02:25:14 UTC
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12630
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
This patch updates create-test-configuration.sh to not fail due to
missing PostgreSQL JDBC driver when FE has not been built by
downloading it from Maven Central instead. When the JDBC driver
already exists in ${POSTGRES_JDBC_DRIVER}, it will use that instead.
Testing:
Manually ran create-test-configuration.sh with and without FE built.
Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
---
M bin/create-test-configuration.sh
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12630/1
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3873/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 04:58:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12630/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:
http://gerrit.cloudera.org:8080/#/c/12630/1/bin/create-test-configuration.sh@209
PS1, Line 209: if [[ -f "${POSTGRES_JDBC_DRIVER}" ]]; then
> Nit: Should we leave a comment here that explains why this additional check
Done
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 18:42:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2303/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 19:25:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 17:43:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2293/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 02:49:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
This patch updates create-test-configuration.sh to not fail due to
missing PostgreSQL JDBC driver when FE has not been built by
downloading it from Maven Central instead. When the JDBC driver
already exists in ${POSTGRES_JDBC_DRIVER}, it will use that instead.
Testing:
Manually ran create-test-configuration.sh with and without FE built.
Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
---
M bin/create-test-configuration.sh
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12630/2
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 17:41:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
This patch updates create-test-configuration.sh to not fail due to
missing PostgreSQL JDBC driver when FE has not been built by
downloading it from Maven Central instead. When the JDBC driver
already exists in ${POSTGRES_JDBC_DRIVER}, it will use that instead.
Testing:
Manually ran create-test-configuration.sh with and without FE built.
Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Reviewed-on: http://gerrit.cloudera.org:8080/12630
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/create-test-configuration.sh
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3856/
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 22:01:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 04:58:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 4:
Build looks good. Restarting the GVO.
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 04:59:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 09:20:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 3:
> Patch Set 3: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3856/
Error due to flaky test not related to this patch: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/4727/
Will restart the GVO until the build is more stable.
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 22:04:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Seems fine to me. I'll give others a chance to reply, and if no one does within a day, I'll +2.
http://gerrit.cloudera.org:8080/#/c/12630/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:
http://gerrit.cloudera.org:8080/#/c/12630/1/bin/create-test-configuration.sh@209
PS1, Line 209: if [[ -f "${POSTGRES_JDBC_DRIVER}" ]]; then
Nit: Should we leave a comment here that explains why this additional check is needed, maybe with a link to IMPALA-8261?
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 18:27:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 )
Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3856/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6536dcffc1124e79c1ed111ad92d257493cc8feb
Gerrit-Change-Number: 12630
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 17:43:01 +0000
Gerrit-HasComments: No