You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/26 01:25:53 UTC
[GitHub] [druid] loquisgon opened a new pull request #11635: Fix create segment phase of batch ingestion to take segment identifiers that have a non UTC interval…
loquisgon opened a new pull request #11635:
URL: https://github.com/apache/druid/pull/11635
### Description
This fixes an issue were an batch ingestion spec with segment granularity of period and a non UTC time zone would throw an exception during the segment creation phase. The issue is that code previous to to this fix was de-serializing the descriptor.json stored in the persisted directory for the identifier but the de-serialized identifier did not match the original identifier. The deserialized identifier was converted to UTC and the original contained a non-UTC interval. This fix relies on the fact that current code had enough metadata to avoid de-serializing the descriptor JSON but if future (or code elsewhere) code requires this de-serialization with the requirement to obtain the identifier it may still have problems.
The change was in the `BatchAppenderator#push` and related methods.
This PR has:
- [ X] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [X ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11635: Fix create segment phase of batch ingestion to take segment identifiers that have a non UTC interval…
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11635:
URL: https://github.com/apache/druid/pull/11635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11635: Fix create segment phase of batch ingestion to take segment identifiers that have a non UTC interval…
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11635:
URL: https://github.com/apache/druid/pull/11635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] loquisgon closed pull request #11635: Fix create segment phase of batch ingestion to take segment identifiers that have a non UTC interval…
Posted by GitBox <gi...@apache.org>.
loquisgon closed pull request #11635:
URL: https://github.com/apache/druid/pull/11635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org