You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/09 16:11:12 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2145: Configure helix-front Maven project to install yarn
micahstubbs opened a new pull request, #2145:
URL: https://github.com/apache/helix/pull/2145
### Issues
- [x ] My PR addresses the following Helix issues and references them in the PR description:
fix #2114
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR configures the helix-front Maven project to use the Javascript package manager [Yarn](https://yarnpkg.org).
This is accomplished by upgrading the frontend-maven-plugin to the latest version and follow these instructions in that project's docs: https://github.com/eirslett/frontend-maven-plugin#installing-node-and-yarn
This PR is a hotfix for the build issue observed by @junkaixue on Wednesday 6/8.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
```bash
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Helix 1.0.4-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 3.706 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 4.567 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 2.924 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 6.383 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 2.001 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 18.490 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 2.987 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 4.414 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 1.506 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 1.430 s]
[INFO] Apache Helix :: Front End .......................... SUCCESS [ 30.465 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.071 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 2.308 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 1.854 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 1.157 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 0.901 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 1.157 s]
[INFO] Apache Helix :: View Aggregator .................... SUCCESS [ 1.524 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:29 min
[INFO] Finished at: 2022-06-09T09:05:45-07:00
[INFO] ------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2145:
URL: https://github.com/apache/helix/pull/2145#discussion_r893871834
##########
helix-front/pom.xml:
##########
@@ -92,13 +94,13 @@
<execution>
<id>build</id>
+ <phase>process-test-resources</phase>
<goals>
- <goal>npm</goal>
+ <goal>yarn</goal>
</goals>
<configuration>
- <arguments>run-script build</arguments>
+ <arguments>build</arguments>
Review Comment:
The syntax is different between yarn and npm. https://classic.yarnpkg.com/en/docs/cli/run
Ah! it looks like this should be `run build`. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2145:
URL: https://github.com/apache/helix/pull/2145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151549938
I have made two small changes that will hopefully fix the CI build. It turns out we had an old library that we were still importing a stylesheet from. I have removed the old library and updated the style sheet import to refer to the correct new library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2145:
URL: https://github.com/apache/helix/pull/2145#discussion_r893867805
##########
helix-front/pom.xml:
##########
@@ -58,7 +58,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>0.0.22</version>
+ <version>1.12.1</version>
Review Comment:
use latest version to ensure that we have support for `install-node-and-yarn` goal shown below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2145:
URL: https://github.com/apache/helix/pull/2145#discussion_r893869340
##########
helix-front/pom.xml:
##########
@@ -58,7 +58,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>0.0.22</version>
+ <version>1.12.1</version>
Review Comment:
[latest version](https://github.com/eirslett/frontend-maven-plugin/tags) source
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151337334
I just ran this locally:
```
cd helix/helix-front
mvn test
```
and see this output:
```py
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ helix-front ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M3:test (default-test) @ helix-front ---
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit3/3.0.0-M3/surefire-junit3-3.0.0-M3.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit3/3.0.0-M3/surefire-junit3-3.0.0-M3.jar (21 kB at 24 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit3/3.0.0-M3/surefire-junit3-3.0.0-M3.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit3/3.0.0-M3/surefire-junit3-3.0.0-M3.pom (1.7 kB at 11 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M3/common-junit3-3.0.0-M3.pom
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M3/common-junit3-3.0.0-M3.pom (1.6 kB at 9.7 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M3/common-junit3-3.0.0-M3.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M3/common-junit3-3.0.0-M3.jar (12 kB at 68 kB/s)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26.980 s
[INFO] Finished at: 2022-06-09T09:12:26-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-front: suiteXmlFiles is configured, but there is no TestNG dependency -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151349067
:bulb: I think the issue is that the project helix-front has not Maven tests defined at all. The solution in this case is to run mvn test from the helix root directory, not from helix/helix-front.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2145:
URL: https://github.com/apache/helix/pull/2145#discussion_r893873106
##########
helix-front/pom.xml:
##########
@@ -92,13 +94,13 @@
<execution>
<id>build</id>
+ <phase>process-test-resources</phase>
<goals>
- <goal>npm</goal>
+ <goal>yarn</goal>
</goals>
<configuration>
- <arguments>run-script build</arguments>
+ <arguments>build</arguments>
Review Comment:
fixed! For reference, here is the docs page for the npm command previously used, `run-script`: https://docs.npmjs.com/cli/v8/commands/npm-run-script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151532507
This is the error that appears to cause the CI build to fail:
> [INFO] error An unexpected error occurred: "/home/runner/work/helix/helix/helix-front/node_modules/vis-network: Cannot read property 'config' of undefined".
[INFO] info If you think this is a bug, please open a bug report with the information provided in "/home/runner/.config/yarn/global/yarn-error.log".
[INFO] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
https://github.com/apache/helix/runs/6819388259?check_suite_focus=true#step:4:26219
I am working to try to reproduce the locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151356765
Ah hah, it looks like the `yarn install` execution is running before the `install node and yarn` execution is complete.
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#a-build-phase-is-made-up-of-plugin-goals
> (Note: In Maven 2.0.5 and above, multiple goals bound to a phase are executed in the same order as they are declared in the POM, however multiple instances of the same plugin are not supported. Multiple instances of the same plugin are grouped to execute together and ordered in Maven 2.0.11 and above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
junkaixue commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151403083
Did you enable helix-front build in pom.xml of the root? I dont see that change even. Usually helix-front build will take 30 mins not 30s...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151351424
Here's the relevant part of the CI Build `build / build (pull_request)` failure log:
```py
Error: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:yarn (yarn install) on project helix-front: Failed to run task: 'yarn install' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn <args> -rf :helix-front
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2145:
URL: https://github.com/apache/helix/pull/2145#issuecomment-1151480712
HI @junkaixue , I am confused: didn't you enable `helix-front` in the pom.xml of the root in this commit?
https://github.com/apache/helix/commit/1a91797068a71a4bbcdf5c2c4b06e3b62b3f2945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2145: Configure helix-front Maven project to install yarn
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2145:
URL: https://github.com/apache/helix/pull/2145#discussion_r893867805
##########
helix-front/pom.xml:
##########
@@ -58,7 +58,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>0.0.22</version>
+ <version>1.12.1</version>
Review Comment:
use latest version of `frontend-maven-plugin` to ensure that we have support for `install-node-and-yarn` goal shown below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org