You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/15 06:02:31 UTC

Review Request 24731: Allow external isolator flag to be backward compatible

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

Allow external isolator flag to be backward compatible


Diffs
-----

  src/slave/containerizer/containerizer.cpp 0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
-------

make


Thanks,

Timothy Chen


Re: Review Request 24731: Allow external isolator flag to be backward compatible

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/#review50700
-----------------------------------------------------------

Ship it!



src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/24731/#comment88570>

    ExternalContainerizer::create(flags, local)


- Benjamin Hindman


On Aug. 15, 2014, 4:04 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24731/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 4:04 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1580
>     https://issues.apache.org/jira/browse/MESOS-1580
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Allow external isolator flag to be backward compatible
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp 0a262ee04f35f8236826c5ada8e7698838af4db5 
> 
> Diff: https://reviews.apache.org/r/24731/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24731: Allow external isolator flag to be backward compatible

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 5:01 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1580
    https://issues.apache.org/jira/browse/MESOS-1580


Repository: mesos-git


Description (updated)
-------

Allow external isolator flag to be backward compatible


Diffs
-----

  src/slave/containerizer/containerizer.cpp 0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
-------

make


Thanks,

Timothy Chen


Re: Review Request 24731: Allow external isolator flag to be backward compatible

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 5:01 a.m.)


Review request for drill and Benjamin Hindman.


Bugs: MESOS-1580
    https://issues.apache.org/jira/browse/MESOS-1580


Repository: mesos-git


Description (updated)
-------

Review: https://reviews.apache.org/r/24731


Diffs (updated)
-----

  src/slave/containerizer/containerizer.cpp 0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
-------

make


Thanks,

Timothy Chen


Re: Review Request 24731: Allow external isolator flag to be backward compatible

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24731/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 4:04 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1580
    https://issues.apache.org/jira/browse/MESOS-1580


Repository: mesos-git


Description
-------

Allow external isolator flag to be backward compatible


Diffs
-----

  src/slave/containerizer/containerizer.cpp 0a262ee04f35f8236826c5ada8e7698838af4db5 

Diff: https://reviews.apache.org/r/24731/diff/


Testing
-------

make


Thanks,

Timothy Chen