You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/08/29 04:03:06 UTC
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/714
TAJO-1803: Use in-memory derby as the default catalog for unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #714
----
commit 199f164101cbe1185dfcc9cae151bcfe4ab30b48
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-23T13:28:04Z
testing
commit a1c9a6b3761f8d834b7eda3c471cd473e977c081
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-26T01:38:06Z
Merge branch 'mem_derby' of https://github.com/jihoonson/tajo-2 into mem_derby
commit 6db115b00a01cf3cc93b54c3a4cd6a81e6a2decb
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-26T10:15:55Z
success
commit 7a2f4aba1c0d691d0737e897620c76109555d4a6
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-26T12:41:10Z
Merge branch 'mem_derby' of https://github.com/jihoonson/tajo-2 into TAJO-1803
commit f6d564889dcd0a79106f373945d6926ba843651d
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-26T14:46:32Z
Replace MemStore with DerbyStore
commit c29cd501837b28e437c1d93421e71f841b06e16c
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-27T09:46:17Z
Enable external catalog
commit c971249a3e5634cbd0168b61aacac208cdf697bf
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-28T10:07:01Z
TAJO-1803
commit 9da53d4719e32a73b60a376fcf755d15288c7628
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-28T13:27:43Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1803
commit bd68897d98ca7c95fbcb9c3ad82a96ea88ef1357
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-29T02:01:59Z
TAJO-1803
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/714#issuecomment-136656792
Thanks for quick review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/714#discussion_r38402086
--- Diff: tajo-common/src/main/proto/errors.proto ---
@@ -157,6 +157,9 @@ enum ResultCode {
CAT_UPGRADE_REQUIRED = 901; // Migration
CAT_CANNOT_CONNECT = 902; // Cannot connect metadata server
+ // Catalog store
+ UNSUPPORTED_CATALOG_STORE = 905; // Unsupported type of catalog store
--- End diff --
It seems to be necessary the prefix ``CAT``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/714#issuecomment-135927842
I've also fixed some bugs in catalog.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/714#issuecomment-136646103
This patch is ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/714#issuecomment-136654549
I used some trivial comments. You can commit the patch after you reflect them if you agree with my comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/714#issuecomment-136656394
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/714#discussion_r38401421
--- Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java ---
@@ -26,9 +26,11 @@
import org.apache.tajo.TajoConstants;
import org.apache.tajo.TajoProtos.QueryState;
import org.apache.tajo.TajoTestingCluster;
+import org.apache.tajo.catalog.CatalogConstants;
--- End diff --
unused imports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1803: Use in-memory derby as the default c...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson closed the pull request at:
https://github.com/apache/tajo/pull/714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---