You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "rdhabalia (via GitHub)" <gi...@apache.org> on 2023/10/12 23:56:46 UTC
[PR] [feat] [broker] PIP-188 Add support to auto create topic resources into green cluster before migration [part-3] [pulsar]
rdhabalia opened a new pull request, #21354:
URL: https://github.com/apache/pulsar/pull/21354
### Motivation
Right now, topic migration requires pre-req manual steps for admin to create migrated topic's resources into green cluster such as tenant, namespaces, namespace policies, and subscriptions. This PR allows admin to automate this process and perform migration without any manual intervention.
### Modifications
- add config to control auto resource creation for topic migration
- perform topic resource creation at migrated green cluster before starting topic migration
```
./bin/pulsar-admin clusters update-cluster-migration $blueClusterName \
--service-url ${greenClusterServiceURL} \
--broker-url ${greenClusterURL} \
--broker-url-secure ${greenClusterURL} \
--migrated
```
### Result
Broker manages topic resource creation at new migrated/green cluster and then perform topic migration without losing data.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] [broker] PIP-188 Add support to auto create topic resources into green cluster before migration [part-3] [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #21354:
URL: https://github.com/apache/pulsar/pull/21354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] [broker] PIP-188 Add support to auto create topic resources into green cluster before migration [part-3] [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #21354: [feat] [broker] PIP-188 Add support to auto create topic resources into green cluster before migration [part-3]
URL: https://github.com/apache/pulsar/pull/21354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [feat] [broker] PIP-188 Add support to auto create topic resources into green cluster before migration [part-3] [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21354:
URL: https://github.com/apache/pulsar/pull/21354#issuecomment-1762852528
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21354](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (039be25) into [master](https://app.codecov.io/gh/apache/pulsar/commit/1a352f178590a210a9200dfee135089155c2f168?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1a352f1) will **increase** coverage by `3.24%`.
> Report is 2 commits behind head on master.
> The diff coverage is `3.57%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21354 +/- ##
============================================
+ Coverage 33.49% 36.73% +3.24%
+ Complexity 12257 12213 -44
============================================
Files 1636 1711 +75
Lines 127789 130766 +2977
Branches 13963 14281 +318
============================================
+ Hits 42798 48032 +5234
+ Misses 79372 76383 -2989
- Partials 5619 6351 +732
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21354/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.22% <3.57%> (+0.08%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.65% <3.57%> (?)` | |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.89% <3.61%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/pulsar/broker/ServiceConfiguration.java](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `98.05% <100.00%> (+0.10%)` | :arrow_up: |
| [.../java/org/apache/pulsar/admin/cli/CmdClusters.java](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWRDbHVzdGVycy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pache/pulsar/common/policies/data/ClusterData.java](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hZG1pbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jb21tb24vcG9saWNpZXMvZGF0YS9DbHVzdGVyRGF0YS5qYXZh) | `11.11% <0.00%> (-3.18%)` | :arrow_down: |
| [...sar/broker/service/persistent/PersistentTopic.java](https://app.codecov.io/gh/apache/pulsar/pull/21354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFRvcGljLmphdmE=) | `52.57% <1.28%> (+0.34%)` | :arrow_up: |
... and [398 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21354/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org