You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2015/02/27 22:21:28 UTC
[Vote] Tools Release February 27, 2015
Please review and vote on this Tools Release.
Release issue: https://issues.apache.org/jira/browse/CB-8555
All the tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
All the tools have also been published to npm under the rc tag.
Feel free to test them with npm install -g cordova@rc
The packages were published from their corresponding git tags:
cordova-js: 3.8.0 (5934b1b744)
cordova-lib: 4.3.0 (c4fbb6a3e1)
cordova-plugman: 0.23.0 (6ec4d1d006)
cordova-cli: 4.3.0 (f0fed4ad5c)
Upon a successful vote I will upload the archives to dist/, publish
them to NPM, and post the corresponding blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran npm test and built a hello world android cordova project with
device plugin
Re: [Vote] Tools Release February 27, 2015
Posted by Steven Gill <st...@gmail.com>.
The vote has now closed. The results are:
Positive Binding Votes: 4
Steven Gill
Parashuram N
Sergey Grebnov
Andrew Grieve
Negative Binding Votes: 0
The vote has passed.
I will be updating them to the latest tag on npm, moving release into
dist and publishing the blog post (after pulling in PRs)
On Mon, Mar 2, 2015 at 2:41 PM, Steven Gill <st...@gmail.com> wrote:
> haha yes
>
> On Mon, Mar 2, 2015 at 2:41 PM, Parashuram N (MS OPEN TECH) <
> panarasi@microsoft.com> wrote:
>
>> > Since this isn't a blocker, I am going to move ahead with completing
>> this vote thread and finishing off this plugins release.
>>
>> You mean tools release, right ?
>>
>> -----Original Message-----
>> From: Steven Gill [mailto:stevengill97@gmail.com]
>> Sent: Monday, March 2, 2015 2:30 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [Vote] Tools Release February 27, 2015
>>
>> So I push a commit to master that adds defaults.json to npmignore.
>> defaults.json is generated based on a plugin.xml every time the
>> createpackagejson command is run. It won't cause any issues having it
>> bundled but it is better to not have it in.
>>
>> Since this isn't a blocker, I am going to move ahead with completing this
>> vote thread and finishing off this plugins release.
>>
>>
>>
>> On Mon, Mar 2, 2015 at 10:34 AM, Andrew Grieve <ag...@chromium.org>
>> wrote:
>>
>> > Awesome. So long as it's seems alright to you Steve, then I vote +1.
>> >
>> > On Mon, Mar 2, 2015 at 11:26 AM, Parashuram N (MS OPEN TECH) <
>> > panarasi@microsoft.com> wrote:
>> >
>> > > Voting +1
>> > >
>> > > * Verified signatures and hashes. Passed
>> > > * Verified tags manually. Passed
>> > > * Ability to install/uninstall Cordova. Passed
>> > > * Ability to update Cordova. Passed
>> > > * Ability to create blank app for Windows, WP8, Android. Passed
>> > > * Ability to run apps. Passed
>> > > * Reviewed release notes (Passed):
>> > >
>> > > plugman:
>> > > CB-8416 added plugman createpackagejson . command to
>> > > generate a package.json file from plugin.xml
>> > > CB-8370 Update documentation for plugman publish without
>> > > args
>> > >
>> > > cordova-lib
>> > > CB-8472 Can't find config.xml error installing browser
>> > > platform after plugin. (close #167)
>> > > CB-8239 Fix cordova platform add PATH when PATH is relative
>> > > and CWD != project root
>> > > CB-8227 CB8237 CB-8238 Add --save flag and autosave to
>> > > 'cordova platform add', 'cordova platform remove' and 'cordova
>> platform update'
>> > > CB-8239 Fix "platform update" should ignore <cdv:engine>
>> > > (close
>> > > #159)
>> > > CB-8416: added plugman createpackagejson . command to create
>> > > a package.json from plugin.xml
>> > > CB-6973 add spec-plugman to npm run jshint
>> > > CB-6973 fix spec-plugman jshint failures
>> > > CB-8377 Fixed tag parsing (close #156)
>> > > CB-8370 Make "plugman publish" without args default to CWD
>> > > CB-8366 android: Remove empty `<framework>` directory upon
>> > > uninstall
>> > > CB-6973 Enable JSHint for spec-cordova
>> > > CB-8239 Add support for git urls to 'cordova platform add'
>> > > (close
>> > > #148)
>> > > CB-8358 Add `--link` for `platform add` and `platform update`
>> > > CB-6973 remove base rules from individual files in src.
>> > > CB-6973 have base rules in .jshintrc file.
>> > > CB-8168 --list support for cordova-lib (close #145.)
>> > > Chnage plugman test plugins to have IDs as directory names
>> > > Make all test plugin IDs unique
>> > > Empty out contents of plugin test files (and delete some
>> > > unused
>> > > ones)
>> > > CB-8285 Don't create .fetch.json files within plugin
>> directories
>> > > CB-8286 Never persist value of create --link-to within
>> > > .cordova/config.json
>> > > CB-8153 generate cordova_plugins.json for browserify based
>> > projects
>> > > CB-8244 android: Have `plugin add --link` create symlinks
>> > > for `<source-file>`, `<framework>`, etc.
>> > > CB-8226 'cordova platform add' : Look up version in
>> > > config.xml if no version specified
>> > > Delete root .npmignore, since there's no node module there
>> > >
>> > > cordova-js
>> > > CB-8302 Added npm test script
>> > > CB-8300 Added CI configuration files
>> > >
>> > > cordova-cli
>> > > docs update for plugin --save
>> > > CB-8439 Fix 'cordova platform update' documentation to
>> > > include `<plat-spec>` (close #208)
>> > > CB-8379 Have --version print out cordova-lib version if it's
>> > > not the same as CLI's version
>> > > CB-8211, CB-8358 Update `--link` help text
>> > > CB-8168 --list support for CLI (close #205)
>> > > CB-8227 CB-8237 CB-8238 Add --save option to 'cordova
>> > > platform add', 'cordova platform remove' and 'cordova platform update'
>> > > CB-5316 Spell Cordova as a brand unless it's a command or
>> script
>> > > CB-7739 document installing specific version of platforms
>> > >
>> > >
>> > >
>> > >
>> > > On 3/2/15, 8:02 AM, "Steven Gill" <st...@gmail.com> wrote:
>> > >
>> > > >I have defaults.json in gitignore so it doesn't get checked in. It
>> > > >is a mistake to have in there. Definitely would be better to write
>> > > >it to some temp directory outside of source. I'll see if it causes
>> problems.
>> > > >Hopefully
>> > > >it doesn't block release and we can just fix on master. I'll report
>> > back.
>> > > >On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)"
>> > > ><v-...@microsoft.com>
>> > > >wrote:
>> > > >
>> > > >> I vote +1:
>> > > >> * Verified tools installation on windows
>> > > >> * Verified new blank app could be created on windows
>> > > >> * Verified android, ios, windows and wp8 platforms could be
>> > > >> added,
>> > built
>> > > >> and run.
>> > > >>
>> > > >> Thx!
>> > > >> Sergey
>> > > >> -----Original Message-----
>> > > >> From: Mefire O. [mailto:ommenjik@microsoft.com]
>> > > >> Sent: Saturday, February 28, 2015 8:24 AM
>> > > >> To: dev@cordova.apache.org
>> > > >> Subject: RE: [Vote] Tools Release February 27, 2015
>> > > >>
>> > > >> Thinking about it further, I do agree these are non-blocking.
>> > > >> Sorry for delaying the process.
>> > > >>
>> > > >> I vote +1.
>> > > >>
>> > > >> Thanks,
>> > > >> Mefire
>> > > >>
>> > > >> -----Original Message-----
>> > > >> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
>> > > >> Sent: Friday, February 27, 2015 9:11 PM
>> > > >> To: dev@cordova.apache.org
>> > > >> Subject: RE: [Vote] Tools Release February 27, 2015
>> > > >>
>> > > >> Agree with Gorkem, I think these bugs are non-blocking. I don't
>> > > >> think
>> > we
>> > > >> should block the release for this - this only impacts certain
>> > > >>plugins, when using the --save feature. I think it may make sense
>> > > >>to do a patch release, if we don't want to block this release.
>> > > >>
>> > > >> -----Original Message-----
>> > > >> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
>> > > >> Sent: Friday, February 27, 2015 8:53 PM
>> > > >> To: dev@cordova.apache.org
>> > > >> Subject: Re: [Vote] Tools Release February 27, 2015
>> > > >>
>> > > >>
>> > > >>
>> > > >> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>> > > >>
>> > > >> > I've spent some time testing, found two bugs and I vote -1
>> > > >> > until we address those :
>> > > >> > - https://issues.apache.org/jira/browse/CB-8577
>> > > >>
>> > > >> I do not think this is a show stopper, probably not even a bug, I
>> > > >>have not had time to change the old <feature> tags. Actually, it
>> > > >>will make the migration harder if we fix it now.
>> > > >>
>> > > >> > - https://issues.apache.org/jira/browse/CB-8578
>> > > >> No idea about this one. I am still trying to figure out why this
>> > feature
>> > > >> even exists.
>> > > >>
>> > > >> >
>> > > >> > I should be able to send pull requests to fix them shortly.
>> > > >> >
>> > > >> > Thanks,
>> > > >> > Mefire
>> > > >> >
>> > > >> > -----Original Message-----
>> > > >> > From: Mefire O. [mailto:ommenjik@microsoft.com]
>> > > >> > Sent: Friday, February 27, 2015 3:53 PM
>> > > >> > To: dev@cordova.apache.org
>> > > >> > Subject: RE: [Vote] Tools Release February 27, 2015
>> > > >> >
>> > > >> > Steven, Thanks for initiating this.
>> > > >> > I'll be performing some tests/checks and will then cast my vote
>> > > >> > accordingly.
>> > > >> >
>> > > >> > Thanks,
>> > > >> > Mefire
>> > > >> >
>> > > >> > -----Original Message-----
>> > > >> > From: Steven Gill [mailto:stevengill97@gmail.com]
>> > > >> > Sent: Friday, February 27, 2015 1:21 PM
>> > > >> > To: dev@cordova.apache.org
>> > > >> > Subject: [Vote] Tools Release February 27, 2015
>> > > >> >
>> > > >> > Please review and vote on this Tools Release.
>> > > >> >
>> > > >> > Release issue: https://issues.apache.org/jira/browse/CB-8555
>> > > >> >
>> > > >> > All the tools have been published to
>> > > >> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555
>> > > >> > /
>> > > >> >
>> > > >> > All the tools have also been published to npm under the rc tag.
>> > > >> > Feel free to test them with npm install -g cordova@rc
>> > > >> >
>> > > >> > The packages were published from their corresponding git tags:
>> > > >> >
>> > > >> > cordova-js: 3.8.0 (5934b1b744)
>> > > >> > cordova-lib: 4.3.0 (c4fbb6a3e1)
>> > > >> > cordova-plugman: 0.23.0 (6ec4d1d006)
>> > > >> > cordova-cli: 4.3.0 (f0fed4ad5c)
>> > > >> >
>> > > >> >
>> > > >> > Upon a successful vote I will upload the archives to dist/,
>> > > >> > publish them to NPM, and post the corresponding blog post.
>> > > >> >
>> > > >> > Voting guidelines:
>> > > >> >
>> > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti
>> > > ng
>> > > >> > .md
>> > > >> >
>> > > >> > Voting will go on for a minimum of 48 hours.
>> > > >> >
>> > > >> > I vote +1:
>> > > >> > * Ran coho audit-license-headers over the relevant repos
>> > > >> > * Ran coho check-license to ensure all dependencies and
>> > > >> > subdependencies have Apache-compatible licenses
>> > > >> > * Ran npm test and built a hello world android cordova project
>> > > >> > with device plugin
>> > > >> >
>> > > >> >
>> > ---------------------------------------------------------------------
>> > > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > >> > For additional commands, e-mail: dev-help@cordova.apache.org
>> > > >> >
>> > > >> >
>> > > >> >
>> > ---------------------------------------------------------------------
>> > > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > >> > For additional commands, e-mail: dev-help@cordova.apache.org
>> > > >>
>> > > >> -----------------------------------------------------------------
>> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
>> > > >>
>> > > >>
>> > > >> -----------------------------------------------------------------
>> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
>> > > >>
>> > > >>
>> > > >> -----------------------------------------------------------------
>> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
>> > > >>
>> > > >>
>> > > >> -----------------------------------------------------------------
>> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
>> > > >>
>> > > >>
>> > >
>> > >
>> > > --------------------------------------------------------------------
>> > > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > > For additional commands, e-mail: dev-help@cordova.apache.org
>> > >
>> > >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>
Re: [Vote] Tools Release February 27, 2015
Posted by Steven Gill <st...@gmail.com>.
haha yes
On Mon, Mar 2, 2015 at 2:41 PM, Parashuram N (MS OPEN TECH) <
panarasi@microsoft.com> wrote:
> > Since this isn't a blocker, I am going to move ahead with completing
> this vote thread and finishing off this plugins release.
>
> You mean tools release, right ?
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Monday, March 2, 2015 2:30 PM
> To: dev@cordova.apache.org
> Subject: Re: [Vote] Tools Release February 27, 2015
>
> So I push a commit to master that adds defaults.json to npmignore.
> defaults.json is generated based on a plugin.xml every time the
> createpackagejson command is run. It won't cause any issues having it
> bundled but it is better to not have it in.
>
> Since this isn't a blocker, I am going to move ahead with completing this
> vote thread and finishing off this plugins release.
>
>
>
> On Mon, Mar 2, 2015 at 10:34 AM, Andrew Grieve <ag...@chromium.org>
> wrote:
>
> > Awesome. So long as it's seems alright to you Steve, then I vote +1.
> >
> > On Mon, Mar 2, 2015 at 11:26 AM, Parashuram N (MS OPEN TECH) <
> > panarasi@microsoft.com> wrote:
> >
> > > Voting +1
> > >
> > > * Verified signatures and hashes. Passed
> > > * Verified tags manually. Passed
> > > * Ability to install/uninstall Cordova. Passed
> > > * Ability to update Cordova. Passed
> > > * Ability to create blank app for Windows, WP8, Android. Passed
> > > * Ability to run apps. Passed
> > > * Reviewed release notes (Passed):
> > >
> > > plugman:
> > > CB-8416 added plugman createpackagejson . command to
> > > generate a package.json file from plugin.xml
> > > CB-8370 Update documentation for plugman publish without
> > > args
> > >
> > > cordova-lib
> > > CB-8472 Can't find config.xml error installing browser
> > > platform after plugin. (close #167)
> > > CB-8239 Fix cordova platform add PATH when PATH is relative
> > > and CWD != project root
> > > CB-8227 CB8237 CB-8238 Add --save flag and autosave to
> > > 'cordova platform add', 'cordova platform remove' and 'cordova
> platform update'
> > > CB-8239 Fix "platform update" should ignore <cdv:engine>
> > > (close
> > > #159)
> > > CB-8416: added plugman createpackagejson . command to create
> > > a package.json from plugin.xml
> > > CB-6973 add spec-plugman to npm run jshint
> > > CB-6973 fix spec-plugman jshint failures
> > > CB-8377 Fixed tag parsing (close #156)
> > > CB-8370 Make "plugman publish" without args default to CWD
> > > CB-8366 android: Remove empty `<framework>` directory upon
> > > uninstall
> > > CB-6973 Enable JSHint for spec-cordova
> > > CB-8239 Add support for git urls to 'cordova platform add'
> > > (close
> > > #148)
> > > CB-8358 Add `--link` for `platform add` and `platform update`
> > > CB-6973 remove base rules from individual files in src.
> > > CB-6973 have base rules in .jshintrc file.
> > > CB-8168 --list support for cordova-lib (close #145.)
> > > Chnage plugman test plugins to have IDs as directory names
> > > Make all test plugin IDs unique
> > > Empty out contents of plugin test files (and delete some
> > > unused
> > > ones)
> > > CB-8285 Don't create .fetch.json files within plugin
> directories
> > > CB-8286 Never persist value of create --link-to within
> > > .cordova/config.json
> > > CB-8153 generate cordova_plugins.json for browserify based
> > projects
> > > CB-8244 android: Have `plugin add --link` create symlinks
> > > for `<source-file>`, `<framework>`, etc.
> > > CB-8226 'cordova platform add' : Look up version in
> > > config.xml if no version specified
> > > Delete root .npmignore, since there's no node module there
> > >
> > > cordova-js
> > > CB-8302 Added npm test script
> > > CB-8300 Added CI configuration files
> > >
> > > cordova-cli
> > > docs update for plugin --save
> > > CB-8439 Fix 'cordova platform update' documentation to
> > > include `<plat-spec>` (close #208)
> > > CB-8379 Have --version print out cordova-lib version if it's
> > > not the same as CLI's version
> > > CB-8211, CB-8358 Update `--link` help text
> > > CB-8168 --list support for CLI (close #205)
> > > CB-8227 CB-8237 CB-8238 Add --save option to 'cordova
> > > platform add', 'cordova platform remove' and 'cordova platform update'
> > > CB-5316 Spell Cordova as a brand unless it's a command or
> script
> > > CB-7739 document installing specific version of platforms
> > >
> > >
> > >
> > >
> > > On 3/2/15, 8:02 AM, "Steven Gill" <st...@gmail.com> wrote:
> > >
> > > >I have defaults.json in gitignore so it doesn't get checked in. It
> > > >is a mistake to have in there. Definitely would be better to write
> > > >it to some temp directory outside of source. I'll see if it causes
> problems.
> > > >Hopefully
> > > >it doesn't block release and we can just fix on master. I'll report
> > back.
> > > >On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)"
> > > ><v-...@microsoft.com>
> > > >wrote:
> > > >
> > > >> I vote +1:
> > > >> * Verified tools installation on windows
> > > >> * Verified new blank app could be created on windows
> > > >> * Verified android, ios, windows and wp8 platforms could be
> > > >> added,
> > built
> > > >> and run.
> > > >>
> > > >> Thx!
> > > >> Sergey
> > > >> -----Original Message-----
> > > >> From: Mefire O. [mailto:ommenjik@microsoft.com]
> > > >> Sent: Saturday, February 28, 2015 8:24 AM
> > > >> To: dev@cordova.apache.org
> > > >> Subject: RE: [Vote] Tools Release February 27, 2015
> > > >>
> > > >> Thinking about it further, I do agree these are non-blocking.
> > > >> Sorry for delaying the process.
> > > >>
> > > >> I vote +1.
> > > >>
> > > >> Thanks,
> > > >> Mefire
> > > >>
> > > >> -----Original Message-----
> > > >> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
> > > >> Sent: Friday, February 27, 2015 9:11 PM
> > > >> To: dev@cordova.apache.org
> > > >> Subject: RE: [Vote] Tools Release February 27, 2015
> > > >>
> > > >> Agree with Gorkem, I think these bugs are non-blocking. I don't
> > > >> think
> > we
> > > >> should block the release for this - this only impacts certain
> > > >>plugins, when using the --save feature. I think it may make sense
> > > >>to do a patch release, if we don't want to block this release.
> > > >>
> > > >> -----Original Message-----
> > > >> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
> > > >> Sent: Friday, February 27, 2015 8:53 PM
> > > >> To: dev@cordova.apache.org
> > > >> Subject: Re: [Vote] Tools Release February 27, 2015
> > > >>
> > > >>
> > > >>
> > > >> On 27 Feb 2015, at 22:19, Mefire O. wrote:
> > > >>
> > > >> > I've spent some time testing, found two bugs and I vote -1
> > > >> > until we address those :
> > > >> > - https://issues.apache.org/jira/browse/CB-8577
> > > >>
> > > >> I do not think this is a show stopper, probably not even a bug, I
> > > >>have not had time to change the old <feature> tags. Actually, it
> > > >>will make the migration harder if we fix it now.
> > > >>
> > > >> > - https://issues.apache.org/jira/browse/CB-8578
> > > >> No idea about this one. I am still trying to figure out why this
> > feature
> > > >> even exists.
> > > >>
> > > >> >
> > > >> > I should be able to send pull requests to fix them shortly.
> > > >> >
> > > >> > Thanks,
> > > >> > Mefire
> > > >> >
> > > >> > -----Original Message-----
> > > >> > From: Mefire O. [mailto:ommenjik@microsoft.com]
> > > >> > Sent: Friday, February 27, 2015 3:53 PM
> > > >> > To: dev@cordova.apache.org
> > > >> > Subject: RE: [Vote] Tools Release February 27, 2015
> > > >> >
> > > >> > Steven, Thanks for initiating this.
> > > >> > I'll be performing some tests/checks and will then cast my vote
> > > >> > accordingly.
> > > >> >
> > > >> > Thanks,
> > > >> > Mefire
> > > >> >
> > > >> > -----Original Message-----
> > > >> > From: Steven Gill [mailto:stevengill97@gmail.com]
> > > >> > Sent: Friday, February 27, 2015 1:21 PM
> > > >> > To: dev@cordova.apache.org
> > > >> > Subject: [Vote] Tools Release February 27, 2015
> > > >> >
> > > >> > Please review and vote on this Tools Release.
> > > >> >
> > > >> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> > > >> >
> > > >> > All the tools have been published to
> > > >> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555
> > > >> > /
> > > >> >
> > > >> > All the tools have also been published to npm under the rc tag.
> > > >> > Feel free to test them with npm install -g cordova@rc
> > > >> >
> > > >> > The packages were published from their corresponding git tags:
> > > >> >
> > > >> > cordova-js: 3.8.0 (5934b1b744)
> > > >> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> > > >> > cordova-plugman: 0.23.0 (6ec4d1d006)
> > > >> > cordova-cli: 4.3.0 (f0fed4ad5c)
> > > >> >
> > > >> >
> > > >> > Upon a successful vote I will upload the archives to dist/,
> > > >> > publish them to NPM, and post the corresponding blog post.
> > > >> >
> > > >> > Voting guidelines:
> > > >> >
> > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti
> > > ng
> > > >> > .md
> > > >> >
> > > >> > Voting will go on for a minimum of 48 hours.
> > > >> >
> > > >> > I vote +1:
> > > >> > * Ran coho audit-license-headers over the relevant repos
> > > >> > * Ran coho check-license to ensure all dependencies and
> > > >> > subdependencies have Apache-compatible licenses
> > > >> > * Ran npm test and built a hello world android cordova project
> > > >> > with device plugin
> > > >> >
> > > >> >
> > ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >> >
> > > >> >
> > > >> >
> > ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >>
> > > >> -----------------------------------------------------------------
> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > >>
> > > >>
> > > >> -----------------------------------------------------------------
> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > >>
> > > >>
> > > >> -----------------------------------------------------------------
> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > >>
> > > >>
> > > >> -----------------------------------------------------------------
> > > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > >>
> > > >>
> > >
> > >
> > > --------------------------------------------------------------------
> > > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
RE: [Vote] Tools Release February 27, 2015
Posted by "Parashuram N (MS OPEN TECH)" <pa...@microsoft.com>.
> Since this isn't a blocker, I am going to move ahead with completing this vote thread and finishing off this plugins release.
You mean tools release, right ?
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Monday, March 2, 2015 2:30 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release February 27, 2015
So I push a commit to master that adds defaults.json to npmignore.
defaults.json is generated based on a plugin.xml every time the createpackagejson command is run. It won't cause any issues having it bundled but it is better to not have it in.
Since this isn't a blocker, I am going to move ahead with completing this vote thread and finishing off this plugins release.
On Mon, Mar 2, 2015 at 10:34 AM, Andrew Grieve <ag...@chromium.org> wrote:
> Awesome. So long as it's seems alright to you Steve, then I vote +1.
>
> On Mon, Mar 2, 2015 at 11:26 AM, Parashuram N (MS OPEN TECH) <
> panarasi@microsoft.com> wrote:
>
> > Voting +1
> >
> > * Verified signatures and hashes. Passed
> > * Verified tags manually. Passed
> > * Ability to install/uninstall Cordova. Passed
> > * Ability to update Cordova. Passed
> > * Ability to create blank app for Windows, WP8, Android. Passed
> > * Ability to run apps. Passed
> > * Reviewed release notes (Passed):
> >
> > plugman:
> > CB-8416 added plugman createpackagejson . command to
> > generate a package.json file from plugin.xml
> > CB-8370 Update documentation for plugman publish without
> > args
> >
> > cordova-lib
> > CB-8472 Can't find config.xml error installing browser
> > platform after plugin. (close #167)
> > CB-8239 Fix cordova platform add PATH when PATH is relative
> > and CWD != project root
> > CB-8227 CB8237 CB-8238 Add --save flag and autosave to
> > 'cordova platform add', 'cordova platform remove' and 'cordova platform update'
> > CB-8239 Fix "platform update" should ignore <cdv:engine>
> > (close
> > #159)
> > CB-8416: added plugman createpackagejson . command to create
> > a package.json from plugin.xml
> > CB-6973 add spec-plugman to npm run jshint
> > CB-6973 fix spec-plugman jshint failures
> > CB-8377 Fixed tag parsing (close #156)
> > CB-8370 Make "plugman publish" without args default to CWD
> > CB-8366 android: Remove empty `<framework>` directory upon
> > uninstall
> > CB-6973 Enable JSHint for spec-cordova
> > CB-8239 Add support for git urls to 'cordova platform add'
> > (close
> > #148)
> > CB-8358 Add `--link` for `platform add` and `platform update`
> > CB-6973 remove base rules from individual files in src.
> > CB-6973 have base rules in .jshintrc file.
> > CB-8168 --list support for cordova-lib (close #145.)
> > Chnage plugman test plugins to have IDs as directory names
> > Make all test plugin IDs unique
> > Empty out contents of plugin test files (and delete some
> > unused
> > ones)
> > CB-8285 Don't create .fetch.json files within plugin directories
> > CB-8286 Never persist value of create --link-to within
> > .cordova/config.json
> > CB-8153 generate cordova_plugins.json for browserify based
> projects
> > CB-8244 android: Have `plugin add --link` create symlinks
> > for `<source-file>`, `<framework>`, etc.
> > CB-8226 'cordova platform add' : Look up version in
> > config.xml if no version specified
> > Delete root .npmignore, since there's no node module there
> >
> > cordova-js
> > CB-8302 Added npm test script
> > CB-8300 Added CI configuration files
> >
> > cordova-cli
> > docs update for plugin --save
> > CB-8439 Fix 'cordova platform update' documentation to
> > include `<plat-spec>` (close #208)
> > CB-8379 Have --version print out cordova-lib version if it's
> > not the same as CLI's version
> > CB-8211, CB-8358 Update `--link` help text
> > CB-8168 --list support for CLI (close #205)
> > CB-8227 CB-8237 CB-8238 Add --save option to 'cordova
> > platform add', 'cordova platform remove' and 'cordova platform update'
> > CB-5316 Spell Cordova as a brand unless it's a command or script
> > CB-7739 document installing specific version of platforms
> >
> >
> >
> >
> > On 3/2/15, 8:02 AM, "Steven Gill" <st...@gmail.com> wrote:
> >
> > >I have defaults.json in gitignore so it doesn't get checked in. It
> > >is a mistake to have in there. Definitely would be better to write
> > >it to some temp directory outside of source. I'll see if it causes problems.
> > >Hopefully
> > >it doesn't block release and we can just fix on master. I'll report
> back.
> > >On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)"
> > ><v-...@microsoft.com>
> > >wrote:
> > >
> > >> I vote +1:
> > >> * Verified tools installation on windows
> > >> * Verified new blank app could be created on windows
> > >> * Verified android, ios, windows and wp8 platforms could be
> > >> added,
> built
> > >> and run.
> > >>
> > >> Thx!
> > >> Sergey
> > >> -----Original Message-----
> > >> From: Mefire O. [mailto:ommenjik@microsoft.com]
> > >> Sent: Saturday, February 28, 2015 8:24 AM
> > >> To: dev@cordova.apache.org
> > >> Subject: RE: [Vote] Tools Release February 27, 2015
> > >>
> > >> Thinking about it further, I do agree these are non-blocking.
> > >> Sorry for delaying the process.
> > >>
> > >> I vote +1.
> > >>
> > >> Thanks,
> > >> Mefire
> > >>
> > >> -----Original Message-----
> > >> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
> > >> Sent: Friday, February 27, 2015 9:11 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: RE: [Vote] Tools Release February 27, 2015
> > >>
> > >> Agree with Gorkem, I think these bugs are non-blocking. I don't
> > >> think
> we
> > >> should block the release for this - this only impacts certain
> > >>plugins, when using the --save feature. I think it may make sense
> > >>to do a patch release, if we don't want to block this release.
> > >>
> > >> -----Original Message-----
> > >> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
> > >> Sent: Friday, February 27, 2015 8:53 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: [Vote] Tools Release February 27, 2015
> > >>
> > >>
> > >>
> > >> On 27 Feb 2015, at 22:19, Mefire O. wrote:
> > >>
> > >> > I've spent some time testing, found two bugs and I vote -1
> > >> > until we address those :
> > >> > - https://issues.apache.org/jira/browse/CB-8577
> > >>
> > >> I do not think this is a show stopper, probably not even a bug, I
> > >>have not had time to change the old <feature> tags. Actually, it
> > >>will make the migration harder if we fix it now.
> > >>
> > >> > - https://issues.apache.org/jira/browse/CB-8578
> > >> No idea about this one. I am still trying to figure out why this
> feature
> > >> even exists.
> > >>
> > >> >
> > >> > I should be able to send pull requests to fix them shortly.
> > >> >
> > >> > Thanks,
> > >> > Mefire
> > >> >
> > >> > -----Original Message-----
> > >> > From: Mefire O. [mailto:ommenjik@microsoft.com]
> > >> > Sent: Friday, February 27, 2015 3:53 PM
> > >> > To: dev@cordova.apache.org
> > >> > Subject: RE: [Vote] Tools Release February 27, 2015
> > >> >
> > >> > Steven, Thanks for initiating this.
> > >> > I'll be performing some tests/checks and will then cast my vote
> > >> > accordingly.
> > >> >
> > >> > Thanks,
> > >> > Mefire
> > >> >
> > >> > -----Original Message-----
> > >> > From: Steven Gill [mailto:stevengill97@gmail.com]
> > >> > Sent: Friday, February 27, 2015 1:21 PM
> > >> > To: dev@cordova.apache.org
> > >> > Subject: [Vote] Tools Release February 27, 2015
> > >> >
> > >> > Please review and vote on this Tools Release.
> > >> >
> > >> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> > >> >
> > >> > All the tools have been published to
> > >> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555
> > >> > /
> > >> >
> > >> > All the tools have also been published to npm under the rc tag.
> > >> > Feel free to test them with npm install -g cordova@rc
> > >> >
> > >> > The packages were published from their corresponding git tags:
> > >> >
> > >> > cordova-js: 3.8.0 (5934b1b744)
> > >> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> > >> > cordova-plugman: 0.23.0 (6ec4d1d006)
> > >> > cordova-cli: 4.3.0 (f0fed4ad5c)
> > >> >
> > >> >
> > >> > Upon a successful vote I will upload the archives to dist/,
> > >> > publish them to NPM, and post the corresponding blog post.
> > >> >
> > >> > Voting guidelines:
> > >> >
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voti
> > ng
> > >> > .md
> > >> >
> > >> > Voting will go on for a minimum of 48 hours.
> > >> >
> > >> > I vote +1:
> > >> > * Ran coho audit-license-headers over the relevant repos
> > >> > * Ran coho check-license to ensure all dependencies and
> > >> > subdependencies have Apache-compatible licenses
> > >> > * Ran npm test and built a hello world android cordova project
> > >> > with device plugin
> > >> >
> > >> >
> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >> >
> > >> >
> > >> >
> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >> -----------------------------------------------------------------
> > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >> -----------------------------------------------------------------
> > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >> -----------------------------------------------------------------
> > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >> -----------------------------------------------------------------
> > >> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> >
> >
> > --------------------------------------------------------------------
> > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [Vote] Tools Release February 27, 2015
Posted by Steven Gill <st...@gmail.com>.
So I push a commit to master that adds defaults.json to npmignore.
defaults.json is generated based on a plugin.xml every time the
createpackagejson command is run. It won't cause any issues having it
bundled but it is better to not have it in.
Since this isn't a blocker, I am going to move ahead with completing this
vote thread and finishing off this plugins release.
On Mon, Mar 2, 2015 at 10:34 AM, Andrew Grieve <ag...@chromium.org> wrote:
> Awesome. So long as it's seems alright to you Steve, then I vote +1.
>
> On Mon, Mar 2, 2015 at 11:26 AM, Parashuram N (MS OPEN TECH) <
> panarasi@microsoft.com> wrote:
>
> > Voting +1
> >
> > * Verified signatures and hashes. Passed
> > * Verified tags manually. Passed
> > * Ability to install/uninstall Cordova. Passed
> > * Ability to update Cordova. Passed
> > * Ability to create blank app for Windows, WP8, Android. Passed
> > * Ability to run apps. Passed
> > * Reviewed release notes (Passed):
> >
> > plugman:
> > CB-8416 added plugman createpackagejson . command to generate a
> > package.json file from plugin.xml
> > CB-8370 Update documentation for plugman publish without args
> >
> > cordova-lib
> > CB-8472 Can't find config.xml error installing browser platform
> > after plugin. (close #167)
> > CB-8239 Fix cordova platform add PATH when PATH is relative and
> > CWD != project root
> > CB-8227 CB8237 CB-8238 Add --save flag and autosave to 'cordova
> > platform add', 'cordova platform remove' and 'cordova platform update'
> > CB-8239 Fix "platform update" should ignore <cdv:engine> (close
> > #159)
> > CB-8416: added plugman createpackagejson . command to create a
> > package.json from plugin.xml
> > CB-6973 add spec-plugman to npm run jshint
> > CB-6973 fix spec-plugman jshint failures
> > CB-8377 Fixed tag parsing (close #156)
> > CB-8370 Make "plugman publish" without args default to CWD
> > CB-8366 android: Remove empty `<framework>` directory upon
> > uninstall
> > CB-6973 Enable JSHint for spec-cordova
> > CB-8239 Add support for git urls to 'cordova platform add' (close
> > #148)
> > CB-8358 Add `--link` for `platform add` and `platform update`
> > CB-6973 remove base rules from individual files in src.
> > CB-6973 have base rules in .jshintrc file.
> > CB-8168 --list support for cordova-lib (close #145.)
> > Chnage plugman test plugins to have IDs as directory names
> > Make all test plugin IDs unique
> > Empty out contents of plugin test files (and delete some unused
> > ones)
> > CB-8285 Don't create .fetch.json files within plugin directories
> > CB-8286 Never persist value of create --link-to within
> > .cordova/config.json
> > CB-8153 generate cordova_plugins.json for browserify based
> projects
> > CB-8244 android: Have `plugin add --link` create symlinks for
> > `<source-file>`, `<framework>`, etc.
> > CB-8226 'cordova platform add' : Look up version in config.xml if
> > no version specified
> > Delete root .npmignore, since there's no node module there
> >
> > cordova-js
> > CB-8302 Added npm test script
> > CB-8300 Added CI configuration files
> >
> > cordova-cli
> > docs update for plugin --save
> > CB-8439 Fix 'cordova platform update' documentation to include
> > `<plat-spec>` (close #208)
> > CB-8379 Have --version print out cordova-lib version if it's not
> > the same as CLI's version
> > CB-8211, CB-8358 Update `--link` help text
> > CB-8168 --list support for CLI (close #205)
> > CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform
> > add', 'cordova platform remove' and 'cordova platform update'
> > CB-5316 Spell Cordova as a brand unless it's a command or script
> > CB-7739 document installing specific version of platforms
> >
> >
> >
> >
> > On 3/2/15, 8:02 AM, "Steven Gill" <st...@gmail.com> wrote:
> >
> > >I have defaults.json in gitignore so it doesn't get checked in. It is a
> > >mistake to have in there. Definitely would be better to write it to some
> > >temp directory outside of source. I'll see if it causes problems.
> > >Hopefully
> > >it doesn't block release and we can just fix on master. I'll report
> back.
> > >On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)"
> > ><v-...@microsoft.com>
> > >wrote:
> > >
> > >> I vote +1:
> > >> * Verified tools installation on windows
> > >> * Verified new blank app could be created on windows
> > >> * Verified android, ios, windows and wp8 platforms could be added,
> built
> > >> and run.
> > >>
> > >> Thx!
> > >> Sergey
> > >> -----Original Message-----
> > >> From: Mefire O. [mailto:ommenjik@microsoft.com]
> > >> Sent: Saturday, February 28, 2015 8:24 AM
> > >> To: dev@cordova.apache.org
> > >> Subject: RE: [Vote] Tools Release February 27, 2015
> > >>
> > >> Thinking about it further, I do agree these are non-blocking.
> > >> Sorry for delaying the process.
> > >>
> > >> I vote +1.
> > >>
> > >> Thanks,
> > >> Mefire
> > >>
> > >> -----Original Message-----
> > >> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
> > >> Sent: Friday, February 27, 2015 9:11 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: RE: [Vote] Tools Release February 27, 2015
> > >>
> > >> Agree with Gorkem, I think these bugs are non-blocking. I don't think
> we
> > >> should block the release for this - this only impacts certain plugins,
> > >>when
> > >> using the --save feature. I think it may make sense to do a patch
> > >>release,
> > >> if we don't want to block this release.
> > >>
> > >> -----Original Message-----
> > >> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
> > >> Sent: Friday, February 27, 2015 8:53 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: [Vote] Tools Release February 27, 2015
> > >>
> > >>
> > >>
> > >> On 27 Feb 2015, at 22:19, Mefire O. wrote:
> > >>
> > >> > I've spent some time testing, found two bugs and I vote -1 until we
> > >> > address those :
> > >> > - https://issues.apache.org/jira/browse/CB-8577
> > >>
> > >> I do not think this is a show stopper, probably not even a bug, I have
> > >>not
> > >> had time to change the old <feature> tags. Actually, it will make the
> > >> migration harder if we fix it now.
> > >>
> > >> > - https://issues.apache.org/jira/browse/CB-8578
> > >> No idea about this one. I am still trying to figure out why this
> feature
> > >> even exists.
> > >>
> > >> >
> > >> > I should be able to send pull requests to fix them shortly.
> > >> >
> > >> > Thanks,
> > >> > Mefire
> > >> >
> > >> > -----Original Message-----
> > >> > From: Mefire O. [mailto:ommenjik@microsoft.com]
> > >> > Sent: Friday, February 27, 2015 3:53 PM
> > >> > To: dev@cordova.apache.org
> > >> > Subject: RE: [Vote] Tools Release February 27, 2015
> > >> >
> > >> > Steven, Thanks for initiating this.
> > >> > I'll be performing some tests/checks and will then cast my vote
> > >> > accordingly.
> > >> >
> > >> > Thanks,
> > >> > Mefire
> > >> >
> > >> > -----Original Message-----
> > >> > From: Steven Gill [mailto:stevengill97@gmail.com]
> > >> > Sent: Friday, February 27, 2015 1:21 PM
> > >> > To: dev@cordova.apache.org
> > >> > Subject: [Vote] Tools Release February 27, 2015
> > >> >
> > >> > Please review and vote on this Tools Release.
> > >> >
> > >> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> > >> >
> > >> > All the tools have been published to
> > >> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
> > >> >
> > >> > All the tools have also been published to npm under the rc tag.
> > >> > Feel free to test them with npm install -g cordova@rc
> > >> >
> > >> > The packages were published from their corresponding git tags:
> > >> >
> > >> > cordova-js: 3.8.0 (5934b1b744)
> > >> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> > >> > cordova-plugman: 0.23.0 (6ec4d1d006)
> > >> > cordova-cli: 4.3.0 (f0fed4ad5c)
> > >> >
> > >> >
> > >> > Upon a successful vote I will upload the archives to dist/, publish
> > >> > them to NPM, and post the corresponding blog post.
> > >> >
> > >> > Voting guidelines:
> > >> >
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> > >> > .md
> > >> >
> > >> > Voting will go on for a minimum of 48 hours.
> > >> >
> > >> > I vote +1:
> > >> > * Ran coho audit-license-headers over the relevant repos
> > >> > * Ran coho check-license to ensure all dependencies and
> > >> > subdependencies have Apache-compatible licenses
> > >> > * Ran npm test and built a hello world android cordova project with
> > >> > device plugin
> > >> >
> > >> >
> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >> >
> > >> >
> > >> >
> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>
Re: [Vote] Tools Release February 27, 2015
Posted by Andrew Grieve <ag...@chromium.org>.
Awesome. So long as it's seems alright to you Steve, then I vote +1.
On Mon, Mar 2, 2015 at 11:26 AM, Parashuram N (MS OPEN TECH) <
panarasi@microsoft.com> wrote:
> Voting +1
>
> * Verified signatures and hashes. Passed
> * Verified tags manually. Passed
> * Ability to install/uninstall Cordova. Passed
> * Ability to update Cordova. Passed
> * Ability to create blank app for Windows, WP8, Android. Passed
> * Ability to run apps. Passed
> * Reviewed release notes (Passed):
>
> plugman:
> CB-8416 added plugman createpackagejson . command to generate a
> package.json file from plugin.xml
> CB-8370 Update documentation for plugman publish without args
>
> cordova-lib
> CB-8472 Can't find config.xml error installing browser platform
> after plugin. (close #167)
> CB-8239 Fix cordova platform add PATH when PATH is relative and
> CWD != project root
> CB-8227 CB8237 CB-8238 Add --save flag and autosave to 'cordova
> platform add', 'cordova platform remove' and 'cordova platform update'
> CB-8239 Fix "platform update" should ignore <cdv:engine> (close
> #159)
> CB-8416: added plugman createpackagejson . command to create a
> package.json from plugin.xml
> CB-6973 add spec-plugman to npm run jshint
> CB-6973 fix spec-plugman jshint failures
> CB-8377 Fixed tag parsing (close #156)
> CB-8370 Make "plugman publish" without args default to CWD
> CB-8366 android: Remove empty `<framework>` directory upon
> uninstall
> CB-6973 Enable JSHint for spec-cordova
> CB-8239 Add support for git urls to 'cordova platform add' (close
> #148)
> CB-8358 Add `--link` for `platform add` and `platform update`
> CB-6973 remove base rules from individual files in src.
> CB-6973 have base rules in .jshintrc file.
> CB-8168 --list support for cordova-lib (close #145.)
> Chnage plugman test plugins to have IDs as directory names
> Make all test plugin IDs unique
> Empty out contents of plugin test files (and delete some unused
> ones)
> CB-8285 Don't create .fetch.json files within plugin directories
> CB-8286 Never persist value of create --link-to within
> .cordova/config.json
> CB-8153 generate cordova_plugins.json for browserify based projects
> CB-8244 android: Have `plugin add --link` create symlinks for
> `<source-file>`, `<framework>`, etc.
> CB-8226 'cordova platform add' : Look up version in config.xml if
> no version specified
> Delete root .npmignore, since there's no node module there
>
> cordova-js
> CB-8302 Added npm test script
> CB-8300 Added CI configuration files
>
> cordova-cli
> docs update for plugin --save
> CB-8439 Fix 'cordova platform update' documentation to include
> `<plat-spec>` (close #208)
> CB-8379 Have --version print out cordova-lib version if it's not
> the same as CLI's version
> CB-8211, CB-8358 Update `--link` help text
> CB-8168 --list support for CLI (close #205)
> CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform
> add', 'cordova platform remove' and 'cordova platform update'
> CB-5316 Spell Cordova as a brand unless it's a command or script
> CB-7739 document installing specific version of platforms
>
>
>
>
> On 3/2/15, 8:02 AM, "Steven Gill" <st...@gmail.com> wrote:
>
> >I have defaults.json in gitignore so it doesn't get checked in. It is a
> >mistake to have in there. Definitely would be better to write it to some
> >temp directory outside of source. I'll see if it causes problems.
> >Hopefully
> >it doesn't block release and we can just fix on master. I'll report back.
> >On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)"
> ><v-...@microsoft.com>
> >wrote:
> >
> >> I vote +1:
> >> * Verified tools installation on windows
> >> * Verified new blank app could be created on windows
> >> * Verified android, ios, windows and wp8 platforms could be added, built
> >> and run.
> >>
> >> Thx!
> >> Sergey
> >> -----Original Message-----
> >> From: Mefire O. [mailto:ommenjik@microsoft.com]
> >> Sent: Saturday, February 28, 2015 8:24 AM
> >> To: dev@cordova.apache.org
> >> Subject: RE: [Vote] Tools Release February 27, 2015
> >>
> >> Thinking about it further, I do agree these are non-blocking.
> >> Sorry for delaying the process.
> >>
> >> I vote +1.
> >>
> >> Thanks,
> >> Mefire
> >>
> >> -----Original Message-----
> >> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
> >> Sent: Friday, February 27, 2015 9:11 PM
> >> To: dev@cordova.apache.org
> >> Subject: RE: [Vote] Tools Release February 27, 2015
> >>
> >> Agree with Gorkem, I think these bugs are non-blocking. I don't think we
> >> should block the release for this - this only impacts certain plugins,
> >>when
> >> using the --save feature. I think it may make sense to do a patch
> >>release,
> >> if we don't want to block this release.
> >>
> >> -----Original Message-----
> >> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
> >> Sent: Friday, February 27, 2015 8:53 PM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [Vote] Tools Release February 27, 2015
> >>
> >>
> >>
> >> On 27 Feb 2015, at 22:19, Mefire O. wrote:
> >>
> >> > I've spent some time testing, found two bugs and I vote -1 until we
> >> > address those :
> >> > - https://issues.apache.org/jira/browse/CB-8577
> >>
> >> I do not think this is a show stopper, probably not even a bug, I have
> >>not
> >> had time to change the old <feature> tags. Actually, it will make the
> >> migration harder if we fix it now.
> >>
> >> > - https://issues.apache.org/jira/browse/CB-8578
> >> No idea about this one. I am still trying to figure out why this feature
> >> even exists.
> >>
> >> >
> >> > I should be able to send pull requests to fix them shortly.
> >> >
> >> > Thanks,
> >> > Mefire
> >> >
> >> > -----Original Message-----
> >> > From: Mefire O. [mailto:ommenjik@microsoft.com]
> >> > Sent: Friday, February 27, 2015 3:53 PM
> >> > To: dev@cordova.apache.org
> >> > Subject: RE: [Vote] Tools Release February 27, 2015
> >> >
> >> > Steven, Thanks for initiating this.
> >> > I'll be performing some tests/checks and will then cast my vote
> >> > accordingly.
> >> >
> >> > Thanks,
> >> > Mefire
> >> >
> >> > -----Original Message-----
> >> > From: Steven Gill [mailto:stevengill97@gmail.com]
> >> > Sent: Friday, February 27, 2015 1:21 PM
> >> > To: dev@cordova.apache.org
> >> > Subject: [Vote] Tools Release February 27, 2015
> >> >
> >> > Please review and vote on this Tools Release.
> >> >
> >> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> >> >
> >> > All the tools have been published to
> >> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
> >> >
> >> > All the tools have also been published to npm under the rc tag.
> >> > Feel free to test them with npm install -g cordova@rc
> >> >
> >> > The packages were published from their corresponding git tags:
> >> >
> >> > cordova-js: 3.8.0 (5934b1b744)
> >> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> >> > cordova-plugman: 0.23.0 (6ec4d1d006)
> >> > cordova-cli: 4.3.0 (f0fed4ad5c)
> >> >
> >> >
> >> > Upon a successful vote I will upload the archives to dist/, publish
> >> > them to NPM, and post the corresponding blog post.
> >> >
> >> > Voting guidelines:
> >> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> >> > .md
> >> >
> >> > Voting will go on for a minimum of 48 hours.
> >> >
> >> > I vote +1:
> >> > * Ran coho audit-license-headers over the relevant repos
> >> > * Ran coho check-license to ensure all dependencies and
> >> > subdependencies have Apache-compatible licenses
> >> > * Ran npm test and built a hello world android cordova project with
> >> > device plugin
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> > For additional commands, e-mail: dev-help@cordova.apache.org
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> > For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [Vote] Tools Release February 27, 2015
Posted by "Parashuram N (MS OPEN TECH)" <pa...@microsoft.com>.
Voting +1
* Verified signatures and hashes. Passed
* Verified tags manually. Passed
* Ability to install/uninstall Cordova. Passed
* Ability to update Cordova. Passed
* Ability to create blank app for Windows, WP8, Android. Passed
* Ability to run apps. Passed
* Reviewed release notes (Passed):
plugman:
CB-8416 added plugman createpackagejson . command to generate a
package.json file from plugin.xml
CB-8370 Update documentation for plugman publish without args
cordova-lib
CB-8472 Can't find config.xml error installing browser platform
after plugin. (close #167)
CB-8239 Fix cordova platform add PATH when PATH is relative and
CWD != project root
CB-8227 CB8237 CB-8238 Add --save flag and autosave to 'cordova
platform add', 'cordova platform remove' and 'cordova platform update'
CB-8239 Fix "platform update" should ignore <cdv:engine> (close
#159)
CB-8416: added plugman createpackagejson . command to create a
package.json from plugin.xml
CB-6973 add spec-plugman to npm run jshint
CB-6973 fix spec-plugman jshint failures
CB-8377 Fixed tag parsing (close #156)
CB-8370 Make "plugman publish" without args default to CWD
CB-8366 android: Remove empty `<framework>` directory upon
uninstall
CB-6973 Enable JSHint for spec-cordova
CB-8239 Add support for git urls to 'cordova platform add' (close
#148)
CB-8358 Add `--link` for `platform add` and `platform update`
CB-6973 remove base rules from individual files in src.
CB-6973 have base rules in .jshintrc file.
CB-8168 --list support for cordova-lib (close #145.)
Chnage plugman test plugins to have IDs as directory names
Make all test plugin IDs unique
Empty out contents of plugin test files (and delete some unused
ones)
CB-8285 Don't create .fetch.json files within plugin directories
CB-8286 Never persist value of create --link-to within
.cordova/config.json
CB-8153 generate cordova_plugins.json for browserify based projects
CB-8244 android: Have `plugin add --link` create symlinks for
`<source-file>`, `<framework>`, etc.
CB-8226 'cordova platform add' : Look up version in config.xml if
no version specified
Delete root .npmignore, since there's no node module there
cordova-js
CB-8302 Added npm test script
CB-8300 Added CI configuration files
cordova-cli
docs update for plugin --save
CB-8439 Fix 'cordova platform update' documentation to include
`<plat-spec>` (close #208)
CB-8379 Have --version print out cordova-lib version if it's not
the same as CLI's version
CB-8211, CB-8358 Update `--link` help text
CB-8168 --list support for CLI (close #205)
CB-8227 CB-8237 CB-8238 Add --save option to 'cordova platform
add', 'cordova platform remove' and 'cordova platform update'
CB-5316 Spell Cordova as a brand unless it's a command or script
CB-7739 document installing specific version of platforms
On 3/2/15, 8:02 AM, "Steven Gill" <st...@gmail.com> wrote:
>I have defaults.json in gitignore so it doesn't get checked in. It is a
>mistake to have in there. Definitely would be better to write it to some
>temp directory outside of source. I'll see if it causes problems.
>Hopefully
>it doesn't block release and we can just fix on master. I'll report back.
>On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)"
><v-...@microsoft.com>
>wrote:
>
>> I vote +1:
>> * Verified tools installation on windows
>> * Verified new blank app could be created on windows
>> * Verified android, ios, windows and wp8 platforms could be added, built
>> and run.
>>
>> Thx!
>> Sergey
>> -----Original Message-----
>> From: Mefire O. [mailto:ommenjik@microsoft.com]
>> Sent: Saturday, February 28, 2015 8:24 AM
>> To: dev@cordova.apache.org
>> Subject: RE: [Vote] Tools Release February 27, 2015
>>
>> Thinking about it further, I do agree these are non-blocking.
>> Sorry for delaying the process.
>>
>> I vote +1.
>>
>> Thanks,
>> Mefire
>>
>> -----Original Message-----
>> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
>> Sent: Friday, February 27, 2015 9:11 PM
>> To: dev@cordova.apache.org
>> Subject: RE: [Vote] Tools Release February 27, 2015
>>
>> Agree with Gorkem, I think these bugs are non-blocking. I don't think we
>> should block the release for this - this only impacts certain plugins,
>>when
>> using the --save feature. I think it may make sense to do a patch
>>release,
>> if we don't want to block this release.
>>
>> -----Original Message-----
>> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
>> Sent: Friday, February 27, 2015 8:53 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [Vote] Tools Release February 27, 2015
>>
>>
>>
>> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>>
>> > I've spent some time testing, found two bugs and I vote -1 until we
>> > address those :
>> > - https://issues.apache.org/jira/browse/CB-8577
>>
>> I do not think this is a show stopper, probably not even a bug, I have
>>not
>> had time to change the old <feature> tags. Actually, it will make the
>> migration harder if we fix it now.
>>
>> > - https://issues.apache.org/jira/browse/CB-8578
>> No idea about this one. I am still trying to figure out why this feature
>> even exists.
>>
>> >
>> > I should be able to send pull requests to fix them shortly.
>> >
>> > Thanks,
>> > Mefire
>> >
>> > -----Original Message-----
>> > From: Mefire O. [mailto:ommenjik@microsoft.com]
>> > Sent: Friday, February 27, 2015 3:53 PM
>> > To: dev@cordova.apache.org
>> > Subject: RE: [Vote] Tools Release February 27, 2015
>> >
>> > Steven, Thanks for initiating this.
>> > I'll be performing some tests/checks and will then cast my vote
>> > accordingly.
>> >
>> > Thanks,
>> > Mefire
>> >
>> > -----Original Message-----
>> > From: Steven Gill [mailto:stevengill97@gmail.com]
>> > Sent: Friday, February 27, 2015 1:21 PM
>> > To: dev@cordova.apache.org
>> > Subject: [Vote] Tools Release February 27, 2015
>> >
>> > Please review and vote on this Tools Release.
>> >
>> > Release issue: https://issues.apache.org/jira/browse/CB-8555
>> >
>> > All the tools have been published to
>> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
>> >
>> > All the tools have also been published to npm under the rc tag.
>> > Feel free to test them with npm install -g cordova@rc
>> >
>> > The packages were published from their corresponding git tags:
>> >
>> > cordova-js: 3.8.0 (5934b1b744)
>> > cordova-lib: 4.3.0 (c4fbb6a3e1)
>> > cordova-plugman: 0.23.0 (6ec4d1d006)
>> > cordova-cli: 4.3.0 (f0fed4ad5c)
>> >
>> >
>> > Upon a successful vote I will upload the archives to dist/, publish
>> > them to NPM, and post the corresponding blog post.
>> >
>> > Voting guidelines:
>> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting
>> > .md
>> >
>> > Voting will go on for a minimum of 48 hours.
>> >
>> > I vote +1:
>> > * Ran coho audit-license-headers over the relevant repos
>> > * Ran coho check-license to ensure all dependencies and
>> > subdependencies have Apache-compatible licenses
>> > * Ran npm test and built a hello world android cordova project with
>> > device plugin
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > For additional commands, e-mail: dev-help@cordova.apache.org
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> > For additional commands, e-mail: dev-help@cordova.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [Vote] Tools Release February 27, 2015
Posted by Steven Gill <st...@gmail.com>.
I have defaults.json in gitignore so it doesn't get checked in. It is a
mistake to have in there. Definitely would be better to write it to some
temp directory outside of source. I'll see if it causes problems. Hopefully
it doesn't block release and we can just fix on master. I'll report back.
On Mar 2, 2015 7:51 AM, "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>
wrote:
> I vote +1:
> * Verified tools installation on windows
> * Verified new blank app could be created on windows
> * Verified android, ios, windows and wp8 platforms could be added, built
> and run.
>
> Thx!
> Sergey
> -----Original Message-----
> From: Mefire O. [mailto:ommenjik@microsoft.com]
> Sent: Saturday, February 28, 2015 8:24 AM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Thinking about it further, I do agree these are non-blocking.
> Sorry for delaying the process.
>
> I vote +1.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
> Sent: Friday, February 27, 2015 9:11 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Agree with Gorkem, I think these bugs are non-blocking. I don't think we
> should block the release for this - this only impacts certain plugins, when
> using the --save feature. I think it may make sense to do a patch release,
> if we don't want to block this release.
>
> -----Original Message-----
> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
> Sent: Friday, February 27, 2015 8:53 PM
> To: dev@cordova.apache.org
> Subject: Re: [Vote] Tools Release February 27, 2015
>
>
>
> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>
> > I've spent some time testing, found two bugs and I vote -1 until we
> > address those :
> > - https://issues.apache.org/jira/browse/CB-8577
>
> I do not think this is a show stopper, probably not even a bug, I have not
> had time to change the old <feature> tags. Actually, it will make the
> migration harder if we fix it now.
>
> > - https://issues.apache.org/jira/browse/CB-8578
> No idea about this one. I am still trying to figure out why this feature
> even exists.
>
> >
> > I should be able to send pull requests to fix them shortly.
> >
> > Thanks,
> > Mefire
> >
> > -----Original Message-----
> > From: Mefire O. [mailto:ommenjik@microsoft.com]
> > Sent: Friday, February 27, 2015 3:53 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [Vote] Tools Release February 27, 2015
> >
> > Steven, Thanks for initiating this.
> > I'll be performing some tests/checks and will then cast my vote
> > accordingly.
> >
> > Thanks,
> > Mefire
> >
> > -----Original Message-----
> > From: Steven Gill [mailto:stevengill97@gmail.com]
> > Sent: Friday, February 27, 2015 1:21 PM
> > To: dev@cordova.apache.org
> > Subject: [Vote] Tools Release February 27, 2015
> >
> > Please review and vote on this Tools Release.
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> >
> > All the tools have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
> >
> > All the tools have also been published to npm under the rc tag.
> > Feel free to test them with npm install -g cordova@rc
> >
> > The packages were published from their corresponding git tags:
> >
> > cordova-js: 3.8.0 (5934b1b744)
> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> > cordova-plugman: 0.23.0 (6ec4d1d006)
> > cordova-cli: 4.3.0 (f0fed4ad5c)
> >
> >
> > Upon a successful vote I will upload the archives to dist/, publish
> > them to NPM, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> > .md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran npm test and built a hello world android cordova project with
> > device plugin
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
RE: [Vote] Tools Release February 27, 2015
Posted by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com>.
I vote +1:
* Verified tools installation on windows
* Verified new blank app could be created on windows
* Verified android, ios, windows and wp8 platforms could be added, built and run.
Thx!
Sergey
-----Original Message-----
From: Mefire O. [mailto:ommenjik@microsoft.com]
Sent: Saturday, February 28, 2015 8:24 AM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release February 27, 2015
Thinking about it further, I do agree these are non-blocking.
Sorry for delaying the process.
I vote +1.
Thanks,
Mefire
-----Original Message-----
From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
Sent: Friday, February 27, 2015 9:11 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release February 27, 2015
Agree with Gorkem, I think these bugs are non-blocking. I don't think we should block the release for this - this only impacts certain plugins, when using the --save feature. I think it may make sense to do a patch release, if we don't want to block this release.
-----Original Message-----
From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
Sent: Friday, February 27, 2015 8:53 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release February 27, 2015
On 27 Feb 2015, at 22:19, Mefire O. wrote:
> I've spent some time testing, found two bugs and I vote -1 until we
> address those :
> - https://issues.apache.org/jira/browse/CB-8577
I do not think this is a show stopper, probably not even a bug, I have not had time to change the old <feature> tags. Actually, it will make the migration harder if we fix it now.
> - https://issues.apache.org/jira/browse/CB-8578
No idea about this one. I am still trying to figure out why this feature even exists.
>
> I should be able to send pull requests to fix them shortly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Mefire O. [mailto:ommenjik@microsoft.com]
> Sent: Friday, February 27, 2015 3:53 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Steven, Thanks for initiating this.
> I'll be performing some tests/checks and will then cast my vote
> accordingly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Friday, February 27, 2015 1:21 PM
> To: dev@cordova.apache.org
> Subject: [Vote] Tools Release February 27, 2015
>
> Please review and vote on this Tools Release.
>
> Release issue: https://issues.apache.org/jira/browse/CB-8555
>
> All the tools have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
>
> All the tools have also been published to npm under the rc tag.
> Feel free to test them with npm install -g cordova@rc
>
> The packages were published from their corresponding git tags:
>
> cordova-js: 3.8.0 (5934b1b744)
> cordova-lib: 4.3.0 (c4fbb6a3e1)
> cordova-plugman: 0.23.0 (6ec4d1d006)
> cordova-cli: 4.3.0 (f0fed4ad5c)
>
>
> Upon a successful vote I will upload the archives to dist/, publish
> them to NPM, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran npm test and built a hello world android cordova project with
> device plugin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [Vote] Tools Release February 27, 2015
Posted by Andrew Grieve <ag...@chromium.org>.
* Confirmed sigs & hashes with `coho verify-archive`
* Verified sha1s match tags with `coho verify-tags`
When checking actual contents, Looks like the released candidate has a file
that doesn't exist in the repo:
$ diff -r rc package
Only in rc/src/plugman: defaults.json
Contents of the file:
{"id":"org.apache.cordova.vibration","version":"0.3.14-dev","description":"Cordova
Vibration Plugin","license":"Apache
2.0","keywords":["cordova","vibration","ecosystem:cordova","cordova-firefoxos","cordova-wp7","cordova-wp8","cordova-android","cordova-amazon-fireos","cordova-ubuntu","cordova-ios","cordova-blackberry10","cordova-tizen"],"repository":"
https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration.git
","bugs":"https://issues.apache.org/jira/browse/CB/component/12320639
","engines":[],"platforms":["firefoxos","wp7","wp8","android","amazon-fireos","ubuntu","ios","blackberry10","tizen"]}
Looks like it's created by:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/createpackagejson.js#L43
(which is also returning a fulfilled promise?)
Seems it's something we should fix up (shouldn't write to source
directory), but probably it's not a real problem?
On Sat, Feb 28, 2015 at 12:24 AM, Mefire O. <om...@microsoft.com> wrote:
> Thinking about it further, I do agree these are non-blocking.
> Sorry for delaying the process.
>
> I vote +1.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
> Sent: Friday, February 27, 2015 9:11 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Agree with Gorkem, I think these bugs are non-blocking. I don't think we
> should block the release for this - this only impacts certain plugins, when
> using the --save feature. I think it may make sense to do a patch release,
> if we don't want to block this release.
>
> -----Original Message-----
> From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
> Sent: Friday, February 27, 2015 8:53 PM
> To: dev@cordova.apache.org
> Subject: Re: [Vote] Tools Release February 27, 2015
>
>
>
> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>
> > I've spent some time testing, found two bugs and I vote -1 until we
> > address those :
> > - https://issues.apache.org/jira/browse/CB-8577
>
> I do not think this is a show stopper, probably not even a bug, I have not
> had time to change the old <feature> tags. Actually, it will make the
> migration harder if we fix it now.
>
> > - https://issues.apache.org/jira/browse/CB-8578
> No idea about this one. I am still trying to figure out why this feature
> even exists.
>
> >
> > I should be able to send pull requests to fix them shortly.
> >
> > Thanks,
> > Mefire
> >
> > -----Original Message-----
> > From: Mefire O. [mailto:ommenjik@microsoft.com]
> > Sent: Friday, February 27, 2015 3:53 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [Vote] Tools Release February 27, 2015
> >
> > Steven, Thanks for initiating this.
> > I'll be performing some tests/checks and will then cast my vote
> > accordingly.
> >
> > Thanks,
> > Mefire
> >
> > -----Original Message-----
> > From: Steven Gill [mailto:stevengill97@gmail.com]
> > Sent: Friday, February 27, 2015 1:21 PM
> > To: dev@cordova.apache.org
> > Subject: [Vote] Tools Release February 27, 2015
> >
> > Please review and vote on this Tools Release.
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-8555
> >
> > All the tools have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
> >
> > All the tools have also been published to npm under the rc tag.
> > Feel free to test them with npm install -g cordova@rc
> >
> > The packages were published from their corresponding git tags:
> >
> > cordova-js: 3.8.0 (5934b1b744)
> > cordova-lib: 4.3.0 (c4fbb6a3e1)
> > cordova-plugman: 0.23.0 (6ec4d1d006)
> > cordova-cli: 4.3.0 (f0fed4ad5c)
> >
> >
> > Upon a successful vote I will upload the archives to dist/, publish
> > them to NPM, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> > .md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ran npm test and built a hello world android cordova project with
> > device plugin
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
RE: [Vote] Tools Release February 27, 2015
Posted by "Mefire O." <om...@microsoft.com>.
Thinking about it further, I do agree these are non-blocking.
Sorry for delaying the process.
I vote +1.
Thanks,
Mefire
-----Original Message-----
From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]
Sent: Friday, February 27, 2015 9:11 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release February 27, 2015
Agree with Gorkem, I think these bugs are non-blocking. I don't think we should block the release for this - this only impacts certain plugins, when using the --save feature. I think it may make sense to do a patch release, if we don't want to block this release.
-----Original Message-----
From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
Sent: Friday, February 27, 2015 8:53 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release February 27, 2015
On 27 Feb 2015, at 22:19, Mefire O. wrote:
> I've spent some time testing, found two bugs and I vote -1 until we
> address those :
> - https://issues.apache.org/jira/browse/CB-8577
I do not think this is a show stopper, probably not even a bug, I have not had time to change the old <feature> tags. Actually, it will make the migration harder if we fix it now.
> - https://issues.apache.org/jira/browse/CB-8578
No idea about this one. I am still trying to figure out why this feature even exists.
>
> I should be able to send pull requests to fix them shortly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Mefire O. [mailto:ommenjik@microsoft.com]
> Sent: Friday, February 27, 2015 3:53 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Steven, Thanks for initiating this.
> I'll be performing some tests/checks and will then cast my vote
> accordingly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Friday, February 27, 2015 1:21 PM
> To: dev@cordova.apache.org
> Subject: [Vote] Tools Release February 27, 2015
>
> Please review and vote on this Tools Release.
>
> Release issue: https://issues.apache.org/jira/browse/CB-8555
>
> All the tools have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
>
> All the tools have also been published to npm under the rc tag.
> Feel free to test them with npm install -g cordova@rc
>
> The packages were published from their corresponding git tags:
>
> cordova-js: 3.8.0 (5934b1b744)
> cordova-lib: 4.3.0 (c4fbb6a3e1)
> cordova-plugman: 0.23.0 (6ec4d1d006)
> cordova-cli: 4.3.0 (f0fed4ad5c)
>
>
> Upon a successful vote I will upload the archives to dist/, publish
> them to NPM, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran npm test and built a hello world android cordova project with
> device plugin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [Vote] Tools Release February 27, 2015
Posted by "Parashuram N (MS OPEN TECH)" <pa...@microsoft.com>.
Agree with Gorkem, I think these bugs are non-blocking. I don't think we should block the release for this - this only impacts certain plugins, when using the --save feature. I think it may make sense to do a patch release, if we don't want to block this release.
-----Original Message-----
From: Gorkem Ercan [mailto:gorkem.ercan@gmail.com]
Sent: Friday, February 27, 2015 8:53 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release February 27, 2015
On 27 Feb 2015, at 22:19, Mefire O. wrote:
> I've spent some time testing, found two bugs and I vote -1 until we
> address those :
> - https://issues.apache.org/jira/browse/CB-8577
I do not think this is a show stopper, probably not even a bug, I have not had time to change the old <feature> tags. Actually, it will make the migration harder if we fix it now.
> - https://issues.apache.org/jira/browse/CB-8578
No idea about this one. I am still trying to figure out why this feature even exists.
>
> I should be able to send pull requests to fix them shortly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Mefire O. [mailto:ommenjik@microsoft.com]
> Sent: Friday, February 27, 2015 3:53 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Steven, Thanks for initiating this.
> I'll be performing some tests/checks and will then cast my vote
> accordingly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Friday, February 27, 2015 1:21 PM
> To: dev@cordova.apache.org
> Subject: [Vote] Tools Release February 27, 2015
>
> Please review and vote on this Tools Release.
>
> Release issue: https://issues.apache.org/jira/browse/CB-8555
>
> All the tools have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
>
> All the tools have also been published to npm under the rc tag.
> Feel free to test them with npm install -g cordova@rc
>
> The packages were published from their corresponding git tags:
>
> cordova-js: 3.8.0 (5934b1b744)
> cordova-lib: 4.3.0 (c4fbb6a3e1)
> cordova-plugman: 0.23.0 (6ec4d1d006)
> cordova-cli: 4.3.0 (f0fed4ad5c)
>
>
> Upon a successful vote I will upload the archives to dist/, publish
> them to NPM, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting
> .md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran npm test and built a hello world android cordova project with
> device plugin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [Vote] Tools Release February 27, 2015
Posted by Steven Gill <st...@gmail.com>.
I really wish some of this stuff was communicated during the discuss phase
:(
On Feb 27, 2015 8:55 PM, "Gorkem Ercan" <go...@gmail.com> wrote:
>
>
> On 27 Feb 2015, at 22:19, Mefire O. wrote:
>
> I've spent some time testing, found two bugs and I vote -1 until we
>> address those :
>> - https://issues.apache.org/jira/browse/CB-8577
>>
>
> I do not think this is a show stopper, probably not even a bug, I have not
> had time to change the old <feature> tags. Actually, it will make the
> migration harder if we fix it now.
>
> - https://issues.apache.org/jira/browse/CB-8578
>>
> No idea about this one. I am still trying to figure out why this feature
> even exists.
>
>
>> I should be able to send pull requests to fix them shortly.
>>
>> Thanks,
>> Mefire
>>
>> -----Original Message-----
>> From: Mefire O. [mailto:ommenjik@microsoft.com]
>> Sent: Friday, February 27, 2015 3:53 PM
>> To: dev@cordova.apache.org
>> Subject: RE: [Vote] Tools Release February 27, 2015
>>
>> Steven, Thanks for initiating this.
>> I'll be performing some tests/checks and will then cast my vote
>> accordingly.
>>
>> Thanks,
>> Mefire
>>
>> -----Original Message-----
>> From: Steven Gill [mailto:stevengill97@gmail.com]
>> Sent: Friday, February 27, 2015 1:21 PM
>> To: dev@cordova.apache.org
>> Subject: [Vote] Tools Release February 27, 2015
>>
>> Please review and vote on this Tools Release.
>>
>> Release issue: https://issues.apache.org/jira/browse/CB-8555
>>
>> All the tools have been published to
>> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
>>
>> All the tools have also been published to npm under the rc tag.
>> Feel free to test them with npm install -g cordova@rc
>>
>> The packages were published from their corresponding git tags:
>>
>> cordova-js: 3.8.0 (5934b1b744)
>> cordova-lib: 4.3.0 (c4fbb6a3e1)
>> cordova-plugman: 0.23.0 (6ec4d1d006)
>> cordova-cli: 4.3.0 (f0fed4ad5c)
>>
>>
>> Upon a successful vote I will upload the archives to dist/, publish them
>> to NPM, and post the corresponding blog post.
>>
>> Voting guidelines:
>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>>
>> Voting will go on for a minimum of 48 hours.
>>
>> I vote +1:
>> * Ran coho audit-license-headers over the relevant repos
>> * Ran coho check-license to ensure all dependencies and subdependencies
>> have Apache-compatible licenses
>> * Ran npm test and built a hello world android cordova project with
>> device plugin
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [Vote] Tools Release February 27, 2015
Posted by Gorkem Ercan <go...@gmail.com>.
On 27 Feb 2015, at 22:19, Mefire O. wrote:
> I've spent some time testing, found two bugs and I vote -1 until we
> address those :
> - https://issues.apache.org/jira/browse/CB-8577
I do not think this is a show stopper, probably not even a bug, I have
not had time to change the old <feature> tags. Actually, it will make
the migration harder if we fix it now.
> - https://issues.apache.org/jira/browse/CB-8578
No idea about this one. I am still trying to figure out why this feature
even exists.
>
> I should be able to send pull requests to fix them shortly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Mefire O. [mailto:ommenjik@microsoft.com]
> Sent: Friday, February 27, 2015 3:53 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release February 27, 2015
>
> Steven, Thanks for initiating this.
> I'll be performing some tests/checks and will then cast my vote
> accordingly.
>
> Thanks,
> Mefire
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Friday, February 27, 2015 1:21 PM
> To: dev@cordova.apache.org
> Subject: [Vote] Tools Release February 27, 2015
>
> Please review and vote on this Tools Release.
>
> Release issue: https://issues.apache.org/jira/browse/CB-8555
>
> All the tools have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
>
> All the tools have also been published to npm under the rc tag.
> Feel free to test them with npm install -g cordova@rc
>
> The packages were published from their corresponding git tags:
>
> cordova-js: 3.8.0 (5934b1b744)
> cordova-lib: 4.3.0 (c4fbb6a3e1)
> cordova-plugman: 0.23.0 (6ec4d1d006)
> cordova-cli: 4.3.0 (f0fed4ad5c)
>
>
> Upon a successful vote I will upload the archives to dist/, publish
> them to NPM, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ran npm test and built a hello world android cordova project with
> device plugin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [Vote] Tools Release February 27, 2015
Posted by "Mefire O." <om...@microsoft.com>.
[Sorry to pollute the voting thread.]
Here are two pull requests that fix the issues I mentioned earlier :
- https://github.com/apache/cordova-lib/pull/173
- https://github.com/apache/cordova-lib/pull/174
I'll be voting +1, once and if these get included.
Thanks,
Mefire
-----Original Message-----
From: Mefire O. [mailto:ommenjik@microsoft.com]
Sent: Friday, February 27, 2015 7:20 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release February 27, 2015
I've spent some time testing, found two bugs and I vote -1 until we address those :
- https://issues.apache.org/jira/browse/CB-8577
- https://issues.apache.org/jira/browse/CB-8578
I should be able to send pull requests to fix them shortly.
Thanks,
Mefire
-----Original Message-----
From: Mefire O. [mailto:ommenjik@microsoft.com]
Sent: Friday, February 27, 2015 3:53 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release February 27, 2015
Steven, Thanks for initiating this.
I'll be performing some tests/checks and will then cast my vote accordingly.
Thanks,
Mefire
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Friday, February 27, 2015 1:21 PM
To: dev@cordova.apache.org
Subject: [Vote] Tools Release February 27, 2015
Please review and vote on this Tools Release.
Release issue: https://issues.apache.org/jira/browse/CB-8555
All the tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
All the tools have also been published to npm under the rc tag.
Feel free to test them with npm install -g cordova@rc
The packages were published from their corresponding git tags:
cordova-js: 3.8.0 (5934b1b744)
cordova-lib: 4.3.0 (c4fbb6a3e1)
cordova-plugman: 0.23.0 (6ec4d1d006)
cordova-cli: 4.3.0 (f0fed4ad5c)
Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Ran npm test and built a hello world android cordova project with device plugin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [Vote] Tools Release February 27, 2015
Posted by "Mefire O." <om...@microsoft.com>.
I've spent some time testing, found two bugs and I vote -1 until we address those :
- https://issues.apache.org/jira/browse/CB-8577
- https://issues.apache.org/jira/browse/CB-8578
I should be able to send pull requests to fix them shortly.
Thanks,
Mefire
-----Original Message-----
From: Mefire O. [mailto:ommenjik@microsoft.com]
Sent: Friday, February 27, 2015 3:53 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release February 27, 2015
Steven, Thanks for initiating this.
I'll be performing some tests/checks and will then cast my vote accordingly.
Thanks,
Mefire
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Friday, February 27, 2015 1:21 PM
To: dev@cordova.apache.org
Subject: [Vote] Tools Release February 27, 2015
Please review and vote on this Tools Release.
Release issue: https://issues.apache.org/jira/browse/CB-8555
All the tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
All the tools have also been published to npm under the rc tag.
Feel free to test them with npm install -g cordova@rc
The packages were published from their corresponding git tags:
cordova-js: 3.8.0 (5934b1b744)
cordova-lib: 4.3.0 (c4fbb6a3e1)
cordova-plugman: 0.23.0 (6ec4d1d006)
cordova-cli: 4.3.0 (f0fed4ad5c)
Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Ran npm test and built a hello world android cordova project with device plugin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [Vote] Tools Release February 27, 2015
Posted by "Mefire O." <om...@microsoft.com>.
Steven, Thanks for initiating this.
I'll be performing some tests/checks and will then cast my vote accordingly.
Thanks,
Mefire
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Friday, February 27, 2015 1:21 PM
To: dev@cordova.apache.org
Subject: [Vote] Tools Release February 27, 2015
Please review and vote on this Tools Release.
Release issue: https://issues.apache.org/jira/browse/CB-8555
All the tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8555/
All the tools have also been published to npm under the rc tag.
Feel free to test them with npm install -g cordova@rc
The packages were published from their corresponding git tags:
cordova-js: 3.8.0 (5934b1b744)
cordova-lib: 4.3.0 (c4fbb6a3e1)
cordova-plugman: 0.23.0 (6ec4d1d006)
cordova-cli: 4.3.0 (f0fed4ad5c)
Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Ran npm test and built a hello world android cordova project with device plugin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org