You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by rf...@apache.org on 2007/08/14 20:58:48 UTC
svn commit: r565858 - in /lenya/trunk/src:
modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/
modules/linkcheck/java/src/org/apache/lenya/cms/cocoon/generation/
modules/lucene/java/src/org/apache/cocoon/components/search/
Author: rfrovarp
Date: Tue Aug 14 11:58:48 2007
New Revision: 565858
URL: http://svn.apache.org/viewvc?view=rev&rev=565858
Log:
Removed new String() so that strings can be interned, removed toString() on strings, converted new Boolean to Boolean.valueOf() to use interned value.
Modified:
lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Create.java
lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Revisions.java
lenya/trunk/src/modules/linkcheck/java/src/org/apache/lenya/cms/cocoon/generation/LinkStatusGenerator.java
lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/IndexStructure.java
Modified: lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Create.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Create.java?view=diff&rev=565858&r1=565857&r2=565858
==============================================================================
--- lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Create.java (original)
+++ lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Create.java Tue Aug 14 11:58:48 2007
@@ -208,7 +208,7 @@
Object param = getParameter(DUBLIN_CORE_PREFIX + name);
if (param != null && getParameter(DUBLIN_CORE_PREFIX + name).getClass().isArray()) {
String[] values = (String[]) getParameter(DUBLIN_CORE_PREFIX + name);
- String paramValue = new String("");
+ String paramValue = "";
for (int i = 0; i < values.length; i++) {
String value = values[i];
if (i > 0)
Modified: lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Revisions.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Revisions.java?view=diff&rev=565858&r1=565857&r2=565858
==============================================================================
--- lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Revisions.java (original)
+++ lenya/trunk/src/modules-core/sitemanagement/java/src/org/apache/lenya/cms/site/usecases/Revisions.java Tue Aug 14 11:58:48 2007
@@ -50,7 +50,7 @@
}
setParameter("revisions", revisions);
- Boolean canRollback = new Boolean(WorkflowUtil.canInvoke(this.manager,
+ Boolean canRollback = Boolean.valueOf(WorkflowUtil.canInvoke(this.manager,
getDocumentFactory().getSession(), getLogger(), sourceDoc, getEvent()));
setParameter("canRollback", canRollback);
Modified: lenya/trunk/src/modules/linkcheck/java/src/org/apache/lenya/cms/cocoon/generation/LinkStatusGenerator.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules/linkcheck/java/src/org/apache/lenya/cms/cocoon/generation/LinkStatusGenerator.java?view=diff&rev=565858&r1=565857&r2=565858
==============================================================================
--- lenya/trunk/src/modules/linkcheck/java/src/org/apache/lenya/cms/cocoon/generation/LinkStatusGenerator.java (original)
+++ lenya/trunk/src/modules/linkcheck/java/src/org/apache/lenya/cms/cocoon/generation/LinkStatusGenerator.java Tue Aug 14 11:58:48 2007
@@ -455,10 +455,10 @@
// content is supposed to be a list of links,
// relative to current URL
String line;
- String referrer = url_of_referrer.toString();
+ String referrer = url_of_referrer;
while ((line = br.readLine()) != null) {
- String new_url = new String(line);
+ String new_url = line;
boolean add_url = true;
// don't add new_url twice
if (add_url) {
@@ -467,7 +467,7 @@
// don't add new_url if it has been crawled already
if (add_url) {
- add_url &= !crawled.contains(new_url.toString());
+ add_url &= !crawled.contains(new_url);
}
Link new_link = new Link(line, referrer, referrerDepth+1);
@@ -477,17 +477,17 @@
// don't add if is not matched by existing include definition
if (add_url) {
- add_url &= isIncludedURL(new_url.toString());
+ add_url &= isIncludedURL(new_url);
}
//don't add id matched by existing exclude definition
if (add_url) {
- add_url &= !(isExcludedURL(new_url.toString()));
+ add_url &= !(isExcludedURL(new_url));
}
if (add_url) {
if (getLogger().isDebugEnabled()) {
- getLogger().debug("Add URL: " + new_url.toString());
+ getLogger().debug("Add URL: " + new_url);
}
url_links.add(new_link);
}
@@ -558,7 +558,7 @@
responseMessage = h.getResponseMessage();
responseCode = h.getResponseCode();
} else {
- String tempURI = new String(uri);
+ String tempURI = uri;
if (!(uri.startsWith("/"))) {
String contextURI = referrer.substring(0,referrer.lastIndexOf("/")+1);
tempURI = contextURI + uri;
Modified: lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/IndexStructure.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/IndexStructure.java?view=diff&rev=565858&r1=565857&r2=565858
==============================================================================
--- lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/IndexStructure.java (original)
+++ lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/IndexStructure.java Tue Aug 14 11:58:48 2007
@@ -101,7 +101,7 @@
}
public String toString() {
- String result = new String("DocumentFactory:");
+ String result = "DocumentFactory:";
Iterator iter = this.fielddefs.values().iterator();
while (iter.hasNext()) {
FieldDefinition item = (FieldDefinition) iter.next();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org