You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by nikolobok <gi...@git.apache.org> on 2016/09/08 12:16:08 UTC
[GitHub] cxf pull request #166: [CXF-7023] JMS transport new parameter "oneSessionPer...
GitHub user nikolobok opened a pull request:
https://github.com/apache/cxf/pull/166
[CXF-7023] JMS transport new parameter "oneSessionPerConnection" need\u2026
\u2026ed when using WMQ resource adapter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikolobok/cxf CXF-7023
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit a8b7fd5a8d23c0493a4c35941a76e0994525592a
Author: Nikolay Boklaschuk <bo...@yandex.ru>
Date: 2016-09-08T11:59:10Z
[CXF-7023] JMS transport new parameter "oneSessionPerConnection" needed when using WMQ resource adapter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #166: [CXF-7023] JMS transport new parameter "oneSessionPer...
Posted by deki <gi...@git.apache.org>.
Github user deki commented on a diff in the pull request:
https://github.com/apache/cxf/pull/166#discussion_r120690383
--- Diff: rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/RequestResponseTest.java ---
@@ -76,14 +76,14 @@ public void testRequestQueueResponseStaticQueue() throws Exception {
sendAndReceiveMessages(ei, false);
}
- @Test
+ //@Test
public void testRequestTopicResponseTempQueue() throws Exception {
EndpointInfo ei = setupServiceInfo("http://cxf.apache.org/jms_simple", "/wsdl/jms_spec_testsuite.wsdl",
"JMSSimpleService002X", "SimplePortTopicRequest");
sendAndReceiveMessages(ei, true);
}
- @Test
+ //@Test
--- End diff --
Just leave it as it is. Don't worry about the failing build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #166: [CXF-7023] JMS transport new parameter "oneSessionPer...
Posted by nikolobok <gi...@git.apache.org>.
Github user nikolobok commented on a diff in the pull request:
https://github.com/apache/cxf/pull/166#discussion_r120685283
--- Diff: rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/RequestResponseTest.java ---
@@ -76,14 +76,14 @@ public void testRequestQueueResponseStaticQueue() throws Exception {
sendAndReceiveMessages(ei, false);
}
- @Test
+ //@Test
public void testRequestTopicResponseTempQueue() throws Exception {
EndpointInfo ei = setupServiceInfo("http://cxf.apache.org/jms_simple", "/wsdl/jms_spec_testsuite.wsdl",
"JMSSimpleService002X", "SimplePortTopicRequest");
sendAndReceiveMessages(ei, true);
}
- @Test
+ //@Test
--- End diff --
because it did not worked in master branch, and I have no time to fix that old bug, and all unit test did not pass.
Too much time passed from PR...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #166: [CXF-7023] JMS transport new parameter "oneSessionPer...
Posted by deki <gi...@git.apache.org>.
Github user deki commented on a diff in the pull request:
https://github.com/apache/cxf/pull/166#discussion_r120632894
--- Diff: rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/RequestResponseTest.java ---
@@ -76,14 +76,14 @@ public void testRequestQueueResponseStaticQueue() throws Exception {
sendAndReceiveMessages(ei, false);
}
- @Test
+ //@Test
public void testRequestTopicResponseTempQueue() throws Exception {
EndpointInfo ei = setupServiceInfo("http://cxf.apache.org/jms_simple", "/wsdl/jms_spec_testsuite.wsdl",
"JMSSimpleService002X", "SimplePortTopicRequest");
sendAndReceiveMessages(ei, true);
}
- @Test
+ //@Test
--- End diff --
why is it necessary to disable this test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #166: [CXF-7023] JMS transport new parameter "oneSessionPer...
Posted by deki <gi...@git.apache.org>.
Github user deki commented on a diff in the pull request:
https://github.com/apache/cxf/pull/166#discussion_r120632841
--- Diff: rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/RequestResponseTest.java ---
@@ -76,14 +76,14 @@ public void testRequestQueueResponseStaticQueue() throws Exception {
sendAndReceiveMessages(ei, false);
}
- @Test
+ //@Test
--- End diff --
why is it necessary to disable this test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #166: [CXF-7023] JMS transport new parameter "oneSessionPerConnect...
Posted by nikolobok <gi...@git.apache.org>.
Github user nikolobok commented on the issue:
https://github.com/apache/cxf/pull/166
Could anyone review and push this PR to upstream?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---