You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/17 12:03:19 UTC
Review Request 38456: CMake: Fix MESOS-3395, MESOS-3394,
add canonical third-party lib source.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38456/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
In the current CMake build system, if we choose to download the
third-party dependencies (instead of un-tar'ing the rebundled versions
of those dependencies) we will download them from the GitHub Mesos
mirror.
It would be better to have a canonical source of third-party
dependencies, independent of the Mesos changes.
This commit points at a new canonical source of third-party tarballs.
Diffs
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64
Diff: https://reviews.apache.org/r/38456/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 38456: CMake: Fix MESOS-3395, MESOS-3394,
add canonical third-party lib source.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38456/#review99627
-----------------------------------------------------------
Ship it!
The expectation here is that this allows more contributors to start working on windows support, and that eventually this will be refactored more.
- Joris Van Remoortere
On Sept. 17, 2015, 10:03 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38456/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 10:03 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the current CMake build system, if we choose to download the
> third-party dependencies (instead of un-tar'ing the rebundled versions
> of those dependencies) we will download them from the GitHub Mesos
> mirror.
>
> It would be better to have a canonical source of third-party
> dependencies, independent of the Mesos changes.
>
> This commit points at a new canonical source of third-party tarballs.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64
>
> Diff: https://reviews.apache.org/r/38456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38456: CMake: Fix MESOS-3395, MESOS-3394,
add canonical third-party lib source.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38456/#review99399
-----------------------------------------------------------
Ship it!
Changes looks good.
General question: How do you envision what updates to dependencies will look like?
The sources (like glog, protobufs, picojson, etc) are currently part of the mesos code base. This won't exactly work with the `mesos-3rdparty` source.
i.e. If you have have a library source like `dep-1.0.tar.gz` and want to upgrade to `dep-1.1.tar.gz`, it seems like the 3rdparty repo would need to have both? (And wouldn't that possibly get unruly?)
- Joseph Wu
On Sept. 17, 2015, 3:03 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38456/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 3:03 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In the current CMake build system, if we choose to download the
> third-party dependencies (instead of un-tar'ing the rebundled versions
> of those dependencies) we will download them from the GitHub Mesos
> mirror.
>
> It would be better to have a canonical source of third-party
> dependencies, independent of the Mesos changes.
>
> This commit points at a new canonical source of third-party tarballs.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64
>
> Diff: https://reviews.apache.org/r/38456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>