[GitHub] [hadoop] simbadzina commented on a diff in pull request #5691: HDFS-17026. RBF: Configuring NamenodeHeartbeatService to update JMX on low…

["simbadzina (via GitHub)" <gi...@apache.org>]

simbadzina commented on code in PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#discussion_r1208016845


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -447,8 +462,13 @@ private void updateJMXParameters(
       String address, NamenodeStatusReport report) {
     try {
       // TODO part of this should be moved to its own utility
-      getFsNamesystemMetrics(address, report);
-      getNamenodeInfoMetrics(address, report);
+      if (shouldUpdateJmx()) {
+        lastJmxUpdateAttempt = Time.monotonicNow();
+        getFsNamesystemMetrics(address);
+        getNamenodeInfoMetrics(address);
+      }
+      populateFsNamesystemMetrics(fsNamesystemMetrics, report);
+      populateNamenodeInfoMetrics(namenodeInfoMetrics, report);

Review Comment:
   What happens if we do not populate the metrics in the report? I'm wondering whether the `shouldUpdateJmx()` condition can be outside of and wrapping about the whole `updateJmxParameters` function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org