You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "hamed-hatami (via GitHub)" <gi...@apache.org> on 2023/07/16 11:39:08 UTC
[GitHub] [camel] hamed-hatami opened a new pull request, #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
hamed-hatami opened a new pull request, #10697:
URL: https://github.com/apache/camel/pull/10697
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1264965869
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Configuration.java:
##########
@@ -67,6 +67,8 @@ public class Kinesis2Configuration implements Cloneable {
private Integer proxyPort;
@UriParam(defaultValue = "false", description = "If we want to trust all certificates in case of overriding the endpoint")
private boolean trustAllCertificates;
+ @UriParam(defaultValue = "false", description = "If we want to a KinesisAsyncClient instance set it to true")
Review Comment:
This is producer only, so it needs to be labelled
##########
components/camel-aws/camel-aws2-kinesis/pom.xml:
##########
@@ -33,6 +33,7 @@
<description>A Camel Amazon Kinesis Web Service Component Version 2</description>
<properties>
+ <amazon-kinesis-common-version>2.5.1</amazon-kinesis-common-version>
Review Comment:
This should go in Parent POM
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/client/KinesisClientFactory.java:
##########
@@ -44,4 +45,14 @@ public static KinesisInternalClient getKinesisClient(Kinesis2Configuration confi
return new KinesisClientStandardImpl(configuration);
}
}
+
+ /**
+ * Return the standard aws Kinesis Async client.
+ *
+ * @param configuration configuration
+ * @return KinesisAsyncClient
+ */
+ public static KinesisAsyncInternalClient getKinesisAsyncClient(Kinesis2Configuration configuration) {
Review Comment:
The default and profile credentials are missing. It should be the same as the Sync client, so you should provide the other two implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hamed-hatami commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "hamed-hatami (via GitHub)" <gi...@apache.org>.
hamed-hatami commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1267703542
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Configuration.java:
##########
@@ -67,6 +67,8 @@ public class Kinesis2Configuration implements Cloneable {
private Integer proxyPort;
@UriParam(defaultValue = "false", description = "If we want to trust all certificates in case of overriding the endpoint")
private boolean trustAllCertificates;
+ @UriParam(defaultValue = "false", description = "If we want to a KinesisAsyncClient instance set it to true")
Review Comment:
Let me declare a label for common then for the time being
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #10697:
URL: https://github.com/apache/camel/pull/10697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hamed-hatami commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "hamed-hatami (via GitHub)" <gi...@apache.org>.
hamed-hatami commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1267727687
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/client/KinesisClientFactory.java:
##########
@@ -44,4 +45,14 @@ public static KinesisInternalClient getKinesisClient(Kinesis2Configuration confi
return new KinesisClientStandardImpl(configuration);
}
}
+
+ /**
+ * Return the standard aws Kinesis Async client.
+ *
+ * @param configuration configuration
+ * @return KinesisAsyncClient
+ */
+ public static KinesisAsyncInternalClient getKinesisAsyncClient(Kinesis2Configuration configuration) {
Review Comment:
It's done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hamed-hatami commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "hamed-hatami (via GitHub)" <gi...@apache.org>.
hamed-hatami commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1267703542
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Configuration.java:
##########
@@ -67,6 +67,8 @@ public class Kinesis2Configuration implements Cloneable {
private Integer proxyPort;
@UriParam(defaultValue = "false", description = "If we want to trust all certificates in case of overriding the endpoint")
private boolean trustAllCertificates;
+ @UriParam(defaultValue = "false", description = "If we want to a KinesisAsyncClient instance set it to true")
Review Comment:
Let me declare a label for consumer then for the time being
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hamed-hatami commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "hamed-hatami (via GitHub)" <gi...@apache.org>.
hamed-hatami commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1267729492
##########
components/camel-aws/camel-aws2-kinesis/pom.xml:
##########
@@ -33,6 +33,7 @@
<description>A Camel Amazon Kinesis Web Service Component Version 2</description>
<properties>
+ <amazon-kinesis-common-version>2.5.1</amazon-kinesis-common-version>
Review Comment:
It's also done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10697:
URL: https://github.com/apache/camel/pull/10697#issuecomment-1637060929
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hamed-hatami commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component
Posted by "hamed-hatami (via GitHub)" <gi...@apache.org>.
hamed-hatami commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1267701964
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Configuration.java:
##########
@@ -67,6 +67,8 @@ public class Kinesis2Configuration implements Cloneable {
private Integer proxyPort;
@UriParam(defaultValue = "false", description = "If we want to trust all certificates in case of overriding the endpoint")
private boolean trustAllCertificates;
+ @UriParam(defaultValue = "false", description = "If we want to a KinesisAsyncClient instance set it to true")
Review Comment:
My aim was to make it bi-directional, both consumer and producer will take effect by async connection ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org