You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/30 16:59:01 UTC

Review Request 27383: Alerts UI: Create mapper for alert-definitions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27383/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-8040
    https://issues.apache.org/jira/browse/AMBARI-8040


Repository: ambari


Description
-------

Alert UI needs to map Alert-Definition data to Alert-Definitions model (the model is defined in AMBARI-7984)


Diffs
-----

  ambari-web/app/config.js f7171bf 
  ambari-web/app/controllers/global/cluster_controller.js 826c944 
  ambari-web/app/controllers/global/update_controller.js 750db76 
  ambari-web/app/mappers.js 9300d1a 
  ambari-web/app/models/alertDefinition.js 0b75e9e 
  ambari-web/app/utils/ajax/ajax.js ca03738 
  ambari-web/test/controllers/global/update_controller_test.js 45622bd 

Diff: https://reviews.apache.org/r/27383/diff/


Testing
-------

4885 tests complete (7 seconds)
60 tests pending

1 test modified


Thanks,

Aleksandr Kovalenko

Re: Review Request 27383: Alerts UI: Create mapper for alert-definitions

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27383/#review59209
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 30, 2014, 3:59 p.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27383/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 3:59 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-8040
>     https://issues.apache.org/jira/browse/AMBARI-8040
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Alert UI needs to map Alert-Definition data to Alert-Definitions model (the model is defined in AMBARI-7984)
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/config.js f7171bf 
>   ambari-web/app/controllers/global/cluster_controller.js 826c944 
>   ambari-web/app/controllers/global/update_controller.js 750db76 
>   ambari-web/app/mappers.js 9300d1a 
>   ambari-web/app/models/alertDefinition.js 0b75e9e 
>   ambari-web/app/utils/ajax/ajax.js ca03738 
>   ambari-web/test/controllers/global/update_controller_test.js 45622bd 
> 
> Diff: https://reviews.apache.org/r/27383/diff/
> 
> 
> Testing
> -------
> 
> 4885 tests complete (7 seconds)
> 60 tests pending
> 
> 1 test modified
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>