You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zjffdu <gi...@git.apache.org> on 2016/06/07 12:18:50 UTC
[GitHub] spark pull request #13541: [SPARK-15803][PYSPARK] Support with statement syn...
GitHub user zjffdu opened a pull request:
https://github.com/apache/spark/pull/13541
[SPARK-15803][PYSPARK] Support with statement syntax for SparkSession
## What changes were proposed in this pull request?
Support with statement syntax for SparkSession in pyspark
## How was this patch tested?
Manually verify it. Although I can add unit test for it, it would affect other unit test because the SparkContext is stopped after the with statement.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/spark SPARK-15803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13541
----
commit 42749d30c21ec42e2237add429748c731f48ff00
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-06-07T12:15:50Z
[SPARK-15803][PYSPARK] Support with statement syntax for SparkSession
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13541: [SPARK-15803][PYSPARK] Support with statement syn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60125/consoleFull)** for PR 13541 at commit [`42749d3`](https://github.com/apache/spark/commit/42749d30c21ec42e2237add429748c731f48ff00).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60125/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the issue:
https://github.com/apache/spark/pull/13541
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the issue:
https://github.com/apache/spark/pull/13541
Merging this into master and 2.0, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/spark/pull/13541
It's weird that I can pass the python test in local, but fails on github jenkins. And the error message not clear to me. @davies Could you help take a look at it ? Thanks. Here's the output from jenkins.
```
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /home/jenkins/workspace/SparkPullRequestBuilder@2/python/unit-tests.log
Will test against the following Python executables: ['python2.6', 'python3.4', 'pypy']
Will test the following Python modules: ['pyspark-sql', 'pyspark-mllib', 'pyspark-ml']
/home/jenkins/workspace/SparkPullRequestBuilder@2/python/pyspark/sql/context.py:457: DeprecationWarning: HiveContext is deprecated in Spark 2.0.0. Please use SparkSession.builder.enableHiveSupport().getOrCreate() instead.
DeprecationWarning)
Running tests...
----------------------------------------------------------------------
...Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel).
Traceback (most recent call last):
File "/usr/lib64/python2.6/runpy.py", line 122, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/usr/lib64/python2.6/runpy.py", line 34, in _run_code
exec code in run_globals
File "/home/jenkins/workspace/SparkPullRequestBuilder@2/python/pyspark/sql/tests.py", line 1725, in <module>
unittest.main(testRunner=xmlrunner.XMLTestRunner(output='target/test-reports'))
File "/usr/lib/python2.6/site-packages/unittest2/main.py", line 88, in __init__
self.runTests()
File "/usr/lib/python2.6/site-packages/unittest2/main.py", line 237, in runTests
self.result = testRunner.run(self.test)
File "/usr/lib/python2.6/site-packages/xmlrunner/runner.py", line 59, in run
test(result)
File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 87, in __call__
return self.run(*args, **kwds)
File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 126, in run
test(result)
File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 87, in __call__
return self.run(*args, **kwds)
File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 118, in run
self._handleClassSetUp(test, result)
File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 173, in _handleClassSetUp
self._addClassOrModuleLevelException(result, e, errorName)
File "/usr/lib/python2.6/site-packages/unittest2/suite.py", line 215, in _addClassOrModuleLevelException
result.addError(error, sys.exc_info())
File "/usr/lib/python2.6/site-packages/xmlrunner/result.py", line 232, in addError
self._save_output_data()
File "/usr/lib/python2.6/site-packages/xmlrunner/result.py", line 189, in _save_output_data
self._stdout_data = sys.stdout.getvalue()
AttributeError: 'file' object has no attribute 'getvalue'
Had test failures in pyspark.sql.tests with python2.6; see logs.
[error] running /home/jenkins/workspace/SparkPullRequestBuilder@2/python/run-tests --modules=pyspark-sql,pyspark-mllib,pyspark-ml --parallelism=4 ; received return code 255
Attempting to post to Github...
> Post successful.
Build step 'Execute shell' marked build as failure
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60270/consoleFull)** for PR 13541 at commit [`7cce183`](https://github.com/apache/spark/commit/7cce183de2a43bbd338d81919c75d9bbba8a751f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60126/consoleFull)** for PR 13541 at commit [`b35f122`](https://github.com/apache/spark/commit/b35f12273eb8eb2b29ec4b1e1f1393fb59bb2897).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60270/consoleFull)** for PR 13541 at commit [`7cce183`](https://github.com/apache/spark/commit/7cce183de2a43bbd338d81919c75d9bbba8a751f).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60125/consoleFull)** for PR 13541 at commit [`42749d3`](https://github.com/apache/spark/commit/42749d30c21ec42e2237add429748c731f48ff00).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60270/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60706/consoleFull)** for PR 13541 at commit [`7cce183`](https://github.com/apache/spark/commit/7cce183de2a43bbd338d81919c75d9bbba8a751f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60706/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60706/consoleFull)** for PR 13541 at commit [`7cce183`](https://github.com/apache/spark/commit/7cce183de2a43bbd338d81919c75d9bbba8a751f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/13541
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13541
**[Test build #60126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60126/consoleFull)** for PR 13541 at commit [`b35f122`](https://github.com/apache/spark/commit/b35f12273eb8eb2b29ec4b1e1f1393fb59bb2897).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13541: [SPARK-15803][PYSPARK] Support with statement syntax for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13541
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60126/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org