[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3934: Cleanup row count handling in JSON writer

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3934:
URL: https://github.com/apache/arrow-rs/pull/3934#discussion_r1147792872


##########
arrow-json/src/writer.rs:
##########
@@ -424,9 +401,10 @@ pub fn record_batches_to_json_rows(
         let mut base = 0;
         for batch in batches {
             let row_count = batch.num_rows();
+            let row_slice = &mut rows[base..base + batch.num_rows()];

Review Comment:
   This is the change that enables removing row_count, it doesn't appear to be used elsewhere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org