You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/28 09:21:26 UTC
[GitHub] [iceberg] zhangjun0x01 opened a new issue #1995: Flink : table column comment missing
zhangjun0x01 opened a new issue #1995:
URL: https://github.com/apache/iceberg/issues/1995
When we create an iceberg table by flink (hive catalog mode), the field comment is missing, so we cannot view the column comment on hive or flink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1995: Flink : table column comment missing
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1995:
URL: https://github.com/apache/iceberg/issues/1995#issuecomment-751859764
For reference, the associated PR that retains the avro field docs (which I'm pretty sure is where the loss is happening) is https://github.com/apache/iceberg/pull/1991.
It's possible that the field comments have been lost given that you cannot view the comments in either hive or flink. You could inspect one of the more recent table manifest files for the header to get the schema. If the comments are not there, you might need to run an `ALTER TABLE` command to re-add them on existing tables (assuming this patch fixes the problem).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #1995: Flink : table column comment missing
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #1995:
URL: https://github.com/apache/iceberg/issues/1995#issuecomment-751856077
This is possibly somewhat related to the loss of field level docs when converting between iceberg schemas and avro schemas, as mentioned here: https://github.com/apache/iceberg/issues/1954
I submitted a patch which merged this morning. You might see if that resolves the issue? If I have time I can add a test to check if this is still the case (or just test manually), but from memory the flink code _appeared_ to pull field docs when I worked on that ticket so I think they're likely lost when the iceberg schema is passed through to avro (for manifests).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhangjun0x01 commented on issue #1995: Flink : table column comment missing
Posted by GitBox <gi...@apache.org>.
zhangjun0x01 commented on issue #1995:
URL: https://github.com/apache/iceberg/issues/1995#issuecomment-752303808
@kbendick I tested it use iceberg master branch , the comment is still missing,I will look up the reason later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org