[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349310#comment-16349310 ] 

Jacques Le Roux commented on OFBIZ-10188:
-----------------------------------------

Thanks Gil,

This seems almost ready to be commited :)

Maybe UtilProperties could be replaced by EntityUtilProperties ?

Why did you pick 
zos.setLevel(9) 
instead of default (DEFAULT_COMPRESSION == -1) Note that I have nothing against, just a question. Most of the time default are better, that's why I ask.

You use 
byte bufferData[] = new byte[2048];
and
byte[] buffer = new byte[1024];
Maybe we could follow the same way than at https://bugs.openjdk.java.net/browse/JDK-4953311 and use a normalised buffer of 8k?

> Add new FileUtil methods for zip management
> -------------------------------------------
>
>                 Key: OFBIZ-10188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10188
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Gil Portenseigne
>            Assignee: Gil Portenseigne
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch
>
>
> Add new FileUtil methods for zip management.
> Add zipFileStream method that will zip FileStream to a zipped one.
> Add unzipFileToFolder method to unzip a given archive to a given Folder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)