You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/08 08:11:08 UTC

[GitHub] [kylin] zzcclp commented on a change in pull request #1259: KYLIN-4567 Improve TopN merge performance in MR engine

zzcclp commented on a change in pull request #1259:
URL: https://github.com/apache/kylin/pull/1259#discussion_r451362075



##########
File path: core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNCounter.java
##########
@@ -43,8 +43,10 @@
 public class TopNCounter<T> implements Iterable<Counter<T>>, java.io.Serializable {
 
     public static final int EXTRA_SPACE_RATE = 50;
+    public static final int EXTRA_SORT_RATE = 10;

Review comment:
       It's better to add a property for this parameter, and set to a default value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org