[GitHub] [brooklyn-server] zan-mateusz commented on a diff in pull request #1373: add child tags at start of list, in front of parent tags

[GitBox <gi...@apache.org>]

zan-mateusz commented on code in PR #1373:
URL: https://github.com/apache/brooklyn-server/pull/1373#discussion_r1040759619


##########
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java:
##########
@@ -278,11 +278,15 @@ protected TagsResolver(BrooklynYamlTypeInstantiator.Factory instantiator) {
         public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs, Set<String> encounteredRegisteredTypeIds) {
             Iterable<Object> decorationAttributeJsonValue = getDecorationAttributeJsonValue(attrs);
             if (decorationAttributeJsonValue != null) {
-                entitySpec.tagsAdd(decorationAttributeJsonValue);
+                entitySpec.tagsAddAtStart(decorationAttributeJsonValue);
             }
+
+            // 1) append at start each loop as we descend, so findFirst works <- probably what we intend with tags, child tags should come first

Review Comment:
   shall we remove these comments? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org