[jira] [Commented] (NIFI-5476) Enable TLS Toolkit (standalone) to sign certificates with external CA certificate

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567759#comment-16567759 ] 

ASF GitHub Bot commented on NIFI-5476:
--------------------------------------

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/2935

    NIFI-5476 Allow TLS toolkit to use externally-signed CA in standalone mode 

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-5476

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2935
    
----
commit 5e6c43f83ed818308bdd04d84037bdce6d13206a
Author: Andy LoPresto <al...@...>
Date:   2018-07-31T03:47:14Z

    NIFI-5473 Added section on using external signed CA for TLS Toolkit.
    Increased TOC level to 3 for ASCIIDOC generated documentation.
    
    This closes #2927.
    
    Signed-off-by: Andrew Lim <an...@gmail.com>

commit 36054d5f54bb6ec5a4b0fd4b219a2e33e26cbf16
Author: Andy LoPresto <al...@...>
Date:   2018-08-01T04:26:16Z

    NIFI-5476 Added logic to check CA certificate signature against additional certificates.
    Moved utility code to TlsHelper.
    Added unit tests.

commit 0b4b0f894ec5807137c0117458317173ce30d9ca
Author: Andy LoPresto <al...@...>
Date:   2018-08-01T06:25:02Z

    NIFI-5476 Added command-line parsing for additional CA certificate path.
    Added unit tests.

commit 4a9f87634e9330203b7146903f0aa399fad1b1ac
Author: Andy LoPresto <al...@...>
Date:   2018-08-03T03:51:56Z

    NIFI-5473 Added documentation on using the TLS Toolkit to generate and sign certificates using an externally-signed CA.

commit 1c5629e5970580b33f0732582b5d55bdd2b1292e
Author: Andy LoPresto <al...@...>
Date:   2018-08-03T04:19:17Z

    NIFI-5476 Updated toolkit external CA documentation to be inline with additional context from NIFI-5473.

commit 475ba66c9c4e0c33ab212eac0e99c79e6a53dbcf
Author: Andy LoPresto <al...@...>
Date:   2018-08-03T04:27:10Z

    NIFI-5476 Cleaned up toolkit documentation.

----


> Enable TLS Toolkit (standalone) to sign certificates with external CA certificate
> ---------------------------------------------------------------------------------
>
>                 Key: NIFI-5476
>                 URL: https://issues.apache.org/jira/browse/NIFI-5476
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Security, Tools and Build
>    Affects Versions: 1.7.1
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>            Priority: Major
>              Labels: certificate, pem, pkcs1, pkcs8, pki, security, tls, tls-toolkit
>
> The TLS Toolkit can sign certificates using a public certificate and private key generated and signed elsewhere by injecting them into the {{nifi-cert.pem}} and {{nifi-key.key}} files as long as they are in the proper format and self-signed. The toolkit should be enhanced to handle PKCS #8 formatted private keys (in addition to the PKCS #1 formatted keys it handles now) and to allow for non self-signed certificates. 
> To verify this, use certificates generated by [TinyCert|https://tinycert.org].  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)