You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/03/11 22:52:46 UTC
[jira] Created: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
-----------------------------------------------------------------------------------
Key: HBASE-504
URL: https://issues.apache.org/jira/browse/HBASE-504
Project: Hadoop HBase
Issue Type: Improvement
Affects Versions: 0.1.0, 0.2.0, 0.16.0
Reporter: stack
Priority: Minor
Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-504:
------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed (Thanks for the review Jim)
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 504-v3.patch, message-v2.patch, ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-504:
------------------------
Attachment: 504-v3.patch
Here is a patch that adds optional messages. I added messages for split, failing close (adds exception on why we're failing), and to the close if we're closing because of the rebalancing.
Here is commit message:
{code}
M src/test/org/apache/hadoop/hbase/TestSerialization.java
Add test that HMsg with region and message serializes.
M src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
HMsg types have been enumified. Also use some of the new
static messages. On split and close because of error,
add message to the HMsg we pass back to the master.
M src/java/org/apache/hadoop/hbase/HServerInfo.java
(compareTo): Added.
M src/java/org/apache/hadoop/hbase/HRegionInfo.java
Allow null in compareTo.
M src/java/org/apache/hadoop/hbase/master/ServerManager.java
Use the new HMsg.isType figuring message type.
Redo message logging. Use convenience HMsg statics.
M src/java/org/apache/hadoop/hbase/master/RegionManager.java
Pass back overloaded message if region shutdown because of balancing.
M src/java/org/apache/hadoop/hbase/HServerAddress.java
Make it so that two addresses equate even if one has hostname
and the other IP.
M src/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
Up the protocol version for regionserver reporting master messages.
M src/java/org/apache/hadoop/hbase/HMsg.java
Enumify the messge types.
Define a few static HMsgs for convenience.
Allow optional message. Improved toString.
(isType, equals, hashCode): Added.
{code}
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 504-v3.patch, message-v2.patch, ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-504:
------------------------
Status: Patch Available (was: Open)
Looking for a review.
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.1.0, 0.16.0, 0.2.0
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 504-v3.patch, message-v2.patch, ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-504:
------------------------
Fix Version/s: 0.2.0
Moving to 0.2.0. If we're going to be redoing how state changes in master, might be easy to do this at that time.
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Priority: Minor
> Fix For: 0.2.0
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-504:
------------------------
Attachment: ott.patch
Here's a patch but went too far; added source to every HMsg. Source was serverinfo+regioninfo. Its overkill. Backing down but here's a patch with how far I got.
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-504:
------------------------
Attachment: message-v2.patch
Second attempt. Needs some polish.
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: message-v2.patch, ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598508#action_12598508 ]
Jim Kellerman commented on HBASE-504:
-------------------------------------
Reviewed patch. +1.
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 504-v3.patch, message-v2.patch, ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-504) Allow HMsg's carry a payload: e.g.
exception that happened over on the remote side.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-504:
---------------------------
Assignee: stack
> Allow HMsg's carry a payload: e.g. exception that happened over on the remote side.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-504
> URL: https://issues.apache.org/jira/browse/HBASE-504
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.16.0, 0.2.0, 0.1.0
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: ott.patch
>
>
> Will make it so can just look in master log and get a general sense of failure types, etc., across the cluster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.