[jira] [Commented] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

["Gil Portenseigne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566446#comment-16566446 ] 

Gil Portenseigne commented on OFBIZ-10503:
------------------------------------------

Hi [~mthl], i did review you improvement, and i have a doubt about the implementation. I see no sorting method on the position, indeed every fields are well grouped, but i see no garanty about the order in the resulting array.

While testing and debugging, i saw no issue (though i do not know if position is used in list/grid).

WDYT ?

> Inline ‘getFieldListsByPosition’ method
> ---------------------------------------
>
>                 Key: OFBIZ-10503
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10503
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Gil Portenseigne
>            Priority: Minor
>         Attachments: OFBIZ-10503_Inline-getFieldListsByPosition.patch
>
>
> {{FormRenderer::getFieldListsByPosition}} is trivial to implement with a {{Collectors::groupingBy}} collector. The attached patch inlines the two calls of this private method and uses a stream based implementation instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)