You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "dossett (via GitHub)" <gi...@apache.org> on 2026/08/17 17:32:20 UTC
[PR] [minor] Upgrade thrift to 0.24 [parquet-java]
dossett opened a new pull request, #3730:
URL: https://github.com/apache/parquet-java/pull/3730
I was testing a PR and couldn't `brew install` thrift 0.23, because only 0.24 is available. So this PR does two things:
- bump to 0.24
- add an experimental `Dockerfile` that developers can use that removes the dependency on a locally installed copy of thrift (and any other dependency).
I find solutions like the Dockerfile to be really useful, but if maintainers feel its not appropriate to add to the repo I would certainly understand. The part can be reverted and the thrift upgrade will work just fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Upgrade thrift to 0.24 [parquet-java]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #3730:
URL: https://github.com/apache/parquet-java/pull/3730#discussion_r3801733105
##########
README.md:
##########
@@ -43,23 +43,23 @@ Parquet-Java requires Java 17 or higher and uses Maven to build. It also depends
To build and install the thrift compiler, run:
```
-wget -nv https://archive.apache.org/dist/thrift/0.23.0/thrift-0.23.0.tar.gz
-tar xzf thrift-0.23.0.tar.gz
-cd thrift-0.23.0
+wget -nv https://archive.apache.org/dist/thrift/0.24.0/thrift-0.24.0.tar.gz
+tar xzf thrift-0.24.0.tar.gz
+cd thrift-0.24.0
chmod +x ./configure
./configure --disable-libs
sudo make install -j
```
Note: if you wish to verify the signature and checksum of a release:
-1. The GPG and sha checksums can be found under https://archive.apache.org/dist/thrift/0.23.0/
+1. The GPG and sha checksums can be found under https://archive.apache.org/dist/thrift/0.24.0/
2. Validate the signature of the artifact against the [Thrift committer KEYS](https://downloads.apache.org/thrift/KEYS).
-If you're on OSX and use homebrew, you can instead install Thrift 0.23.0 with `brew` and ensure that it comes first in your `PATH`.
+If you're on OSX and use homebrew, you can instead install Thrift 0.24.0 with `brew` and ensure that it comes first in your `PATH`.
```
brew install thrift
-export PATH="/usr/local/opt/thrift@0.23.0/bin:$PATH"
+export PATH="$(brew --prefix thrift)/bin:$PATH"
Review Comment:
Unfortunally, this is an improvement since brew does not keep the old Thrift versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Upgrade thrift to 0.24 [parquet-java]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #3730:
URL: https://github.com/apache/parquet-java/pull/3730#issuecomment-5497323492
@dossett Thanks for raising this PR, and thanks @explore-with-yasir for the review 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Upgrade thrift to 0.24 [parquet-java]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #3730:
URL: https://github.com/apache/parquet-java/pull/3730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org