You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/04/19 15:00:38 UTC
[GitHub] [pulsar-client-python] BewareMyPower opened a new pull request, #110: Upgrade fastavro to 1.7.3
BewareMyPower opened a new pull request, #110:
URL: https://github.com/apache/pulsar-client-python/pull/110
Fixes https://github.com/apache/pulsar-client-python/issues/67
This PR fixes the client cannot be installed with `[avro]`. Take Python 3.11 on Windows as example:
```PowerShell
D:\> py -m pip install 'pulsar_client-3.2.0a1-cp311-cp311-win_amd64.whl[avro]'
Processing d:\pulsar_client-3.2.0a1-cp311-cp311-win_amd64.whl
Requirement already satisfied: certifi in c:\users\xuyunze\appdata\local\programs\python\python311\lib\site-packages (from pulsar-client==3.2.0a1) (2022.12.7)
Collecting fastavro==1.7.3
Using cached fastavro-1.7.3-cp311-cp311-win_amd64.whl (406 kB)
pulsar-client is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of the wheel.
Installing collected packages: fastavro
Successfully installed fastavro-1.7.3
[notice] A new release of pip is available: 23.0.1 -> 23.1
[notice] To update, run: python.exe -m pip install --upgrade pip
```
TODO: fix the client cannot be installed with `[all]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] tisonkun commented on a diff in pull request #110: Upgrade fastavro to 1.7.3
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #110:
URL: https://github.com/apache/pulsar-client-python/pull/110#discussion_r1171603513
##########
setup.py:
##########
@@ -90,7 +90,7 @@ def build_extension(self, ext):
# avro dependencies
extras_require["avro"] = sorted(
{
- "fastavro==0.24.0"
+ "fastavro==1.7.3"
Review Comment:
Fixed version or at least a `^x.y.z` manner can prevent unintentional version bump?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #110: Upgrade fastavro to 1.7.3
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on code in PR #110:
URL: https://github.com/apache/pulsar-client-python/pull/110#discussion_r1172054223
##########
setup.py:
##########
@@ -90,7 +90,7 @@ def build_extension(self, ext):
# avro dependencies
extras_require["avro"] = sorted(
{
- "fastavro==0.24.0"
+ "fastavro==1.7.3"
Review Comment:
If we let `pip` resolve the latest, maybe the support for some older Python versions might be dropped unexpectedly.
I think we should add extra workflows to verify the compatibility for the lowest version and highest version that we supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #110: Upgrade fastavro to 1.7.3
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on code in PR #110:
URL: https://github.com/apache/pulsar-client-python/pull/110#discussion_r1171593128
##########
setup.py:
##########
@@ -90,7 +90,7 @@ def build_extension(self, ext):
# avro dependencies
extras_require["avro"] = sorted(
{
- "fastavro==0.24.0"
+ "fastavro==1.7.3"
Review Comment:
Could we just remove the version here and let `pip` resolve the latest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] merlimat merged pull request #110: Upgrade fastavro to 1.7.3
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #110:
URL: https://github.com/apache/pulsar-client-python/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org