You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bowrna (via GitHub)" <gi...@apache.org> on 2024/05/21 04:53:02 UTC

[PR] removing deprecations gke [airflow]

Bowrna opened a new pull request, #39727:
URL: https://github.com/apache/airflow/pull/39727

   Related: #39485
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on code in PR #39727:
URL: https://github.com/apache/airflow/pull/39727#discussion_r1615656115


##########
tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py:
##########
@@ -40,7 +40,12 @@
 GCP_LOCATION = "europe-north1-a"
 CLUSTER_NAME = f"gke-async-{ENV_ID}".replace("_", "-")
 
-CLUSTER = {"name": CLUSTER_NAME, "initial_node_count": 1}
+CLUSTER = {
+    "name": CLUSTER_NAME,
+    "node_pools": {
+        "initial_node_count": 1,
+    },

Review Comment:
   I didn't run it with my local environment and @VladaZakharova pointed out this test errors. 
   
   https://github.com/apache/airflow/pull/39713



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "MaksYermak (via GitHub)" <gi...@apache.org>.
MaksYermak commented on code in PR #39727:
URL: https://github.com/apache/airflow/pull/39727#discussion_r1608215244


##########
tests/always/test_example_dags.py:
##########
@@ -56,11 +56,11 @@
     "tests/system/providers/google/cloud/dataproc/example_dataproc_gke.py",
     "tests/system/providers/google/cloud/gcs/example_gcs_sensor.py",
     "tests/system/providers/google/cloud/gcs/example_gcs_to_gcs.py",
-    "tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine.py",
-    "tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py",
-    "tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_job.py",
-    "tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_kueue.py",
-    "tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_resource.py",
+    # "tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine.py",

Review Comment:
   Why did you comment these rows rather than remove them?



##########
tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py:
##########
@@ -40,7 +40,12 @@
 GCP_LOCATION = "europe-north1-a"
 CLUSTER_NAME = f"gke-async-{ENV_ID}".replace("_", "-")
 
-CLUSTER = {"name": CLUSTER_NAME, "initial_node_count": 1}
+CLUSTER = {
+    "name": CLUSTER_NAME,
+    "node_pools": {
+        "initial_node_count": 1,
+    },

Review Comment:
   Did you try to run these tests with this configuration in your local environment?
   Because I have an error when I try to run tests with this configuration:
   `google.protobuf.json_format.ParseError: Failed to parse node_pools field: repeated field node_pools must be in [] which is {'initial_node_count': 1} at Cluster.
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on code in PR #39727:
URL: https://github.com/apache/airflow/pull/39727#discussion_r1615656115


##########
tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py:
##########
@@ -40,7 +40,12 @@
 GCP_LOCATION = "europe-north1-a"
 CLUSTER_NAME = f"gke-async-{ENV_ID}".replace("_", "-")
 
-CLUSTER = {"name": CLUSTER_NAME, "initial_node_count": 1}
+CLUSTER = {
+    "name": CLUSTER_NAME,
+    "node_pools": {
+        "initial_node_count": 1,
+    },

Review Comment:
   I didn't run it with my local environment and @VladaZakharova pointed out this test errors here
   
   https://github.com/apache/airflow/pull/39713



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39727:
URL: https://github.com/apache/airflow/pull/39727#issuecomment-2227532561

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on PR #39727:
URL: https://github.com/apache/airflow/pull/39727#issuecomment-2132978951

   #39713 - similar issue 
   Facing issues in running these test dags in GCP environment. I thought that it was a deprecation warning removal and went with the configuration parsing as suggested in the deprecation warning message assuming it would be right. I didn't verify the dags by running on a GCP environment to verify if the config is right. In case if issue is persisting, please feel free to fix this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on code in PR #39727:
URL: https://github.com/apache/airflow/pull/39727#discussion_r1615656115


##########
tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py:
##########
@@ -40,7 +40,12 @@
 GCP_LOCATION = "europe-north1-a"
 CLUSTER_NAME = f"gke-async-{ENV_ID}".replace("_", "-")
 
-CLUSTER = {"name": CLUSTER_NAME, "initial_node_count": 1}
+CLUSTER = {
+    "name": CLUSTER_NAME,
+    "node_pools": {
+        "initial_node_count": 1,
+    },

Review Comment:
   I didn't run it with my local environment and @VladaZakharova pointed out this test errors. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] removing deprecations gke [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #39727: removing deprecations gke
URL: https://github.com/apache/airflow/pull/39727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org