You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/25 06:11:24 UTC

[GitHub] [kafka] dengziming commented on a diff in pull request #12205: MINOR: Fix missing UNREGISTER_BROKER call in KafkaApis

dengziming commented on code in PR #12205:
URL: https://github.com/apache/kafka/pull/12205#discussion_r881253148


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -229,6 +229,8 @@ class KafkaApis(val requestChannel: RequestChannel,
         case ApiKeys.ENVELOPE => handleEnvelope(request, requestLocal)
         case ApiKeys.DESCRIBE_CLUSTER => handleDescribeCluster(request)
         case ApiKeys.DESCRIBE_PRODUCERS => handleDescribeProducersRequest(request)
+        case ApiKeys.UNREGISTER_BROKER => maybeForwardToController(request,

Review Comment:
   nit: we already have a `forwardToControllerOrFail` method which can be used here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org