You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2011/09/26 01:07:42 UTC
[vote] release wicket 1.5.1 take 2
This vote is to release wicket 1.5.1 take 2
Branch
http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1
Artifacts
http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/
Maven repo
https://repository.apache.org/content/repositories/orgapachewicket-099/
Changelog
https://issues.apache.org/jira/secure/ReleaseNote.jspa?&version=12315430&projectId=12310561
This vote ends Wednesday, September 28th at 4:00pm (GMT-7)
Please test the release and offer your vote.
The Wicket team!
Re: [vote] release wicket 1.5.1 take 2
Posted by Martin Grigorov <mg...@apache.org>.
Please continue this topic in a separate thread.
Thanks! :-)
On Wed, Sep 28, 2011 at 9:51 AM, Emond Papegaaij
<em...@topicus.nl> wrote:
> It is your mapper that triggers this issue, therefore it is easy to work
> around. You only have to prevent the code added for WIKCET-4014 from being
> called, like this:
>
> public Url mapHandler(IRequestHandler requestHandler) {
> if (requestHandler instanceof ListenerInterfaceRequestHandler)
> return null;
> return super.mapHandler(requestHandler);
> }
>
> I've tested it on your quickstart, and it works.
>
> Emond
>
> On Tuesday 27 September 2011 21:25:41 bht@actrix.gen.nz wrote:
>> (non-binding) -1
>>
>> Thanks for reviewing WICKET-4087.
>>
>> Sorry, I don't have a workaround. This might be a misunderstanding. It
>> is the mapper that triggers this issue. Sure it is a corner case. But
>> a very simple one, and the changes might cause other hard to find
>> issues. Most Bugs are corner cases.
>>
>> Bernard
>>
>> On Tue, 27 Sep 2011 15:26:12 +0200, you wrote:
>> >(non-binding) +1
>> >Our application is running fine on 1.5.1. De reported issues are fixed, as
>> >far as we could reproduce them.
>> >
>> >Wrt WICKET-4087, I think this is a corner case and should be easy to work
>> >around, because Bernard already has his own mapper. The change was
>> >introduced with the fix for WICKET-4014.
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: [vote] release wicket 1.5.1 take 2
Posted by Emond Papegaaij <em...@topicus.nl>.
It is your mapper that triggers this issue, therefore it is easy to work
around. You only have to prevent the code added for WIKCET-4014 from being
called, like this:
public Url mapHandler(IRequestHandler requestHandler) {
if (requestHandler instanceof ListenerInterfaceRequestHandler)
return null;
return super.mapHandler(requestHandler);
}
I've tested it on your quickstart, and it works.
Emond
On Tuesday 27 September 2011 21:25:41 bht@actrix.gen.nz wrote:
> (non-binding) -1
>
> Thanks for reviewing WICKET-4087.
>
> Sorry, I don't have a workaround. This might be a misunderstanding. It
> is the mapper that triggers this issue. Sure it is a corner case. But
> a very simple one, and the changes might cause other hard to find
> issues. Most Bugs are corner cases.
>
> Bernard
>
> On Tue, 27 Sep 2011 15:26:12 +0200, you wrote:
> >(non-binding) +1
> >Our application is running fine on 1.5.1. De reported issues are fixed, as
> >far as we could reproduce them.
> >
> >Wrt WICKET-4087, I think this is a corner case and should be easy to work
> >around, because Bernard already has his own mapper. The change was
> >introduced with the fix for WICKET-4014.
Re: [vote] release wicket 1.5.1 take 2
Posted by Martijn Dashorst <ma...@gmail.com>.
+1
On Wed, Sep 28, 2011 at 9:13 AM, Martin Grigorov <mg...@apache.org> wrote:
> +1
>
> On Tue, Sep 27, 2011 at 9:25 PM, <bh...@actrix.gen.nz> wrote:
>> (non-binding) -1
>>
>> Thanks for reviewing WICKET-4087.
>>
>> Sorry, I don't have a workaround. This might be a misunderstanding. It
>> is the mapper that triggers this issue. Sure it is a corner case. But
>> a very simple one, and the changes might cause other hard to find
>> issues. Most Bugs are corner cases.
>>
>> Bernard
>>
>> On Tue, 27 Sep 2011 15:26:12 +0200, you wrote:
>>
>>>(non-binding) +1
>>>Our application is running fine on 1.5.1. De reported issues are fixed, as far
>>>as we could reproduce them.
>>>
>>>Wrt WICKET-4087, I think this is a corner case and should be easy to work
>>>around, because Bernard already has his own mapper. The change was introduced
>>>with the fix for WICKET-4014.
>>
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: [vote] release wicket 1.5.1 take 2
Posted by Andrea Del Bene <ad...@ciseonweb.it>.
+1
> +1
>
> On Tue, Sep 27, 2011 at 9:25 PM,<bh...@actrix.gen.nz> wrote:
>> (non-binding) -1
>>
>> Thanks for reviewing WICKET-4087.
>>
>> Sorry, I don't have a workaround. This might be a misunderstanding. It
>> is the mapper that triggers this issue. Sure it is a corner case. But
>> a very simple one, and the changes might cause other hard to find
>> issues. Most Bugs are corner cases.
>>
>> Bernard
>>
>> On Tue, 27 Sep 2011 15:26:12 +0200, you wrote:
>>
>>> (non-binding) +1
>>> Our application is running fine on 1.5.1. De reported issues are fixed, as far
>>> as we could reproduce them.
>>>
>>> Wrt WICKET-4087, I think this is a corner case and should be easy to work
>>> around, because Bernard already has his own mapper. The change was introduced
>>> with the fix for WICKET-4014.
>>
>
>
Re: [vote] release wicket 1.5.1 take 2
Posted by Martin Grigorov <mg...@apache.org>.
+1
On Tue, Sep 27, 2011 at 9:25 PM, <bh...@actrix.gen.nz> wrote:
> (non-binding) -1
>
> Thanks for reviewing WICKET-4087.
>
> Sorry, I don't have a workaround. This might be a misunderstanding. It
> is the mapper that triggers this issue. Sure it is a corner case. But
> a very simple one, and the changes might cause other hard to find
> issues. Most Bugs are corner cases.
>
> Bernard
>
> On Tue, 27 Sep 2011 15:26:12 +0200, you wrote:
>
>>(non-binding) +1
>>Our application is running fine on 1.5.1. De reported issues are fixed, as far
>>as we could reproduce them.
>>
>>Wrt WICKET-4087, I think this is a corner case and should be easy to work
>>around, because Bernard already has his own mapper. The change was introduced
>>with the fix for WICKET-4014.
>
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: [vote] release wicket 1.5.1 take 2
Posted by bh...@actrix.gen.nz.
(non-binding) -1
Thanks for reviewing WICKET-4087.
Sorry, I don't have a workaround. This might be a misunderstanding. It
is the mapper that triggers this issue. Sure it is a corner case. But
a very simple one, and the changes might cause other hard to find
issues. Most Bugs are corner cases.
Bernard
On Tue, 27 Sep 2011 15:26:12 +0200, you wrote:
>(non-binding) +1
>Our application is running fine on 1.5.1. De reported issues are fixed, as far
>as we could reproduce them.
>
>Wrt WICKET-4087, I think this is a corner case and should be easy to work
>around, because Bernard already has his own mapper. The change was introduced
>with the fix for WICKET-4014.
Re: [vote] release wicket 1.5.1 take 2
Posted by Emond Papegaaij <em...@topicus.nl>.
(non-binding) +1
Our application is running fine on 1.5.1. De reported issues are fixed, as far
as we could reproduce them.
Wrt WICKET-4087, I think this is a corner case and should be easy to work
around, because Bernard already has his own mapper. The change was introduced
with the fix for WICKET-4014.
On Monday 26 September 2011 01:07:42 Igor Vaynberg wrote:
> This vote is to release wicket 1.5.1 take 2
>
> Branch
> http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1
>
> Artifacts
> http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/
>
> Maven repo
> https://repository.apache.org/content/repositories/orgapachewicket-099/
>
> Changelog
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?&version=12315430&pr
> ojectId=12310561
>
> This vote ends Wednesday, September 28th at 4:00pm (GMT-7)
>
> Please test the release and offer your vote.
>
> The Wicket team!
Re: [vote] release wicket 1.5.1 take 2
Posted by bh...@actrix.gen.nz.
I have just found an issue
https://issues.apache.org/jira/browse/WICKET-4087
Thanks,
Bernard
Re: [vote] release wicket 1.5.1 take 2
Posted by Igor Vaynberg <ig...@gmail.com>.
release vote has passed with 3 +1 binding votes.
-igor
On Sun, Sep 25, 2011 at 4:07 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> This vote is to release wicket 1.5.1 take 2
>
> Branch
> http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1
>
> Artifacts
> http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/
>
> Maven repo
> https://repository.apache.org/content/repositories/orgapachewicket-099/
>
> Changelog
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?&version=12315430&projectId=12310561
>
> This vote ends Wednesday, September 28th at 4:00pm (GMT-7)
>
> Please test the release and offer your vote.
>
> The Wicket team!
>
Re: [vote] release wicket 1.5.1 take 2
Posted by Igor Vaynberg <ig...@gmail.com>.
+1
-igor
On Sun, Sep 25, 2011 at 4:07 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> This vote is to release wicket 1.5.1 take 2
>
> Branch
> http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1
>
> Artifacts
> http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/
>
> Maven repo
> https://repository.apache.org/content/repositories/orgapachewicket-099/
>
> Changelog
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?&version=12315430&projectId=12310561
>
> This vote ends Wednesday, September 28th at 4:00pm (GMT-7)
>
> Please test the release and offer your vote.
>
> The Wicket team!
>