You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by cs...@apache.org on 2023/12/11 10:15:31 UTC
(maven-resolver) branch master updated: [MRESOLVER-449] Step toward testing all HTTP transports, addendum
This is an automated email from the ASF dual-hosted git repository.
cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
The following commit(s) were added to refs/heads/master by this push:
new b364fd98 [MRESOLVER-449] Step toward testing all HTTP transports, addendum
b364fd98 is described below
commit b364fd98431bc082e8bf3065350b5c81b0fdf07c
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Mon Dec 11 11:14:34 2023 +0100
[MRESOLVER-449] Step toward testing all HTTP transports, addendum
Fix test overrides, as how it was done did not make it obvious (from junit reports)
that they are actually disabled tests.
---
https://issues.apache.org/jira/browse/MRESOLVER-449
---
.../aether/transport/jdk/JdkTransporterTest.java | 36 ++++++++++++++++------
.../transport/jetty/JettyTransporterTest.java | 25 +++++++++++----
2 files changed, 46 insertions(+), 15 deletions(-)
diff --git a/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java b/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java
index 44cf3f38..72a2b759 100644
--- a/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java
+++ b/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java
@@ -38,32 +38,50 @@ import static org.junit.jupiter.api.Assertions.fail;
@SuppressWarnings({"checkstyle:magicnumber"})
class JdkTransporterTest extends HttpTransporterTest {
+ @Override
@Disabled
- protected void testAuthSchemeReuse() throws Exception {}
+ @Test
+ protected void testAuthSchemeReuse() {}
+ @Override
@Disabled
- protected void testPut_ProxyUnauthenticated() throws Exception {}
+ @Test
+ protected void testPut_ProxyUnauthenticated() {}
+ @Override
@Disabled
- protected void testAuthSchemePreemptive() throws Exception {}
+ @Test
+ protected void testAuthSchemePreemptive() {}
+ @Override
@Disabled
- protected void testPut_AuthCache_Preemptive() throws Exception {}
+ @Test
+ protected void testPut_AuthCache_Preemptive() {}
+ @Override
@Disabled
- protected void testPut_Unauthenticated() throws Exception {}
+ @Test
+ protected void testPut_Unauthenticated() {}
+ @Override
@Disabled
- protected void testPut_PreemptiveIsDefault() throws Exception {}
+ @Test
+ protected void testPut_PreemptiveIsDefault() {}
+ @Override
@Disabled
- protected void testRetryHandler_defaultCount_positive() throws Exception {}
+ @Test
+ protected void testRetryHandler_defaultCount_positive() {}
+ @Override
@Disabled
- protected void testRetryHandler_explicitCount_positive() throws Exception {}
+ @Test
+ protected void testRetryHandler_explicitCount_positive() {}
+ @Override
@Disabled
- protected void testPut_Authenticated_ExpectContinueRejected_ExplicitlyConfiguredHeader() throws Exception {}
+ @Test
+ protected void testPut_Authenticated_ExpectContinueRejected_ExplicitlyConfiguredHeader() {}
public JdkTransporterTest() {
super(JdkTransporterFactory::new);
diff --git a/maven-resolver-transport-jetty/src/test/java/org/eclipse/aether/transport/jetty/JettyTransporterTest.java b/maven-resolver-transport-jetty/src/test/java/org/eclipse/aether/transport/jetty/JettyTransporterTest.java
index 1cac4fe3..3eb92656 100644
--- a/maven-resolver-transport-jetty/src/test/java/org/eclipse/aether/transport/jetty/JettyTransporterTest.java
+++ b/maven-resolver-transport-jetty/src/test/java/org/eclipse/aether/transport/jetty/JettyTransporterTest.java
@@ -20,29 +20,42 @@ package org.eclipse.aether.transport.jetty;
import org.eclipse.aether.internal.test.util.http.HttpTransporterTest;
import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
/**
* Jetty transporter UT.
*/
class JettyTransporterTest extends HttpTransporterTest {
+ @Override
@Disabled
- protected void testAuthSchemeReuse() throws Exception {}
+ @Test
+ protected void testAuthSchemeReuse() {}
+ @Override
@Disabled
- protected void testPut_ProxyUnauthenticated() throws Exception {}
+ @Test
+ protected void testPut_ProxyUnauthenticated() {}
+ @Override
@Disabled
- protected void testPut_Unauthenticated() throws Exception {}
+ @Test
+ protected void testPut_Unauthenticated() {}
+ @Override
@Disabled
- protected void testRetryHandler_defaultCount_positive() throws Exception {}
+ @Test
+ protected void testRetryHandler_defaultCount_positive() {}
+ @Override
@Disabled
- protected void testRetryHandler_explicitCount_positive() throws Exception {}
+ @Test
+ protected void testRetryHandler_explicitCount_positive() {}
+ @Override
@Disabled
- protected void testPut_Authenticated_ExpectContinueRejected_ExplicitlyConfiguredHeader() throws Exception {}
+ @Test
+ protected void testPut_Authenticated_ExpectContinueRejected_ExplicitlyConfiguredHeader() {}
public JettyTransporterTest() {
super(JettyTransporterFactory::new);