You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2017/05/12 07:43:54 UTC

[Bug 61088] New: Documentation upper/lower case mismach for SSLHostConfig doc and SSLHostConfig java source

https://bz.apache.org/bugzilla/show_bug.cgi?id=61088

            Bug ID: 61088
           Summary: Documentation upper/lower case mismach for
                    SSLHostConfig doc and SSLHostConfig java source
           Product: Tomcat 8
           Version: 8.5.x-trunk
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Documentation
          Assignee: dev@tomcat.apache.org
          Reporter: didier.wiroth@mesr.etat.lu
  Target Milestone: ----

There is an upper/lower case mismatch between SSLHostConfig code and the
documentation of SSLHostConfig:
https://tomcat.apache.org/tomcat-8.5-doc/config/http.html#SSL_Support_-_SSLHostConfig

Doc says quote:
"The token all is an alias for SSLv2Hello,TLSv1,TLSv1.1,TLSv1.2."
and "all" is listed as an option:

The source code uses with "A" uppercase:
static {
        /* Default used if protocols is not configured, also
           used if protocols="All" */
        /* If protocols is configured to be empty, the effective
           value comes from
          
org.apache.tomcat.util.net.jsse.JSSESocketFactory.defaultServerProtocols
           (JSSE) resp. org.apache.tomcat.jni.SSL.SSL_PROTOCOL_ALL (OpenSSL)*/
        SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_SSLv2Hello);
        SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_TLSv1);
        SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_TLSv1_1);
        SSL_PROTO_ALL_SET.add(Constants.SSL_PROTO_TLSv1_2);
}

Documentation should use the correct case:
"The token All is an alias for SSLv2Hello,TLSv1,TLSv1.1,TLSv1.2."
And the listing should use "All" everywhere.
Thx!
Didier

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 61088] Documentation upper/lower case mismach for SSLHostConfig doc and SSLHostConfig java source

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61088

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 OS|                            |All

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
1. That is a comment, not source code.

2. SSLHostConfig processes the configuration in a case insensitive manner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org