You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Rodolphe Dugé de Bernonville <rr...@gmail.com> on 2020/12/24 15:51:47 UTC

Review Request 73106: RANGER-3132: mapping problem for AuthzAuditEvent between ActionType and Action

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73106/
-----------------------------------------------------------

Review request for ranger.


Repository: ranger


Description
-------

RANGER-3132: mapping problem for AuthzAuditEvent between ActionType and Action


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 427372643 


Diff: https://reviews.apache.org/r/73106/diff/1/


Testing
-------

agents-common, hbase-agent, hdfs-agent, hive-agent, plugin-atlas, plugin-kafka, plugin-yarn compilation
is it enough ?


Thanks,

Rodolphe Dugé de Bernonville


Re: Review Request 73106: RANGER-3132: mapping problem for AuthzAuditEvent between ActionType and Action

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73106/#review222385
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java
Line 126 (original), 126 (patched)
<https://reviews.apache.org/r/73106/#comment311438>

    This update will cause existing audit records to become inconsistent with audit records created with this change. Hence, I recommend to not update existing assignment of AuthzAuditEvent fields.


- Madhan Neethiraj


On Dec. 24, 2020, 3:51 p.m., Rodolphe Dugé de Bernonville wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73106/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2020, 3:51 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3132: mapping problem for AuthzAuditEvent between ActionType and Action
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 427372643 
> 
> 
> Diff: https://reviews.apache.org/r/73106/diff/1/
> 
> 
> Testing
> -------
> 
> agents-common, hbase-agent, hdfs-agent, hive-agent, plugin-atlas, plugin-kafka, plugin-yarn compilation
> is it enough ?
> 
> 
> Thanks,
> 
> Rodolphe Dugé de Bernonville
> 
>


Re: Review Request 73106: RANGER-3132: mapping problem for AuthzAuditEvent between ActionType and Action

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73106/#review222384
-----------------------------------------------------------



Seems good. Thanks

- Don Bosco Durai


On Dec. 24, 2020, 3:51 p.m., Rodolphe Dugé de Bernonville wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73106/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2020, 3:51 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3132: mapping problem for AuthzAuditEvent between ActionType and Action
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 427372643 
> 
> 
> Diff: https://reviews.apache.org/r/73106/diff/1/
> 
> 
> Testing
> -------
> 
> agents-common, hbase-agent, hdfs-agent, hive-agent, plugin-atlas, plugin-kafka, plugin-yarn compilation
> is it enough ?
> 
> 
> Thanks,
> 
> Rodolphe Dugé de Bernonville
> 
>