[GitHub] [hive] yongzhi commented on a change in pull request #1506: HIVE-24135: Drop database doesn't delete directory in managed locatio…

[GitBox <gi...@apache.org>]

yongzhi commented on a change in pull request #1506:
URL: https://github.com/apache/hive/pull/1506#discussion_r640908620



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -1917,6 +1923,12 @@ private void drop_database_core(RawStore ms, String catName,
             LOG.error("Failed to delete database directory: " + db.getLocationUri() +
                 " " + e.getMessage());
           }
+          try {
+            wh.deleteDir(wh.getDatabaseManagedPath(db), true, db);
+          } catch (Exception e) {
+            LOG.error("Failed to delete database directory: " + db.getLocationUri() +

Review comment:
       should we are more consistent with the delete behavior, throw exception here too (the same as line 1789), the same is for 1923




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org