[jira] [Comment Edited] (IGNITE-7039) SQL: local query should pin affected partitions

["Roman Kondakov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292167#comment-16292167 ] 

Roman Kondakov edited comment on IGNITE-7039 at 12/15/17 9:20 AM:
------------------------------------------------------------------

[~vozerov], please review.
1) In {{IgniteH2Indexing.queryLocalSqlFields}} I implemented an eager partitions reservation on {{IgniteCache.query()}} call. I also implemented a test {{IgniteCacheLocalQueryReservationsTest}} for checking a partitions reservation status on each stage:
*  Before {{IgniteCache.query()}}.
*  After {{IgniteCache.query()}}.
*  After {{QueryCursor.iterator()}}.
*  After {{Iterator.next()}}.
*  After {{QueryCursor.close()}}.

2) I implemented another method for a gathering all caches ids used in a query based on {{GridSqlQueryParser}}. I also added a cache map for the parsed queries.


was (Author: rkondakov):
[~vozerov], please review.
1) In {{IgniteH2Indexing.queryLocalSqlFields}} I implemented an eager partitions reservation on {{IgniteCache.query()}} call. I also implemented a test {{IgniteCacheLocalQueryReservationsTest}} for checking a partitions reservation status on each stage:
*  Before {{IgniteCache.query()}}.
*  After {{IgniteCache.query()}}.
*  After {{QueryCursor.iterator()}}.
*  After {{Iterator.next()}}.
*  After {{QueryCursor.close()}}.

2. I implemented another method for a gathering all caches ids used in a query based on {{GridSqlQueryParser}}. I also added a cache map for the parsed queries.

> SQL: local query should pin affected partitions
> -----------------------------------------------
>
>                 Key: IGNITE-7039
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7039
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>            Reporter: Vladimir Ozerov
>            Assignee: Roman Kondakov
>             Fix For: 2.4
>
>
> When distributed query is executed, we pin cache partitions for particular topology version on map nodes [1]. However, it seems that we do no do that for local queries. This is a bug because partition with required data could be evicted from local node at any time, leading to incorrect results.
> [1] https://github.com/apache/ignite/blob/ignite-2.3/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java#L288



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)