You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by joewitt <gi...@git.apache.org> on 2017/04/11 19:41:38 UTC

[GitHub] nifi issue #1662: NIFI-3688 Extended Groovy Nifi Processor

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1662
  
    The commit which removed the properties/skip javadoc/src does need to be in the nar bundle itself.  We dont want src/javadocs for the nar bundle.  Also, the processor needs a name that follows the pattern of VerbSubject instead of GroovyX.
    
    We will definitely need unit tests for this.  There are references to Oracle things in there or at least in the screenshot.  The LICENSE and NOTICE appears to have a lot of copy/paste from other nars.  Are all those dependencies really there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---