You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/11 08:56:14 UTC
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12712
to review the following change.
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
IMPALA-6802 (part 5): Clean up authorization tests
The fifth part of this patch is to rewrite the following authorization
tests:
- compute/drop stats
- create database/table/view
- drop database/table/view
Cherry-picks: not for 2.x
Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Reviewed-on: http://gerrit.cloudera.org:8080/10799
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
R fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
1 file changed, 538 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/12712/1
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12712 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2403/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 09:36:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12712 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 14:57:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12712 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3900/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 08:57:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12712 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 12:50:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12712 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12712/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:
http://gerrit.cloudera.org:8080/#/c/12712/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1399
PS1, Line 1399: .error(createError("functional.alltypes_view"), onDatabase("functional", allExcept(
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 08:57:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12712 )
Change subject: IMPALA-6802 (part 5): Clean up authorization tests
......................................................................
IMPALA-6802 (part 5): Clean up authorization tests
The fifth part of this patch is to rewrite the following authorization
tests:
- compute/drop stats
- create database/table/view
- drop database/table/view
Cherry-picks: not for 2.x
Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Reviewed-on: http://gerrit.cloudera.org:8080/10799
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12712
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
R fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
1 file changed, 538 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Fredy Wijaya: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c5a90978892ab552846e7da8c17aeeb91e57526
Gerrit-Change-Number: 12712
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>