You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2008/03/04 22:07:40 UTC

[jira] Created: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Inappropriate test strategy in MailEchoRawXMLTest
-------------------------------------------------

                 Key: SYNAPSE-246
                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
             Project: Synapse
          Issue Type: Bug
          Components: Transports
    Affects Versions: NIGHTLY
            Reporter: Andreas Veithen
            Priority: Minor


The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:

1) It introduces a dependency external to the test itself.
2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
3) It slows down the execution of the tests.
4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.

Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579159#action_12579159 ] 

Ruwan Linton commented on SYNAPSE-246:
--------------------------------------

I have excluded this test case till we find a better approach

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Priority: Minor
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved SYNAPSE-246.
-------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: FUTURE)
                   1.3

The new testkit based mail transport tests use Greenmail and the old tests have been removed.

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: org.apache.synapse.transport.mail.MailEchoRawXMLTest.txt
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594146#action_12594146 ] 

Ruwan Linton commented on SYNAPSE-246:
--------------------------------------

This test case is still failing to me. So I have excluded it from the build

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623187#action_12623187 ] 

Andreas Veithen commented on SYNAPSE-246:
-----------------------------------------

Jens,

That is exactly the kind of tool I was looking for. Thanks!

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>         Attachments: org.apache.synapse.transport.mail.MailEchoRawXMLTest.txt
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruwan Linton updated SYNAPSE-246:
---------------------------------

    Attachment: org.apache.synapse.transport.mail.MailEchoRawXMLTest.txt

Reason for the test failure attached

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>         Attachments: org.apache.synapse.transport.mail.MailEchoRawXMLTest.txt
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Assigned: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reassigned SYNAPSE-246:
---------------------------------------

    Assignee: Andreas Veithen

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asankha C. Perera updated SYNAPSE-246:
--------------------------------------

    Fix Version/s: FUTURE

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594010#action_12594010 ] 

Andreas Veithen commented on SYNAPSE-246:
-----------------------------------------

Running the test case now causes a javax.mail.AuthenticationFailedException. I checked the accounts and synapse.test.1 has been disabled.

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Jens Goldhammer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620885#action_12620885 ] 

Jens Goldhammer commented on SYNAPSE-246:
-----------------------------------------

Maybe you can use GreenMail for testing.
Look at http://www.icegreen.com/greenmail/

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>         Attachments: org.apache.synapse.transport.mail.MailEchoRawXMLTest.txt
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594030#action_12594030 ] 

Andreas Veithen commented on SYNAPSE-246:
-----------------------------------------

Changed the unit tests to use mock JavaMail store and transport providers so that they no longer depend on GMail. This solves the issue, but still need to:
* clean up (in particular remove duplicate code!!);
* add documentation.

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>
>                 Key: SYNAPSE-246
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-246
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
>
>
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail account, connecting to smtp.gmail.com and pop.gmail.com. This strategy is inappropriate for several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically smtp.gmail.com replies with "421 4.4.5 Server busy, try again later.", causing the test to fail.
> Maybe we should consider using something like mock-javamail (https://mock-javamail.dev.java.net/) to make these tests self-containing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org