[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #71: HBASE-24778 [hbase-operator-tools] Merging regions failed when the table is not default namespace

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #71:
URL: https://github.com/apache/hbase-operator-tools/pull/71#discussion_r461454652



##########
File path: hbase-tools/src/main/java/org/apache/hbase/RegionsMerger.java
##########
@@ -88,9 +89,7 @@ public RegionsMerger(Configuration conf) throws IOException {
 
   private Path getTablePath(TableName table){
     Path basePath = new Path(conf.get(HConstants.HBASE_DIR));
-    basePath = new Path(basePath, "data");
-    Path tablePath = new Path(basePath, table.getNamespaceAsString());
-    return new Path(tablePath, table.getNameAsString());
+    return FSUtils.getTableDir(basePath, table);

Review comment:
       FSUtils is IA private, we shouldn't use it in hbase-operator-tools as it makes no compatibility guarantees. See HBASE-24626, HBASE-24482 and HBASE-23791 for issues caused by dependency on IA Private classes. Please revert this to your previous commit. 
   
   Tip: You may want to port this method to hbase-hbck2 HBCKFsUtils class. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org