You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/08/20 19:32:40 UTC

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11274


Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................

[hms] update the HIVE/HADOOP package scripts

This patch updates the HIVE/HADOOP package scripts to be more flexible,
so that users can chose whether do jar downloading or repackaing. It
also adjusts the jars that need to be stripped for universal HIVE and
HADOOP distributions.

Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
---
M thirdparty/package-hadoop.sh
M thirdparty/package-hive.sh
2 files changed, 113 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/11274/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 22:12:15 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 21:46:22 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................

[hms] update the HIVE/HADOOP package scripts

This patch updates the HIVE/HADOOP package scripts to be more flexible,
so that users can choose whether to do jar downloading or repackaging.
It also adjusts the jars that need to be stripped for universal HIVE
and HADOOP distributions.

Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Reviewed-on: http://gerrit.cloudera.org:8080/11274
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M thirdparty/package-hadoop.sh
M thirdparty/package-hive.sh
2 files changed, 155 insertions(+), 28 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Hao Hao: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11274/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11274/2//COMMIT_MSG@10
PS2, Line 10: do
Nit: to do


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh
File thirdparty/package-hadoop.sh:

http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh@49
PS2, Line 49:  ;
Nit: eliminate extra space here.


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh@72
PS2, Line 72:   wget https://archive.apache.org/dist/hadoop/common/$ARTIFACT/$ARTIFACT.tar.gz
Should have noticed this earlier, but let's use curl here instead of wget; the rest of the thirdparty scripts use curl.


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh@51
PS2, Line 51:  ;
Nit: extra space.


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh@75
PS2, Line 75:   wget https://archive.apache.org/dist/hive/hive-$VERSION/$ARTIFACT.tar.gz
Use curl.



-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 04:06:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 3:

Remove -1 due to the flaky test.


-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 22:12:46 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 22:57:37 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11274

to look at the new patch set (#2).

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................

[hms] update the HIVE/HADOOP package scripts

This patch updates the HIVE/HADOOP package scripts to be more flexible,
so that users can choose whether do jar downloading or repackaging. It
also adjusts the jars that need to be stripped for universal HIVE and
HADOOP distributions.

Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
---
M thirdparty/package-hadoop.sh
M thirdparty/package-hive.sh
2 files changed, 151 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/11274/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11274

to look at the new patch set (#3).

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................

[hms] update the HIVE/HADOOP package scripts

This patch updates the HIVE/HADOOP package scripts to be more flexible,
so that users can choose whether to do jar downloading or repackaging.
It also adjusts the jars that need to be stripped for universal HIVE
and HADOOP distributions.

Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
---
M thirdparty/package-hadoop.sh
M thirdparty/package-hive.sh
2 files changed, 155 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/11274/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 2:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG@10
PS1, Line 10:  repackagi
> repackaging
Done


http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG@10
PS1, Line 10: choos
> choose
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh
File thirdparty/package-hadoop.sh:

PS1: 
> Pretty much all of the feedback here applies to package-hive.sh too.
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@26
PS1, Line 26: optional
> Nit: optional (lower case).
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@39
PS1, Line 39: Download
> Download
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@40
PS1, Line 40: --repackag
> --repackage
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@49
PS1, Line 49: if [ ${OPTS_RESULT} != 0 ] ; then
> Nit: break this up onto separate lines.
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@51
PS1, Line 51: TS
> Nit: separate with a space from the semicolon
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@53
PS1, Line 53: 
> This was just for debugging, right?
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@55
PS1, Line 55:   case "$1" in
> Nit: -h | --help)
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@69
PS1, Line 69: fi
> Remove this?
Done


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@74
PS1, Line 74: fi
> Can you construct this list more clearly? Like:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 00:17:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11274/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11274/2//COMMIT_MSG@10
PS2, Line 10: to
> Nit: to do
Done


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh
File thirdparty/package-hadoop.sh:

http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh@49
PS2, Line 49: ; 
> Nit: eliminate extra space here.
Done


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hadoop.sh@72
PS2, Line 72:   curl --retry 3 -L -O https://archive.apache.org/dist/hadoop/common/$ARTIFACT/$ARTIFACT.tar.gz
> Should have noticed this earlier, but let's use curl here instead of wget; 
Done


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh@51
PS2, Line 51: ; 
> Nit: extra space.
Done


http://gerrit.cloudera.org:8080/#/c/11274/2/thirdparty/package-hive.sh@75
PS2, Line 75:   curl --retry 3 -L -O https://archive.apache.org/dist/hive/hive-$VERSION/$ARTIFACT.tar.gz
> Use curl.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 21:29:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] update the HIVE/HADOOP package scripts

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11274 )

Change subject: [hms] update the HIVE/HADOOP package scripts
......................................................................


Patch Set 1:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG@10
PS1, Line 10: chose
choose


http://gerrit.cloudera.org:8080/#/c/11274/1//COMMIT_MSG@10
PS1, Line 10: repackaing
repackaging


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh
File thirdparty/package-hadoop.sh:

PS1: 
Pretty much all of the feedback here applies to package-hive.sh too.


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@26
PS1, Line 26: Optional
Nit: optional (lower case).

On L28 too.


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@39
PS1, Line 39: Dowdload
Download


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@40
PS1, Line 40: -repackage
--repackage


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@49
PS1, Line 49: if [ ${OPTS_RESULT} != 0 ] ; then echo "Failed parsing options." >&2 ; exit ${OPTS_RESULT} ; fi
Nit: break this up onto separate lines.


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@51
PS1, Line 51: do
Nit: separate with a space from the semicolon


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@53
PS1, Line 53: echo here
This was just for debugging, right?


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@55
PS1, Line 55:     -h | --help )
Nit: -h | --help)

(to the other cases here too)


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@69
PS1, Line 69:   echo here
Remove this?


http://gerrit.cloudera.org:8080/#/c/11274/1/thirdparty/package-hadoop.sh@74
PS1, Line 74: for DIR in client common/jdiff common/sources hdfs/sources httpfs kms mapreduce/lib-examples mapreduce/sources tools; do
Can you construct this list more clearly? Like:

  DIRS="client"
  DIRS="$DIRS common/jdiff"
  DIRS="$DIRS common/sources"
  ...
  for DIR in $DIRS; do
    ...
  done

While more verbose, this format makes it easier to find individual entries and to keep them sorted.



-- 
To view, visit http://gerrit.cloudera.org:8080/11274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66c4e132800fbf5ea76ad4b1fec8212757c84c2
Gerrit-Change-Number: 11274
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 19:50:35 +0000
Gerrit-HasComments: Yes