You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sammy Nah (Code Review)" <ge...@cloudera.org> on 2023/04/13 05:17:52 UTC
[kudu-CR] [DRAFT] Create Memkind interface and separate NVM specific implementation
Sammy Nah has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19726
Change subject: [DRAFT] Create Memkind interface and separate NVM specific implementation
......................................................................
[DRAFT] Create Memkind interface and separate NVM specific implementation
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 633 insertions(+), 426 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/1
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 1
Gerrit-Owner: Sammy Nah <sa...@intel.com>
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#21).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/21
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 21
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#10).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 576 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/10
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 10
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [DRAFT] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#5).
Change subject: [DRAFT] Separate Memkind common code and NVM specific implementation
......................................................................
[DRAFT] Separate Memkind common code and NVM specific implementation
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 593 insertions(+), 430 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/5
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 5
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#7).
Change subject: [draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
No functional changes.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 593 insertions(+), 430 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/7
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 7
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#14).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 644 insertions(+), 487 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/14
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 14
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Sammy Nah has posted comments on this change. ( http://gerrit.cloudera.org:8080/19726 )
Change subject: [draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
Patch Set 8:
detailed change commits available at https://github.com/apache/kudu/pull/53
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 8
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 14 Apr 2023 12:35:03 +0000
Gerrit-HasComments: No
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#17).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 652 insertions(+), 492 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/17
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 17
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#13).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 576 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/13
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 13
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#16).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/16
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 16
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#18).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 652 insertions(+), 492 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/18
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 18
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [DRAFT] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#4).
Change subject: [DRAFT] Separate Memkind common code and NVM specific implementation
......................................................................
[DRAFT] Separate Memkind common code and NVM specific implementation
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 592 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/4
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 4
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#12).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 576 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/12
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 12
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#25).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/25
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 25
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#8).
Change subject: [draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[draft][KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 593 insertions(+), 430 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/8
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 8
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#24).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/24
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 24
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#23).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/23
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 23
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#19).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/19
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 19
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [DRAFT] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#2).
Change subject: [DRAFT] Separate Memkind common code and NVM specific implementation
......................................................................
[DRAFT] Separate Memkind common code and NVM specific implementation
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 591 insertions(+), 426 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/2
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 2
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#9).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 576 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/9
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 9
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#15).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/15
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 15
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [DRAFT] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#3).
Change subject: [DRAFT] Separate Memkind common code and NVM specific implementation
......................................................................
[DRAFT] Separate Memkind common code and NVM specific implementation
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 591 insertions(+), 427 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/3
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 3
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [nvm cache] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#27).
Change subject: [nvm_cache] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[nvm_cache] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/27
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 27
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [KUDU-3342] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#11).
Change subject: [KUDU-3342] Separate Memkind common code and NVM specific implementation
......................................................................
[KUDU-3342] Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 576 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/11
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 11
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [nvm cache] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#26).
Change subject: [nvm_cache] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[nvm_cache] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/26
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 26
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [DRAFT] Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#6).
Change subject: [DRAFT] Separate Memkind common code and NVM specific implementation
......................................................................
[DRAFT] Separate Memkind common code and NVM specific implementation
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 593 insertions(+), 430 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/6
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 6
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19726
to look at the new patch set (#22).
Change subject: [tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
......................................................................
[tablet] KUDU-3342 Separate Memkind common code and NVM specific implementation
Created memkind cache interface to minimize duplicate code between
NVM and HBM cache implementations based on the required API calls.
- https://memkind.github.io/memkind/man_pages/memkind.html
- http://memkind.github.io/memkind/man_pages/hbwmalloc.html
No functional changes.
Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
4 files changed, 650 insertions(+), 491 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/19726/22
--
To view, visit http://gerrit.cloudera.org:8080/19726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd329373449640258abd8a3bcf329dc1e0aa3020
Gerrit-Change-Number: 19726
Gerrit-PatchSet: 22
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Tidy Bot (241)