You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by ro...@apache.org on 2013/06/03 16:18:29 UTC
svn commit: r1489001 - in /mahout/trunk/core/src:
main/java/org/apache/mahout/math/VectorWritable.java
test/java/org/apache/mahout/math/VectorWritableTest.java
Author: robinanil
Date: Mon Jun 3 14:18:29 2013
New Revision: 1489001
URL: http://svn.apache.org/r1489001
Log:
MAHOUT-1238 VectorWritable's bug with VectorView of sparse vectors (Maysam Yabandeh)
Modified:
mahout/trunk/core/src/main/java/org/apache/mahout/math/VectorWritable.java
mahout/trunk/core/src/test/java/org/apache/mahout/math/VectorWritableTest.java
Modified: mahout/trunk/core/src/main/java/org/apache/mahout/math/VectorWritable.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/math/VectorWritable.java?rev=1489001&r1=1489000&r2=1489001&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/math/VectorWritable.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/math/VectorWritable.java Mon Jun 3 14:18:29 2013
@@ -157,7 +157,7 @@ public final class VectorWritable extend
}
}
} else {
- Varint.writeUnsignedVarInt(vector.getNumNondefaultElements(), out);
+ Varint.writeUnsignedVarInt(vector.getNumNonZeroElements(), out);
Iterator<Element> iter = vector.nonZeroes().iterator();
if (sequential) {
int lastIndex = 0;
Modified: mahout/trunk/core/src/test/java/org/apache/mahout/math/VectorWritableTest.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/test/java/org/apache/mahout/math/VectorWritableTest.java?rev=1489001&r1=1489000&r2=1489001&view=diff
==============================================================================
--- mahout/trunk/core/src/test/java/org/apache/mahout/math/VectorWritableTest.java (original)
+++ mahout/trunk/core/src/test/java/org/apache/mahout/math/VectorWritableTest.java Mon Jun 3 14:18:29 2013
@@ -30,6 +30,15 @@ import java.io.IOException;
public final class VectorWritableTest extends MahoutTestCase {
@Test
+ public void testViewSequentialAccessSparseVectorWritable() throws Exception {
+ Vector v = new SequentialAccessSparseVector(5);
+ v.set(1, 3.0);
+ v.set(3, 5.0);
+ Vector view = new VectorView(v,0,v.size());
+ doTestVectorWritableEquals(view);
+ }
+
+ @Test
public void testSequentialAccessSparseVectorWritable() throws Exception {
Vector v = new SequentialAccessSparseVector(5);
v.set(1, 3.0);