You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/09/20 22:02:14 UTC

[GitHub] [incubator-ratis] amaliujia opened a new pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

amaliujia opened a new pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205


   ## What changes were proposed in this pull request?
   
   Add a metric for tracking failed client requests on a server
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-830
   
   ## How was this patch tested?
   
   UT


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-697152309


   @runzhiwang  thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-695841954






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-696977404


   @bshashikant
   
   Updated to count on different types of failed requests. Can you take another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] runzhiwang merged pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-696221679


   @bshashikant 
   
   That's a good idea. Will split metrics to different types of request.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-696977404


   @bshashikant
   
   Updated to count on different types of failed requests. Can you take another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] runzhiwang commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-697143096


   @amaliujia Thanks the patch @bshashikant Thanks for review. I merged the patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #205: RATIS-830. Add a metric for tracking failed client requests on a server

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #205:
URL: https://github.com/apache/incubator-ratis/pull/205#issuecomment-695841954


   R: @bshashikant 
   
   Can you take a look please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org