You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2024/02/27 09:49:40 UTC
[PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
FMX opened a new pull request, #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338
### What changes were proposed in this pull request?
Add trace mark symbol.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#issuecomment-1968277856
> @FMX, does the logo picture in `docs/logo` directory need to add tm?
Referring to other projects, I think it is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#issuecomment-1966173836
Should we also change mkdoc.yml and web module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#issuecomment-1966385981
> Should we also change mkdoc.yml and web module?
Celeborn website doesn't use the mkdoc.yaml from this repo. It uses the https://github.com/apache/incubator-celeborn-website repo and I have changed that mkdoc.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#issuecomment-1968287726
merge to main(v0.5.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#issuecomment-1966194509
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.75%. Comparing base [(`4e64ae3`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/4e64ae32145290083fedb9083b91e51fcc5efc13?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a0a4cab`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2338?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2338 +/- ##
=======================================
Coverage 48.75% 48.75%
=======================================
Files 207 207
Lines 12946 12946
Branches 1113 1113
=======================================
Hits 6311 6311
Misses 6227 6227
Partials 408 408
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2338?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#discussion_r1503951989
##########
docs/developers/overview.md:
##########
@@ -18,7 +18,7 @@ license: |
# Celeborn Architecture
-This article introduces high level Apache Celeborn(Incubating) Architecture. For more detailed description of each module/process,
+This article introduces high level Apache Celeborn™(Incubating) Architecture. For more detailed description of each module/process,
Review Comment:
Miss the `Apache Celeborn(Incubating) solves the problems by reorganizing shuffle data in a more efficient way` in `overview.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2338: [CELEBORN-1295] Add tm to Celeborn's website.
URL: https://github.com/apache/incubator-celeborn/pull/2338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#discussion_r1503951989
##########
docs/developers/overview.md:
##########
@@ -18,7 +18,7 @@ license: |
# Celeborn Architecture
-This article introduces high level Apache Celeborn(Incubating) Architecture. For more detailed description of each module/process,
+This article introduces high level Apache Celeborn™(Incubating) Architecture. For more detailed description of each module/process,
Review Comment:
Miss the `Apache Celeborn(Incubating) solves the problems by reorganizing shuffle data in a more efficient way` in `overview.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1295] Add tm to Celeborn's website. [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2338:
URL: https://github.com/apache/incubator-celeborn/pull/2338#issuecomment-1967808806
@FMX, does the logo picture in `docs/logo` directory need to add tm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org