You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2023/08/12 01:22:22 UTC
[GitHub] [iceberg] szehon-ho opened a new pull request, #8300: Build: remove .java-version file
szehon-ho opened a new pull request, #8300:
URL: https://github.com/apache/iceberg/pull/8300
This was added in https://github.com/apache/iceberg/pull/3651, and I would like to propose its removal. We no longer have Spark 2, which was the only Java 8 dependency.
This is actually now the wrong default for jenv users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #8300: Build: remove .java-version file
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on PR #8300:
URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1679270103
Are there any other modules that are only compiled using JDK 8? Hive? Is that even being used?
I guess the primary benefit of having this file was to force building of all modules, which is helpful to catch compile-time errors after changes in `core`. Given that we changed our deprecation model and added support for quite a bit of Java versions at this point, I see how it may be surprising to have this override. I am OK either way but we need to double check our release scripts to make sure they have proper validation. We still have to use Java 8 there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho merged pull request #8300: Build: remove .java-version file
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho merged PR #8300:
URL: https://github.com/apache/iceberg/pull/8300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #8300: Build: remove .java-version file
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #8300:
URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1679327176
I think this file is for jenv users only. There is a explicit check for java version in release: https://github.com/apache/iceberg/blob/master/deploy.gradle#L21 so we should be fine there as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #8300: Build: remove .java-version file
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #8300:
URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1677825100
In my thought, as [build.gradle](https://github.com/apache/iceberg/blob/master/build.gradle#L58) supports building of all Java versions, it could be a surprise to jenv users that Iceberg overrides the user's global default. Also i took a brief look at some other projects like Parquet/Spark/Flink/Hive, and didn't see .java-version there. I think this made sense before when Spark 2 was not built without java8, but now that has been removed and don't see a strong reason to default Iceberg to a specific java version overriding the user's default. That being said, I can leave this a little bit and see if anyone has strong comments against its removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #8300: Build: remove .java-version file
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #8300:
URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1675595352
@findepi @nastra @RussellSpitzer does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #8300: Build: remove .java-version file
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #8300:
URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1688649260
Merging, I think there's no strong objection. If we have some reason in future to must build with a certain Java version, we can put this back. For now, as Iceberg can be built in many distro using different Java version, this allows more flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #8300: Build: remove .java-version file
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #8300:
URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1677420632
`.java-version` is used by jenv to pick the right version for particular project. I don't know any other convention or tooling that would solve this mundane problem of choosing the right JDK, which might be a challenge for people who work on different projects having different minimum JDK versions. I do recommend having such a file (with correct contents of course), but it's up to project maintainers to decide. After all the maintainers choose whether they maintain or drop a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org