[impala] 01/03: IMPALA-9849: Set halt_on_error=1 for TSAN builds

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 38b96174621c7d2f58b580d1e2bba4b95b261d1c
Author: Sahil Takiar <ta...@gmail.com>
AuthorDate: Mon Jun 8 11:35:05 2020 -0700

    IMPALA-9849: Set halt_on_error=1 for TSAN builds
    
    Set halt_on_error to true by default for TSAN builds (we already do this
    for ASAN builds). This ensures that Impala crashes whenever a TSAN error
    is detected. IMPALA-9568 accidentally broke this.
    
    Testing:
    * Ran dataload + be tests in a TSAN build
    
    Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
    Reviewed-on: http://gerrit.cloudera.org:8080/16069
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/common/init.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/common/init.cc b/be/src/common/init.cc
index db47282..4524f44 100644
--- a/be/src/common/init.cc
+++ b/be/src/common/init.cc
@@ -426,7 +426,7 @@ extern "C" const char* __tsan_default_options() {
 #else
          "1 "
 #endif
-         "history_size=7 allocator_may_return_null=1 "
+         "halt_on_error=1 history_size=7 allocator_may_return_null=1 "
          "suppressions=" THREAD_SANITIZER_SUPPRESSIONS;
 }
 #endif