You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:42:43 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #13456: Support more query statements to convert between SQLStatement and SqlNode
strongduanmu opened a new issue, #13456:
URL: https://github.com/apache/shardingsphere/issues/13456
This issue is a subtask of #13091.
At present, we have carried out a parameterized unit test for SQLStatement convert in the `shardingsphere-optimize-test` module, but there are still many scenarios that do not support. We need to support more query statements and support more database dialects.
Considering the importance of this task, I would like to invite @LeeGuoPing to participate in this work.
In order to find out the query statements that are not currently supported, we can delete the `SUPPORTED_SQL_CASE_IDS` condition, let all scenarios execute the test, and then be able to find our target. Due to the relatively large workload, I suggest starting with MySQL support first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1445350831
Hi @kanha-gupta, `SQLNodeConverterEngine` can be used as an entry point to understand this issue. At present, the federated query engine relies on SQLNodeConverterEngine to realize the conversion between ShardingSphere SQLStatement and Calcite SqlNode, so as to take advantage of some capabilities of Calcite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1208840787
We can refer this convert logic——https://github.com/ApsaraDB/galaxysql/blob/main/polardbx-optimizer/src/main/java/com/alibaba/polardbx/optimizer/parse/visitor/FastSqlToCalciteNodeVisitor.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1445353439
@strongduanmu Thanks ! So to add support for more SQL queries, is Antlr parsed Generated code is used ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support more query statements to convert between SQLStatement and SqlNode [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1761137743
This task is so large that no one can actually complete it, so I will close this issue and replace it with more smaller issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1219349955
Ref #19580.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support more query statements to convert between SQLStatement and SqlNode [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #13456: Support more query statements to convert between SQLStatement and SqlNode
URL: https://github.com/apache/shardingsphere/issues/13456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1444849958
@strongduanmu @LeeGuoPing
Hey ! I would like to work on this. While adding support for new Sql queries, are there any Documents or Code available to refer to ? to understand the required logic & implementation purposes.
I am currently checking up previous PRs & Would start adding up more ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kanha-gupta commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by "kanha-gupta (via GitHub)" <gi...@apache.org>.
kanha-gupta commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1459689401
Okay I'll look into it.
Thanks alot for guidance :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1457296508
>
Yes, the responsibility of SQLNodeConverterEngine is to convert the SQLStatement parsed and visited by ANTLR into Calcite SqlNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13456:
URL: https://github.com/apache/shardingsphere/issues/13456#issuecomment-1272350695
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #13456: Support more query statements to convert between SQLStatement and SqlNode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #13456: Support more query statements to convert between SQLStatement and SqlNode
URL: https://github.com/apache/shardingsphere/issues/13456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org