You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/23 17:12:19 UTC
[GitHub] [maven-javadoc-plugin] cstamas commented on a diff in pull request #186: [MJAVADOC-742] Fix resolution of docletArtifacts
cstamas commented on code in PR #186:
URL: https://github.com/apache/maven-javadoc-plugin/pull/186#discussion_r1116004995
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -3242,8 +3241,11 @@ private List<String> getArtifactsAbsolutePath(JavadocPathArtifact javadocArtifac
DependencyFilter filter = new ScopeDependencyFilter(
Arrays.asList(Artifact.SCOPE_COMPILE, Artifact.SCOPE_PROVIDED), Collections.emptySet());
- DependencyRequest req =
- new DependencyRequest(new DefaultDependencyNode(RepositoryUtils.toArtifact(artifact)), filter);
+ DependencyRequest req = new DependencyRequest(
Review Comment:
feel free to take over the PR, I verified it against the user provided reproducer in MJAVADOC-742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org