You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2006/07/04 14:21:29 UTC

[jira] Created: (HARMONY-744) [classlib] Move vmi, zip, zlib and luni natives to their relevant modules

[classlib] Move vmi, zip, zlib and luni natives to their relevant modules
-------------------------------------------------------------------------

         Key: HARMONY-744
         URL: http://issues.apache.org/jira/browse/HARMONY-744
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Oliver Deakin


The penultimate step in native modularisation. This JIRA will:
 - Move the native code for luni and vmi into the luni module, and for zip and zlib into the archive module.
 - Patch the build system to understand the new code locations.

I will attach a patch to carry these steps out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-744) [classlib] Move vmi, zip, zlib and luni natives to their relevant modules

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-744?page=all ]
     
Tim Ellison resolved HARMONY-744:
---------------------------------

    Resolution: Fixed

Thanks Oliver.

Patch applied at repo revision r418998.

Please check that the patch was applied as you expected.


> [classlib] Move vmi, zip, zlib and luni natives to their relevant modules
> -------------------------------------------------------------------------
>
>          Key: HARMONY-744
>          URL: http://issues.apache.org/jira/browse/HARMONY-744
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.zip.zlib.luni.vmi.natives.diff, modularise.zip.zlib.luni.vmi.natives.sh
>
> The penultimate step in native modularisation. This JIRA will:
>  - Move the native code for luni and vmi into the luni module, and for zip and zlib into the archive module.
>  - Patch the build system to understand the new code locations.
> I will attach a patch to carry these steps out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-744) [classlib] Move vmi, zip, zlib and luni natives to their relevant modules

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-744?page=all ]

Tim Ellison reassigned HARMONY-744:
-----------------------------------

    Assign To: Tim Ellison

> [classlib] Move vmi, zip, zlib and luni natives to their relevant modules
> -------------------------------------------------------------------------
>
>          Key: HARMONY-744
>          URL: http://issues.apache.org/jira/browse/HARMONY-744
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.zip.zlib.luni.vmi.natives.diff, modularise.zip.zlib.luni.vmi.natives.sh
>
> The penultimate step in native modularisation. This JIRA will:
>  - Move the native code for luni and vmi into the luni module, and for zip and zlib into the archive module.
>  - Patch the build system to understand the new code locations.
> I will attach a patch to carry these steps out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-744) [classlib] Move vmi, zip, zlib and luni natives to their relevant modules

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-744?page=comments#action_12419131 ] 

Oliver Deakin commented on HARMONY-744:
---------------------------------------

Looks good, thanks Tim.

> [classlib] Move vmi, zip, zlib and luni natives to their relevant modules
> -------------------------------------------------------------------------
>
>          Key: HARMONY-744
>          URL: http://issues.apache.org/jira/browse/HARMONY-744
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.zip.zlib.luni.vmi.natives.diff, modularise.zip.zlib.luni.vmi.natives.sh
>
> The penultimate step in native modularisation. This JIRA will:
>  - Move the native code for luni and vmi into the luni module, and for zip and zlib into the archive module.
>  - Patch the build system to understand the new code locations.
> I will attach a patch to carry these steps out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-744) [classlib] Move vmi, zip, zlib and luni natives to their relevant modules

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-744?page=all ]

Oliver Deakin updated HARMONY-744:
----------------------------------

    Attachment: modularise.zip.zlib.luni.vmi.natives.sh
                modularise.zip.zlib.luni.vmi.natives.diff

Here are my proposed patches.

modularise.zip.zlib.luni.vmi.natives.sh moves the native code for zip and zlib into the archive module, and luni and vmi into the luni module. It also moves 2 headers from fdlibm into the shared set of header files at modules/luni/src/main/native/include/shared.

modularise.zip.zlib.luni.vmi.natives.diff updates the build system to recognise the new code locations.

Please apply modularise.zip.zlib.luni.vmi.natives.sh before modularise.zip.zlib.luni.vmi.natives.diff. They should both be applied to the root directory of a classlib/trunk checkout.

Once they are applied, the following svn:ignore properties will need to be set:
*.dll, *.map, *.pdb and *.so added to svn:ignore for modules/luni/src/main/native/luni and modules/archive/src/main/native/zlib

> [classlib] Move vmi, zip, zlib and luni natives to their relevant modules
> -------------------------------------------------------------------------
>
>          Key: HARMONY-744
>          URL: http://issues.apache.org/jira/browse/HARMONY-744
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>  Attachments: modularise.zip.zlib.luni.vmi.natives.diff, modularise.zip.zlib.luni.vmi.natives.sh
>
> The penultimate step in native modularisation. This JIRA will:
>  - Move the native code for luni and vmi into the luni module, and for zip and zlib into the archive module.
>  - Patch the build system to understand the new code locations.
> I will attach a patch to carry these steps out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-744) [classlib] Move vmi, zip, zlib and luni natives to their relevant modules

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-744?page=all ]
     
Tim Ellison closed HARMONY-744:
-------------------------------


Verified by Oliver.


> [classlib] Move vmi, zip, zlib and luni natives to their relevant modules
> -------------------------------------------------------------------------
>
>          Key: HARMONY-744
>          URL: http://issues.apache.org/jira/browse/HARMONY-744
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.zip.zlib.luni.vmi.natives.diff, modularise.zip.zlib.luni.vmi.natives.sh
>
> The penultimate step in native modularisation. This JIRA will:
>  - Move the native code for luni and vmi into the luni module, and for zip and zlib into the archive module.
>  - Patch the build system to understand the new code locations.
> I will attach a patch to carry these steps out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira