You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dtenedor (via GitHub)" <gi...@apache.org> on 2024/08/21 22:00:07 UTC
[PR] [SPARK-49342][SQL] Make TO_AVRO SQL function 'jsonFormatSchema' argument optional [spark]
dtenedor opened a new pull request, #47834:
URL: https://github.com/apache/spark/pull/47834
### What changes were proposed in this pull request?
This PR make the `TO_AVRO` SQL function `jsonFormatSchema` argument optional.
For example, now it is possible to just call it with a single input argument:
```
create table t as
select named_struct('u', named_struct('member0', member0, 'member1', member1)) as s
from values (1, null), (null, 'a') tab(member0, member1);
select length(to_avro(s)) > 0 from t;
> true
true
```
### Why are the changes needed?
This makes the `TO_AVRO` SQL function easier to use.
### Does this PR introduce _any_ user-facing change?
Yes, see above.
### How was this patch tested?
This PR adds unit test coverge.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49342][SQL] Make TO_AVRO SQL function 'jsonFormatSchema' argument optional [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #47834: [SPARK-49342][SQL] Make TO_AVRO SQL function 'jsonFormatSchema' argument optional
URL: https://github.com/apache/spark/pull/47834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49342][SQL] Make TO_AVRO SQL function 'jsonFormatSchema' argument optional [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #47834:
URL: https://github.com/apache/spark/pull/47834#issuecomment-2303081383
cc @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49342][SQL] Make TO_AVRO SQL function 'jsonFormatSchema' argument optional [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #47834:
URL: https://github.com/apache/spark/pull/47834#issuecomment-2306304695
+1, LGTM. Merging to master.
Thank you, @dtenedor and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49342][SQL] Make TO_AVRO SQL function 'jsonFormatSchema' argument optional [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #47834:
URL: https://github.com/apache/spark/pull/47834#issuecomment-2305926095
Sure, good catch @MaxGekk, this is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org