You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/20 16:57:12 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #383:
HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
adoroszlai opened a new pull request #383: HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
URL: https://github.com/apache/hadoop-ozone/pull/383
## What changes were proposed in this pull request?
`ozonefs` and `tools` modules in `hadoop-ozone` have a mix of unit and integration tests. This PR proposes to
1. switch dependency order: let `integration-test` depend on these modules instead of the other way around
2. move integration tests (those that use `Mini*Cluster`) from these modules to `integration-test`
3. let `unit` check run remaining tests in these modules
This improves code coverage in CI.
https://issues.apache.org/jira/browse/HDDS-2785
## How was this patch tested?
Clean CI run in fork: https://github.com/adoroszlai/hadoop-ozone/commits/HDDS-2785
Ran integration tests locally (with failures).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #383: HDDS-2785. Move
ozonefs and tools minicluster tests to integration-test
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #383: HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
URL: https://github.com/apache/hadoop-ozone/pull/383#issuecomment-571134019
Thanks @elek for bringing this up.
> 1. put everything to the `integration-test` and use profiles to separate tests
> 2. create separated `integration-test/contract` and `integration-test/tools` projects
> 3. Keep the tests in the original projects and use the maven `integration-test` phase to execute these tests.
>
> What is your preference?
I think option 1 would give us the most fine-grained control for grouping tests to ensure similar run time of the parallel jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #383: HDDS-2785. Move
ozonefs and tools minicluster tests to integration-test
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #383: HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
URL: https://github.com/apache/hadoop-ozone/pull/383#issuecomment-571174456
Thanks @elek for reviewing and committing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #383: HDDS-2785. Move
ozonefs and tools minicluster tests to integration-test
Posted by GitBox <gi...@apache.org>.
elek commented on issue #383: HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
URL: https://github.com/apache/hadoop-ozone/pull/383#issuecomment-571096821
Thanks the patch @adoroszlai. I like the approach to reverse the dependency (and simplify `acceptance.sh` and `unit.sh`), but I would prefer to keep the feature to separate certain type of integration tests as in this branch/runs:
https://github.com/apache/hadoop-ozone/runs/373475163
The test execution of integration-test project is already very slow, we can make it faster with separating contract/tools tests. I am not sure how to do it in this new structure. We have multiple options:
1. put everything to the `integration-test` and use profiles to separate tests
2. create separated `integration-test/contract` and `integration-test/tools` projects
3. Keep the tests in the original projects and use the maven `integration-test` phase to execute these tests.
What is your preference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #383: HDDS-2785. Move
ozonefs and tools minicluster tests to integration-test
Posted by GitBox <gi...@apache.org>.
elek commented on issue #383: HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
URL: https://github.com/apache/hadoop-ozone/pull/383#issuecomment-571153455
> I think option 1 would give us the most fine-grained control for grouping tests to ensure similar run time of the parallel jobs.
In this case let me commit this one, and we can introduce the new profiles in the patch where the integration tests are enabled...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #383: HDDS-2785. Move
ozonefs and tools minicluster tests to integration-test
Posted by GitBox <gi...@apache.org>.
elek closed pull request #383: HDDS-2785. Move ozonefs and tools minicluster tests to integration-test
URL: https://github.com/apache/hadoop-ozone/pull/383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org