You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 00:39:03 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #10986: feat(listview): feature flag config to set default viewing mode
nytai opened a new pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes https://github.com/apache/incubator-superset/issues/10782
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.57% 61.27% -0.31%
==========================================
Files 815 382 -433
Lines 38337 24141 -14196
Branches 3599 0 -3599
==========================================
- Hits 23606 14792 -8814
+ Misses 14545 9349 -5196
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.27% <66.66%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/logger/LogUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy5qcw==) | | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | | |
| [superset-frontend/src/components/AvatarIcon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXZhdGFySWNvbi50c3g=) | | |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [e4e78b6...aa90ec8](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.57% 61.27% -0.31%
==========================================
Files 815 382 -433
Lines 38337 24141 -14196
Branches 3599 0 -3599
==========================================
- Hits 23606 14792 -8814
+ Misses 14545 9349 -5196
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.27% <66.66%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
| [.../src/SqlLab/components/EstimateQueryCostButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0VzdGltYXRlUXVlcnlDb3N0QnV0dG9uLmpzeA==) | | |
| [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
| [...perset-frontend/src/components/FilterBadgeIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyQmFkZ2VJY29uLmpzeA==) | | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | | |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [e4e78b6...2dd8385](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dc893fe1b3b86e2921bb77e08a531db46b3f8e5d?el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.46% 61.09% -0.37%
==========================================
Files 382 816 +434
Lines 24139 38365 +14226
Branches 0 3608 +3608
==========================================
+ Hits 14836 23439 +8603
- Misses 9303 14740 +5437
- Partials 0 186 +186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.69% <60.00%> (?)` | |
| #python | `60.74% <66.66%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.79% <50.00%> (ø)` | |
| [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `70.08% <50.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `87.50% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [dc893fe...15195a9](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.57% 61.27% -0.31%
==========================================
Files 815 382 -433
Lines 38337 24141 -14196
Branches 3599 0 -3599
==========================================
- Hits 23606 14792 -8814
+ Misses 14545 9349 -5196
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.27% <66.66%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | | |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | | |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [e4e78b6...aa90ec8](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.57% 61.27% -0.31%
==========================================
Files 815 382 -433
Lines 38337 24141 -14196
Branches 3599 0 -3599
==========================================
- Hits 23606 14792 -8814
+ Misses 14545 9349 -5196
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.27% <66.66%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | | |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | | |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [e4e78b6...aa90ec8](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#discussion_r492872066
##########
File path: superset/config.py
##########
@@ -309,8 +309,12 @@ def _try_json_readsha( # pylint: disable=unused-argument
"SIP_38_VIZ_REARCHITECTURE": False,
"TAGGING_SYSTEM": False,
"SQLLAB_BACKEND_PERSISTENCE": False,
+ "LISTVIEWS_DEFAULT_CARD_VIEW": False,
}
+if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
+ DEFAULT_FEATURE_FLAGS["LISTVIEW_DEFAULT_CARD_VIEW"] = True
Review comment:
could you add a small comment describing this feature flag ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#discussion_r492872066
##########
File path: superset/config.py
##########
@@ -309,8 +309,12 @@ def _try_json_readsha( # pylint: disable=unused-argument
"SIP_38_VIZ_REARCHITECTURE": False,
"TAGGING_SYSTEM": False,
"SQLLAB_BACKEND_PERSISTENCE": False,
+ "LISTVIEWS_DEFAULT_CARD_VIEW": False,
}
+if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
+ DEFAULT_FEATURE_FLAGS["LISTVIEW_DEFAULT_CARD_VIEW"] = True
Review comment:
could you add a small comment describing this feature flag ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.57% 61.44% -0.13%
==========================================
Files 815 382 -433
Lines 38337 24141 -14196
Branches 3599 0 -3599
==========================================
- Hits 23606 14834 -8772
+ Misses 14545 9307 -5238
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.44% <66.66%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.61% <0.00%> (-0.68%)` | :arrow_down: |
| [...board/components/gridComponents/new/NewDivider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEaXZpZGVyLmpzeA==) | | |
| [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | | |
| [...src/dashboard/components/DeleteComponentButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0RlbGV0ZUNvbXBvbmVudEJ1dHRvbi5qc3g=) | | |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5bGlzdGVuZXJzLmpzeA==) | | |
| [superset-frontend/src/explore/dateFilterUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZGF0ZUZpbHRlclV0aWxzLnRz) | | |
| [.../src/dashboard/components/menu/PopoverDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvUG9wb3ZlckRyb3Bkb3duLmpzeA==) | | |
| [...-frontend/src/components/Button/Button.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL0J1dHRvbi5zdG9yaWVzLmpzeA==) | | |
| ... and [422 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [e4e78b6...2dd8385](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dc893fe1b3b86e2921bb77e08a531db46b3f8e5d?el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.46% 60.74% -0.72%
==========================================
Files 382 383 +1
Lines 24139 24151 +12
==========================================
- Hits 14836 14670 -166
- Misses 9303 9481 +178
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.74% <66.66%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.53% <0.00%> (-11.76%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.39% <0.00%> (-0.52%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [dc893fe...15195a9](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=h1) Report
> Merging [#10986](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4e78b66fa82acbe8e5bc425d697ff11b4a0cc3f?el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10986 +/- ##
==========================================
- Coverage 61.57% 61.27% -0.31%
==========================================
Files 815 382 -433
Lines 38337 24141 -14196
Branches 3599 0 -3599
==========================================
- Hits 23606 14792 -8814
+ Misses 14545 9349 -5196
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `61.27% <66.66%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <66.66%> (-0.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | | |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | | |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/10986/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=footer). Last update [e4e78b6...aa90ec8](https://codecov.io/gh/apache/incubator-superset/pull/10986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986#issuecomment-696463931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #10986: feat(listview): feature flag config to set default viewing mode
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10986:
URL: https://github.com/apache/incubator-superset/pull/10986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org